Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Stephan Gerhold <stephan@gerhold.net>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Stephan Gerhold <stephan@gerhold.net>,
	Andy Gross <agross@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	Amit Kucheria <amit.kucheria@linaro.org>,
	~postmarketos/upstreaming@lists.sr.ht
Subject: [PATCH 02/14] arm64: dts: qcom: msm8916: Remove one more thermal trip point unit name
Date: Tue, 15 Sep 2020 09:12:09 +0200	[thread overview]
Message-ID: <20200915071221.72895-3-stephan@gerhold.net> (raw)
In-Reply-To: <20200915071221.72895-1-stephan@gerhold.net>

Commit fe2aff0c574d2 ("arm64: dts: qcom: msm8916: remove unit name for thermal trip points")
removed the unit names for most of the thermal trip points defined
in msm8916.dtsi, but missed to update the one for cpu0_1-thermal.

So why wasn't this spotted by "make dtbs_check"? Apparently, the name
of the thermal zone is already invalid: thermal-zones.yaml specifies
a regex of ^[a-zA-Z][a-zA-Z0-9\\-]{1,12}-thermal$, so it is not allowed
to contain underscores. Therefore the thermal zone was never verified
using the DTB schema.

After replacing the underscore in the thermal zone name, the warning
shows up:

    apq8016-sbc.dt.yaml: thermal-zones: cpu0-1-thermal:trips: 'trip-point@0'
    does not match any of the regexes: '^[a-zA-Z][a-zA-Z0-9\\-_]{0,63}$', 'pinctrl-[0-9]+'

Fix up the thermal zone names and remove the unit name for the trip point.

Cc: Amit Kucheria <amit.kucheria@linaro.org>
Fixes: fe2aff0c574d2 ("arm64: dts: qcom: msm8916: remove unit name for thermal trip points")
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
---
 arch/arm64/boot/dts/qcom/msm8916.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index d6a5b60846d9..d84118fb4403 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -229,14 +229,14 @@ pmu {
 	};
 
 	thermal-zones {
-		cpu0_1-thermal {
+		cpu0-1-thermal {
 			polling-delay-passive = <250>;
 			polling-delay = <1000>;
 
 			thermal-sensors = <&tsens 5>;
 
 			trips {
-				cpu0_1_alert0: trip-point@0 {
+				cpu0_1_alert0: trip-point0 {
 					temperature = <75000>;
 					hysteresis = <2000>;
 					type = "passive";
@@ -259,7 +259,7 @@ map0 {
 			};
 		};
 
-		cpu2_3-thermal {
+		cpu2-3-thermal {
 			polling-delay-passive = <250>;
 			polling-delay = <1000>;
 
-- 
2.28.0


  parent reply	other threads:[~2020-09-15  7:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-15  7:12 [PATCH 00/14] Cleanup & sort msm8916.dtsi, various minor fixes Stephan Gerhold
2020-09-15  7:12 ` [PATCH 01/14] arm64: dts: qcom: msm8916: Configure DSI port with labels Stephan Gerhold
2020-09-15  7:12 ` Stephan Gerhold [this message]
2020-09-15  7:12 ` [PATCH 03/14] arm64: dts: qcom: pm8916: Remove invalid reg size from wcd_codec Stephan Gerhold
2020-09-15  7:12 ` [PATCH 04/14] arm64: dts: qcom: msm8916: Fix MDP/DSI interrupts Stephan Gerhold
2020-09-15  7:12 ` [PATCH 05/14] arm64: dts: qcom: msm8916: Use IRQ defines, add IRQ types Stephan Gerhold
2020-09-15  7:12 ` [PATCH 06/14] arm64: dts: qcom: msm8916: Drop qcom,tcsr-mutex syscon Stephan Gerhold
2020-09-15 15:38   ` Bjorn Andersson
2020-09-15  7:12 ` [PATCH 07/14] arm64: dts: qcom: msm8916: Minor style fixes Stephan Gerhold
2020-09-15  7:12 ` [PATCH 08/14] arm64: dts: qcom: msm8916: Add MSM8916-specific compatibles to SCM/MSS Stephan Gerhold
2020-09-15  7:12 ` [PATCH 09/14] arm64: dts: qcom: msm8916: Use more generic node names Stephan Gerhold
2020-09-15  7:12 ` [PATCH 10/14] arm64: dts: qcom: msm8916: Rename "x-smp2p" to "smp2p-x" Stephan Gerhold
2020-09-15  7:12 ` [PATCH 11/14] arm64: dts: qcom: msm8916: Pad addresses Stephan Gerhold
2020-09-15  7:12 ` [PATCH 12/14] arm64: dts: qcom: msm8916: Sort nodes Stephan Gerhold
2020-09-15  7:12 ` [PATCH 13/14] arm64: dts: qcom: pm8916: " Stephan Gerhold
2020-09-15  7:12 ` [PATCH 14/14] arm64: dts: qcom: Makefile: Sort lines Stephan Gerhold
2020-09-15 15:42 ` [PATCH 00/14] Cleanup & sort msm8916.dtsi, various minor fixes Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200915071221.72895-3-stephan@gerhold.net \
    --to=stephan@gerhold.net \
    --cc=agross@kernel.org \
    --cc=amit.kucheria@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox