From: Stephan Gerhold <stephan@gerhold.net>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Stephan Gerhold <stephan@gerhold.net>,
Andy Gross <agross@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
Amit Kucheria <amit.kucheria@linaro.org>,
~postmarketos/upstreaming@lists.sr.ht
Subject: [PATCH 03/14] arm64: dts: qcom: pm8916: Remove invalid reg size from wcd_codec
Date: Tue, 15 Sep 2020 09:12:10 +0200 [thread overview]
Message-ID: <20200915071221.72895-4-stephan@gerhold.net> (raw)
In-Reply-To: <20200915071221.72895-1-stephan@gerhold.net>
Tha parent node of "wcd_codec" specifies #address-cells = <1>
and #size-cells = <0>, which means that each resource should be
described by one cell for the address and size omitted.
However, wcd_codec currently lists 0x200 as second cell (probably
the size of the resource). When parsing this would be treated like
another memory resource - which is entirely wrong.
To quote the device tree specification [1]:
"If the parent node specifies a value of 0 for #size-cells,
the length field in the value of reg shall be omitted."
[1]: https://www.devicetree.org/specifications/
Fixes: 5582fcb3829f ("arm64: dts: apq8016-sbc: add analog audio support with multicodec")
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
---
arch/arm64/boot/dts/qcom/pm8916.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/pm8916.dtsi b/arch/arm64/boot/dts/qcom/pm8916.dtsi
index c3f62090aff7..636ef9db9a14 100644
--- a/arch/arm64/boot/dts/qcom/pm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8916.dtsi
@@ -127,7 +127,7 @@ pm8916_vib: vibrator@c000 {
wcd_codec: codec@f000 {
compatible = "qcom,pm8916-wcd-analog-codec";
- reg = <0xf000 0x200>;
+ reg = <0xf000>;
reg-names = "pmic-codec-core";
clocks = <&gcc GCC_CODEC_DIGCODEC_CLK>;
clock-names = "mclk";
--
2.28.0
next prev parent reply other threads:[~2020-09-15 7:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 7:12 [PATCH 00/14] Cleanup & sort msm8916.dtsi, various minor fixes Stephan Gerhold
2020-09-15 7:12 ` [PATCH 01/14] arm64: dts: qcom: msm8916: Configure DSI port with labels Stephan Gerhold
2020-09-15 7:12 ` [PATCH 02/14] arm64: dts: qcom: msm8916: Remove one more thermal trip point unit name Stephan Gerhold
2020-09-15 7:12 ` Stephan Gerhold [this message]
2020-09-15 7:12 ` [PATCH 04/14] arm64: dts: qcom: msm8916: Fix MDP/DSI interrupts Stephan Gerhold
2020-09-15 7:12 ` [PATCH 05/14] arm64: dts: qcom: msm8916: Use IRQ defines, add IRQ types Stephan Gerhold
2020-09-15 7:12 ` [PATCH 06/14] arm64: dts: qcom: msm8916: Drop qcom,tcsr-mutex syscon Stephan Gerhold
2020-09-15 15:38 ` Bjorn Andersson
2020-09-15 7:12 ` [PATCH 07/14] arm64: dts: qcom: msm8916: Minor style fixes Stephan Gerhold
2020-09-15 7:12 ` [PATCH 08/14] arm64: dts: qcom: msm8916: Add MSM8916-specific compatibles to SCM/MSS Stephan Gerhold
2020-09-15 7:12 ` [PATCH 09/14] arm64: dts: qcom: msm8916: Use more generic node names Stephan Gerhold
2020-09-15 7:12 ` [PATCH 10/14] arm64: dts: qcom: msm8916: Rename "x-smp2p" to "smp2p-x" Stephan Gerhold
2020-09-15 7:12 ` [PATCH 11/14] arm64: dts: qcom: msm8916: Pad addresses Stephan Gerhold
2020-09-15 7:12 ` [PATCH 12/14] arm64: dts: qcom: msm8916: Sort nodes Stephan Gerhold
2020-09-15 7:12 ` [PATCH 13/14] arm64: dts: qcom: pm8916: " Stephan Gerhold
2020-09-15 7:12 ` [PATCH 14/14] arm64: dts: qcom: Makefile: Sort lines Stephan Gerhold
2020-09-15 15:42 ` [PATCH 00/14] Cleanup & sort msm8916.dtsi, various minor fixes Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915071221.72895-4-stephan@gerhold.net \
--to=stephan@gerhold.net \
--cc=agross@kernel.org \
--cc=amit.kucheria@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox