* [PATCH] bus: mhi: Remove include of rwlock_types.h
@ 2020-09-15 7:48 Sebastian Andrzej Siewior
2020-09-15 8:17 ` Manivannan Sadhasivam
2020-09-15 8:21 ` Manivannan Sadhasivam
0 siblings, 2 replies; 3+ messages in thread
From: Sebastian Andrzej Siewior @ 2020-09-15 7:48 UTC (permalink / raw)
To: linux-arm-msm
Cc: Manivannan Sadhasivam, Hemant Kumar, Clark Williams,
Thomas Gleixner, Peter Zijlstra
From: Clark Williams <williams@redhat.com>
rwlock.h should not be included directly. Instead linux/splinlock.h
should be included. Including it directly will break the RT build.
Also there is no point in including _types.h headers directly. There is
no benefit in including the type without the accessor.
Fixes: 0cbf260820fa7 ("bus: mhi: core: Add support for registering MHI controllers")
Signed-off-by: Clark Williams <williams@redhat.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
include/linux/mhi.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/linux/mhi.h b/include/linux/mhi.h
index c4a940d989121..2b4ed30d47294 100644
--- a/include/linux/mhi.h
+++ b/include/linux/mhi.h
@@ -9,10 +9,9 @@
#include <linux/device.h>
#include <linux/dma-direction.h>
#include <linux/mutex.h>
-#include <linux/rwlock_types.h>
#include <linux/skbuff.h>
#include <linux/slab.h>
-#include <linux/spinlock_types.h>
+#include <linux/spinlock.h>
#include <linux/wait.h>
#include <linux/workqueue.h>
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] bus: mhi: Remove include of rwlock_types.h
2020-09-15 7:48 [PATCH] bus: mhi: Remove include of rwlock_types.h Sebastian Andrzej Siewior
@ 2020-09-15 8:17 ` Manivannan Sadhasivam
2020-09-15 8:21 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2020-09-15 8:17 UTC (permalink / raw)
To: Sebastian Andrzej Siewior
Cc: linux-arm-msm, Hemant Kumar, Clark Williams, Thomas Gleixner,
Peter Zijlstra
On Tue, Sep 15, 2020 at 09:48:16AM +0200, Sebastian Andrzej Siewior wrote:
> From: Clark Williams <williams@redhat.com>
>
> rwlock.h should not be included directly. Instead linux/splinlock.h
> should be included. Including it directly will break the RT build.
>
> Also there is no point in including _types.h headers directly. There is
> no benefit in including the type without the accessor.
>
> Fixes: 0cbf260820fa7 ("bus: mhi: core: Add support for registering MHI controllers")
> Signed-off-by: Clark Williams <williams@redhat.com>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> include/linux/mhi.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/linux/mhi.h b/include/linux/mhi.h
> index c4a940d989121..2b4ed30d47294 100644
> --- a/include/linux/mhi.h
> +++ b/include/linux/mhi.h
> @@ -9,10 +9,9 @@
> #include <linux/device.h>
> #include <linux/dma-direction.h>
> #include <linux/mutex.h>
> -#include <linux/rwlock_types.h>
> #include <linux/skbuff.h>
> #include <linux/slab.h>
> -#include <linux/spinlock_types.h>
> +#include <linux/spinlock.h>
> #include <linux/wait.h>
> #include <linux/workqueue.h>
>
> --
> 2.28.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] bus: mhi: Remove include of rwlock_types.h
2020-09-15 7:48 [PATCH] bus: mhi: Remove include of rwlock_types.h Sebastian Andrzej Siewior
2020-09-15 8:17 ` Manivannan Sadhasivam
@ 2020-09-15 8:21 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2020-09-15 8:21 UTC (permalink / raw)
To: Sebastian Andrzej Siewior
Cc: linux-arm-msm, Hemant Kumar, Clark Williams, Thomas Gleixner,
Peter Zijlstra
On Tue, Sep 15, 2020 at 09:48:16AM +0200, Sebastian Andrzej Siewior wrote:
> From: Clark Williams <williams@redhat.com>
>
> rwlock.h should not be included directly. Instead linux/splinlock.h
> should be included. Including it directly will break the RT build.
>
> Also there is no point in including _types.h headers directly. There is
> no benefit in including the type without the accessor.
>
> Fixes: 0cbf260820fa7 ("bus: mhi: core: Add support for registering MHI controllers")
> Signed-off-by: Clark Williams <williams@redhat.com>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Applied to mhi-next!
Thanks,
Mani
> ---
> include/linux/mhi.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/linux/mhi.h b/include/linux/mhi.h
> index c4a940d989121..2b4ed30d47294 100644
> --- a/include/linux/mhi.h
> +++ b/include/linux/mhi.h
> @@ -9,10 +9,9 @@
> #include <linux/device.h>
> #include <linux/dma-direction.h>
> #include <linux/mutex.h>
> -#include <linux/rwlock_types.h>
> #include <linux/skbuff.h>
> #include <linux/slab.h>
> -#include <linux/spinlock_types.h>
> +#include <linux/spinlock.h>
> #include <linux/wait.h>
> #include <linux/workqueue.h>
>
> --
> 2.28.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-15 8:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-15 7:48 [PATCH] bus: mhi: Remove include of rwlock_types.h Sebastian Andrzej Siewior
2020-09-15 8:17 ` Manivannan Sadhasivam
2020-09-15 8:21 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox