* [PATCH v2] mhi: pci_generic: Fix implicit conversion warning
@ 2020-12-02 8:12 Loic Poulain
2020-12-02 8:48 ` Manivannan Sadhasivam
2020-12-02 9:01 ` Manivannan Sadhasivam
0 siblings, 2 replies; 3+ messages in thread
From: Loic Poulain @ 2020-12-02 8:12 UTC (permalink / raw)
To: manivannan.sadhasivam, hemantk; +Cc: linux-arm-msm, Loic Poulain
Fix the following warning with explicit cast:
warning: implicit conversion from 'unsigned long long' to
'dma_addr_t' (aka 'unsigned int')
mhi_cntrl->iova_stop = DMA_BIT_MASK(info->dma_data_width);
Fixes: 855a70c12021 ("bus: mhi: Add MHI PCI support for WWAN modems")
Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Reported-by: kernel test robot <lkp@intel.com>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
---
v2: Add fixes tag
drivers/bus/mhi/pci_generic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
index cfee0db..0912885 100644
--- a/drivers/bus/mhi/pci_generic.c
+++ b/drivers/bus/mhi/pci_generic.c
@@ -406,7 +406,7 @@ static int mhi_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
mhi_initialize_controller(mhi_cntrl);
mhi_cntrl->cntrl_dev = &pdev->dev;
mhi_cntrl->iova_start = 0;
- mhi_cntrl->iova_stop = DMA_BIT_MASK(info->dma_data_width);
+ mhi_cntrl->iova_stop = (dma_addr_t)DMA_BIT_MASK(info->dma_data_width);
mhi_cntrl->fw_image = info->fw;
mhi_cntrl->edl_image = info->edl;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mhi: pci_generic: Fix implicit conversion warning
2020-12-02 8:12 [PATCH v2] mhi: pci_generic: Fix implicit conversion warning Loic Poulain
@ 2020-12-02 8:48 ` Manivannan Sadhasivam
2020-12-02 9:01 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2020-12-02 8:48 UTC (permalink / raw)
To: Loic Poulain; +Cc: hemantk, linux-arm-msm
On Wed, Dec 02, 2020 at 09:12:30AM +0100, Loic Poulain wrote:
> Fix the following warning with explicit cast:
>
> warning: implicit conversion from 'unsigned long long' to
> 'dma_addr_t' (aka 'unsigned int')
> mhi_cntrl->iova_stop = DMA_BIT_MASK(info->dma_data_width);
>
> Fixes: 855a70c12021 ("bus: mhi: Add MHI PCI support for WWAN modems")
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> v2: Add fixes tag
>
> drivers/bus/mhi/pci_generic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
> index cfee0db..0912885 100644
> --- a/drivers/bus/mhi/pci_generic.c
> +++ b/drivers/bus/mhi/pci_generic.c
> @@ -406,7 +406,7 @@ static int mhi_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> mhi_initialize_controller(mhi_cntrl);
> mhi_cntrl->cntrl_dev = &pdev->dev;
> mhi_cntrl->iova_start = 0;
> - mhi_cntrl->iova_stop = DMA_BIT_MASK(info->dma_data_width);
> + mhi_cntrl->iova_stop = (dma_addr_t)DMA_BIT_MASK(info->dma_data_width);
> mhi_cntrl->fw_image = info->fw;
> mhi_cntrl->edl_image = info->edl;
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] mhi: pci_generic: Fix implicit conversion warning
2020-12-02 8:12 [PATCH v2] mhi: pci_generic: Fix implicit conversion warning Loic Poulain
2020-12-02 8:48 ` Manivannan Sadhasivam
@ 2020-12-02 9:01 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2020-12-02 9:01 UTC (permalink / raw)
To: Loic Poulain; +Cc: hemantk, linux-arm-msm
On Wed, Dec 02, 2020 at 09:12:30AM +0100, Loic Poulain wrote:
> Fix the following warning with explicit cast:
>
> warning: implicit conversion from 'unsigned long long' to
> 'dma_addr_t' (aka 'unsigned int')
> mhi_cntrl->iova_stop = DMA_BIT_MASK(info->dma_data_width);
>
> Fixes: 855a70c12021 ("bus: mhi: Add MHI PCI support for WWAN modems")
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Applied to mhi-next!
Thanks,
Mani
> ---
> v2: Add fixes tag
>
> drivers/bus/mhi/pci_generic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
> index cfee0db..0912885 100644
> --- a/drivers/bus/mhi/pci_generic.c
> +++ b/drivers/bus/mhi/pci_generic.c
> @@ -406,7 +406,7 @@ static int mhi_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> mhi_initialize_controller(mhi_cntrl);
> mhi_cntrl->cntrl_dev = &pdev->dev;
> mhi_cntrl->iova_start = 0;
> - mhi_cntrl->iova_stop = DMA_BIT_MASK(info->dma_data_width);
> + mhi_cntrl->iova_stop = (dma_addr_t)DMA_BIT_MASK(info->dma_data_width);
> mhi_cntrl->fw_image = info->fw;
> mhi_cntrl->edl_image = info->edl;
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-02 9:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-02 8:12 [PATCH v2] mhi: pci_generic: Fix implicit conversion warning Loic Poulain
2020-12-02 8:48 ` Manivannan Sadhasivam
2020-12-02 9:01 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox