From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
Cc: agross@kernel.org, p.zabel@pengutronix.de,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: firmware: qcom_scm: Simplify the calculation of variables
Date: Tue, 26 Jan 2021 08:07:14 -0600 [thread overview]
Message-ID: <20210126140714.GG1241218@yoga> (raw)
In-Reply-To: <1611651144-42491-1-git-send-email-abaci-bugfix@linux.alibaba.com>
On Tue 26 Jan 02:52 CST 2021, Jiapeng Zhong wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/firmware/qcom_scm.c:324:20-22: WARNING !A || A && B is
> equivalent to !A || B.
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
> ---
> drivers/firmware/qcom_scm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> index 7be48c1..c530072 100644
> --- a/drivers/firmware/qcom_scm.c
> +++ b/drivers/firmware/qcom_scm.c
> @@ -321,7 +321,7 @@ int qcom_scm_set_cold_boot_addr(void *entry, const cpumask_t *cpus)
> .owner = ARM_SMCCC_OWNER_SIP,
> };
>
> - if (!cpus || (cpus && cpumask_empty(cpus)))
> + if (!cpus || cpumask_empty(cpus))
> return -EINVAL;
>
> for_each_cpu(cpu, cpus) {
> --
> 1.8.3.1
>
prev parent reply other threads:[~2021-01-26 14:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 8:52 [PATCH] media: firmware: qcom_scm: Simplify the calculation of variables Jiapeng Zhong
2021-01-26 14:07 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210126140714.GG1241218@yoga \
--to=bjorn.andersson@linaro.org \
--cc=abaci-bugfix@linux.alibaba.com \
--cc=agross@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox