[PATCH] bus: mhi: Minor style and comment fixes

[PATCH] bus: mhi: Minor style and comment fixes

[Manivannan Sadhasivam]

This patch fixes the below checkpatch warnings in MHI bus:

WARNING: Possible repeated word: 'events'
+	/* Process ctrl events events */

WARNING: Missing a blank line after declarations
+			struct mhi_buf_info info = { };
+			buf = kmalloc(len, GFP_KERNEL);

WARNING: Move const after static - use 'static const struct mhi_pm_transitions'
+static struct mhi_pm_transitions const dev_state_transitions[] = {

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 drivers/bus/mhi/core/main.c | 3 ++-
 drivers/bus/mhi/core/pm.c   | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c
index b15c5bc37dd4..930aba666b67 100644
--- a/drivers/bus/mhi/core/main.c
+++ b/drivers/bus/mhi/core/main.c
@@ -1065,7 +1065,7 @@ void mhi_ctrl_ev_task(unsigned long data)
 		return;
 	}
 
-	/* Process ctrl events events */
+	/* Process ctrl events */
 	ret = mhi_event->process_event(mhi_cntrl, mhi_event, U32_MAX);
 
 	/*
@@ -1464,6 +1464,7 @@ int mhi_prepare_channel(struct mhi_controller *mhi_cntrl,
 		while (nr_el--) {
 			void *buf;
 			struct mhi_buf_info info = { };
+
 			buf = kmalloc(len, GFP_KERNEL);
 			if (!buf) {
 				ret = -ENOMEM;
diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c
index 0bb8d77515e3..7464f5d09973 100644
--- a/drivers/bus/mhi/core/pm.c
+++ b/drivers/bus/mhi/core/pm.c
@@ -42,7 +42,7 @@
  * L3: LD_ERR_FATAL_DETECT <--> LD_ERR_FATAL_DETECT
  *     LD_ERR_FATAL_DETECT -> DISABLE
  */
-static struct mhi_pm_transitions const dev_state_transitions[] = {
+static const struct mhi_pm_transitions dev_state_transitions[] = {
 	/* L0 States */
 	{
 		MHI_PM_DISABLE,
-- 
2.25.1

Re: [PATCH] bus: mhi: Minor style and comment fixes

[Manivannan Sadhasivam]

On Fri, Nov 26, 2021 at 08:44:03AM +0530, Manivannan Sadhasivam wrote:
> This patch fixes the below checkpatch warnings in MHI bus:
> 
> WARNING: Possible repeated word: 'events'
> +	/* Process ctrl events events */
> 
> WARNING: Missing a blank line after declarations
> +			struct mhi_buf_info info = { };
> +			buf = kmalloc(len, GFP_KERNEL);
> 
> WARNING: Move const after static - use 'static const struct mhi_pm_transitions'
> +static struct mhi_pm_transitions const dev_state_transitions[] = {
> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Applied to mhi-next!

Thanks,
Mani

> ---
>  drivers/bus/mhi/core/main.c | 3 ++-
>  drivers/bus/mhi/core/pm.c   | 2 +-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c
> index b15c5bc37dd4..930aba666b67 100644
> --- a/drivers/bus/mhi/core/main.c
> +++ b/drivers/bus/mhi/core/main.c
> @@ -1065,7 +1065,7 @@ void mhi_ctrl_ev_task(unsigned long data)
>  		return;
>  	}
>  
> -	/* Process ctrl events events */
> +	/* Process ctrl events */
>  	ret = mhi_event->process_event(mhi_cntrl, mhi_event, U32_MAX);
>  
>  	/*
> @@ -1464,6 +1464,7 @@ int mhi_prepare_channel(struct mhi_controller *mhi_cntrl,
>  		while (nr_el--) {
>  			void *buf;
>  			struct mhi_buf_info info = { };
> +
>  			buf = kmalloc(len, GFP_KERNEL);
>  			if (!buf) {
>  				ret = -ENOMEM;
> diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c
> index 0bb8d77515e3..7464f5d09973 100644
> --- a/drivers/bus/mhi/core/pm.c
> +++ b/drivers/bus/mhi/core/pm.c
> @@ -42,7 +42,7 @@
>   * L3: LD_ERR_FATAL_DETECT <--> LD_ERR_FATAL_DETECT
>   *     LD_ERR_FATAL_DETECT -> DISABLE
>   */
> -static struct mhi_pm_transitions const dev_state_transitions[] = {
> +static const struct mhi_pm_transitions dev_state_transitions[] = {
>  	/* L0 States */
>  	{
>  		MHI_PM_DISABLE,
> -- 
> 2.25.1
>