* [PATCH -next 1/2] cpuidle: Fix kernel-doc
@ 2021-12-10 4:28 Yang Li
2021-12-17 15:24 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2021-12-10 4:28 UTC (permalink / raw)
To: rafael, agross, bjorn.andersson, daniel.lezcano
Cc: linux-arm-msm, linux-pm, linux-kernel, Yang Li, Abaci Robot
Fix function name in sysfs.c kernel-doc comment
to remove a warning found by running scripts/kernel-doc,
which is caused by using 'make W=1'.
drivers/cpuidle/sysfs.c:512: warning: expecting prototype for
cpuidle_remove_driver_sysfs(). Prototype was for
cpuidle_remove_state_sysfs() instead
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/cpuidle/sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpuidle/sysfs.c b/drivers/cpuidle/sysfs.c
index 469e18547d06..e708e593db88 100644
--- a/drivers/cpuidle/sysfs.c
+++ b/drivers/cpuidle/sysfs.c
@@ -505,7 +505,7 @@ static int cpuidle_add_state_sysfs(struct cpuidle_device *device)
}
/**
- * cpuidle_remove_driver_sysfs - removes the cpuidle states sysfs attributes
+ * cpuidle_remove_state_sysfs - removes the cpuidle states sysfs attributes
* @device: the target device
*/
static void cpuidle_remove_state_sysfs(struct cpuidle_device *device)
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next 1/2] cpuidle: Fix kernel-doc
2021-12-10 4:28 [PATCH -next 1/2] cpuidle: Fix kernel-doc Yang Li
@ 2021-12-17 15:24 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2021-12-17 15:24 UTC (permalink / raw)
To: Yang Li
Cc: Rafael J. Wysocki, Andy Gross, Bjorn Andersson, Daniel Lezcano,
linux-arm-msm, Linux PM, Linux Kernel Mailing List, Abaci Robot
On Fri, Dec 10, 2021 at 5:29 AM Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> Fix function name in sysfs.c kernel-doc comment
> to remove a warning found by running scripts/kernel-doc,
> which is caused by using 'make W=1'.
>
> drivers/cpuidle/sysfs.c:512: warning: expecting prototype for
> cpuidle_remove_driver_sysfs(). Prototype was for
> cpuidle_remove_state_sysfs() instead
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/cpuidle/sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpuidle/sysfs.c b/drivers/cpuidle/sysfs.c
> index 469e18547d06..e708e593db88 100644
> --- a/drivers/cpuidle/sysfs.c
> +++ b/drivers/cpuidle/sysfs.c
> @@ -505,7 +505,7 @@ static int cpuidle_add_state_sysfs(struct cpuidle_device *device)
> }
>
> /**
> - * cpuidle_remove_driver_sysfs - removes the cpuidle states sysfs attributes
> + * cpuidle_remove_state_sysfs - removes the cpuidle states sysfs attributes
> * @device: the target device
> */
> static void cpuidle_remove_state_sysfs(struct cpuidle_device *device)
> --
Applied as 5.17 under a more precise subject ("cpuidle: Fix
cpuidle_remove_state_sysfs() kerneldoc comment").
When you submit changes like this in the future, please always make
the subject precise enough to allow the given change to be easily
distinguished from other changes in the same category.
Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-17 15:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-10 4:28 [PATCH -next 1/2] cpuidle: Fix kernel-doc Yang Li
2021-12-17 15:24 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox