* [PATCH] arm64: dts: qcom: sc8280xp: remove duplicate apps_smmu irq
@ 2022-07-12 7:58 Parikshit Pareek
2022-07-12 11:59 ` Andrew Halaney
2022-07-12 12:10 ` Manivannan Sadhasivam
0 siblings, 2 replies; 3+ messages in thread
From: Parikshit Pareek @ 2022-07-12 7:58 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson
Cc: Sai Prakash Ranjan, Rajendra Nayak, Prasanna Kumar, linux-arm-msm,
Parikshit Pareek
Remove the duplicate irq number 424, from apps_smmu node. This is needed
to correct the interrupt mapping for context banks.
Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com>
---
arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
index 7945cbb57bb4..9583cc53aa03 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
@@ -1580,7 +1580,6 @@
<GIC_SPI 412 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 421 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 706 IRQ_TYPE_LEVEL_HIGH>,
- <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH>,
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: qcom: sc8280xp: remove duplicate apps_smmu irq
2022-07-12 7:58 [PATCH] arm64: dts: qcom: sc8280xp: remove duplicate apps_smmu irq Parikshit Pareek
@ 2022-07-12 11:59 ` Andrew Halaney
2022-07-12 12:10 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Halaney @ 2022-07-12 11:59 UTC (permalink / raw)
To: Parikshit Pareek
Cc: Andy Gross, Bjorn Andersson, Sai Prakash Ranjan, Rajendra Nayak,
Prasanna Kumar, linux-arm-msm
On Tue, Jul 12, 2022 at 01:28:59PM +0530, Parikshit Pareek wrote:
> Remove the duplicate irq number 424, from apps_smmu node. This is needed
> to correct the interrupt mapping for context banks.
>
> Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
> Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index 7945cbb57bb4..9583cc53aa03 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -1580,7 +1580,6 @@
> <GIC_SPI 412 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 421 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 706 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH>,
> --
> 2.17.1
>
Looks good to me, thanks!
Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: qcom: sc8280xp: remove duplicate apps_smmu irq
2022-07-12 7:58 [PATCH] arm64: dts: qcom: sc8280xp: remove duplicate apps_smmu irq Parikshit Pareek
2022-07-12 11:59 ` Andrew Halaney
@ 2022-07-12 12:10 ` Manivannan Sadhasivam
1 sibling, 0 replies; 3+ messages in thread
From: Manivannan Sadhasivam @ 2022-07-12 12:10 UTC (permalink / raw)
To: Parikshit Pareek
Cc: Andy Gross, Bjorn Andersson, Sai Prakash Ranjan, Rajendra Nayak,
Prasanna Kumar, linux-arm-msm
On Tue, Jul 12, 2022 at 01:28:59PM +0530, Parikshit Pareek wrote:
> Remove the duplicate irq number 424, from apps_smmu node. This is needed
> to correct the interrupt mapping for context banks.
>
> Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
> Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index 7945cbb57bb4..9583cc53aa03 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -1580,7 +1580,6 @@
> <GIC_SPI 412 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 421 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 706 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>,
While the change is correct, the IRQs are not sorted and that's what
encouraging these kind of dups.
Please sort them too.
Thanks,
Mani
> <GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH>,
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-12 12:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-12 7:58 [PATCH] arm64: dts: qcom: sc8280xp: remove duplicate apps_smmu irq Parikshit Pareek
2022-07-12 11:59 ` Andrew Halaney
2022-07-12 12:10 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox