* [PATCH v2] mailbox: qcom-ipcc: flag IRQ NO_THREAD
@ 2022-10-06 19:28 Eric Chanudet
0 siblings, 0 replies; only message in thread
From: Eric Chanudet @ 2022-10-06 19:28 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Manivannan Sadhasivam,
Jassi Brar, Sebastian Andrzej Siewior
Cc: linux-arm-msm, linux-rt-users, linux-kernel, Eric Chanudet
PREEMPT_RT forces qcom-ipcc's handler to be threaded with interrupts
enabled, which triggers a warning in __handle_irq_event_percpu():
irq 173 handler irq_default_primary_handler+0x0/0x10 enabled interrupts
WARNING: CPU: 0 PID: 77 at kernel/irq/handle.c:161 __handle_irq_event_percpu+0x4c4/0x4d0
Mark it IRQF_NO_THREAD. This is an IRQ-multiplexer and as such it should
not be threaded, otherwise its child-interrupts would be invoked from
the thread handler which is not desired.
This is noticed by PREEMPT_RT, but also on a non-PREEMPT_RT kernel where
`threadirqs' has been used.
Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Eric Chanudet <echanude@redhat.com>
---
Changes since v1:
- Reformulate the patch description using Sebastian's response.
v1 can be found at
https://lore.kernel.org/linux-arm-msm/20221003170849.383005-1-echanude@redhat.com/
drivers/mailbox/qcom-ipcc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mailbox/qcom-ipcc.c b/drivers/mailbox/qcom-ipcc.c
index 31d58b7d55fe..7e27acf6c0cc 100644
--- a/drivers/mailbox/qcom-ipcc.c
+++ b/drivers/mailbox/qcom-ipcc.c
@@ -308,7 +308,8 @@ static int qcom_ipcc_probe(struct platform_device *pdev)
goto err_mbox;
ret = devm_request_irq(&pdev->dev, ipcc->irq, qcom_ipcc_irq_fn,
- IRQF_TRIGGER_HIGH | IRQF_NO_SUSPEND, name, ipcc);
+ IRQF_TRIGGER_HIGH | IRQF_NO_SUSPEND |
+ IRQF_NO_THREAD, name, ipcc);
if (ret < 0) {
dev_err(&pdev->dev, "Failed to register the irq: %d\n", ret);
goto err_req_irq;
--
2.37.3
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-10-06 19:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-06 19:28 [PATCH v2] mailbox: qcom-ipcc: flag IRQ NO_THREAD Eric Chanudet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox