* [PATCH 2/3] dt-bindings: clocks: qcom,gcc-ipq8074: allow XO and sleep clocks
[not found] <20221030175703.1103224-1-robimarko@gmail.com>
@ 2022-10-30 17:57 ` Robert Marko
2022-11-02 13:47 ` Rob Herring
2022-10-30 17:57 ` [PATCH 3/3] arm64: dts: qcom: ipq8074: pass XO and sleep clocks to GCC Robert Marko
2022-11-08 1:27 ` (subset) [PATCH 1/3] clk: qcom: ipq8074: convert to parent data Bjorn Andersson
2 siblings, 1 reply; 4+ messages in thread
From: Robert Marko @ 2022-10-30 17:57 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, mturquette, sboyd, robh+dt,
krzysztof.kozlowski+dt, tdas, linux-arm-msm, linux-clk,
devicetree, linux-kernel
Cc: Robert Marko
Allow passing XO and sleep clocks to the IPQ8074 to avoid having to do
a global matching by name.
Signed-off-by: Robert Marko <robimarko@gmail.com>
---
.../devicetree/bindings/clock/qcom,gcc-ipq8074.yaml | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-ipq8074.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-ipq8074.yaml
index ac6711ed01ba..a190523a8c25 100644
--- a/Documentation/devicetree/bindings/clock/qcom,gcc-ipq8074.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,gcc-ipq8074.yaml
@@ -24,6 +24,16 @@ properties:
compatible:
const: qcom,gcc-ipq8074
+ clocks:
+ items:
+ - description: board XO clock
+ - description: sleep clock
+
+ clock-names:
+ items:
+ - const: xo
+ - const: sleep_clk
+
required:
- compatible
--
2.38.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/3] dt-bindings: clocks: qcom,gcc-ipq8074: allow XO and sleep clocks
2022-10-30 17:57 ` [PATCH 2/3] dt-bindings: clocks: qcom,gcc-ipq8074: allow XO and sleep clocks Robert Marko
@ 2022-11-02 13:47 ` Rob Herring
0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2022-11-02 13:47 UTC (permalink / raw)
To: Robert Marko
Cc: linux-clk, robh+dt, krzysztof.kozlowski+dt, linux-arm-msm,
linux-kernel, andersson, sboyd, devicetree, konrad.dybcio, tdas,
agross, mturquette
On Sun, 30 Oct 2022 18:57:02 +0100, Robert Marko wrote:
> Allow passing XO and sleep clocks to the IPQ8074 to avoid having to do
> a global matching by name.
>
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
> .../devicetree/bindings/clock/qcom,gcc-ipq8074.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 3/3] arm64: dts: qcom: ipq8074: pass XO and sleep clocks to GCC
[not found] <20221030175703.1103224-1-robimarko@gmail.com>
2022-10-30 17:57 ` [PATCH 2/3] dt-bindings: clocks: qcom,gcc-ipq8074: allow XO and sleep clocks Robert Marko
@ 2022-10-30 17:57 ` Robert Marko
2022-11-08 1:27 ` (subset) [PATCH 1/3] clk: qcom: ipq8074: convert to parent data Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Robert Marko @ 2022-10-30 17:57 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, mturquette, sboyd, robh+dt,
krzysztof.kozlowski+dt, tdas, linux-arm-msm, linux-clk,
devicetree, linux-kernel
Cc: Robert Marko
Pass XO and sleep clocks to the GCC controller so it does not have to
find them by matching globaly by name.
If not passed directly, driver maintains backwards compatibility by then
falling back to global lookup.
Since we are here, set cell numbers in decimal instead of hex.
Signed-off-by: Robert Marko <robimarko@gmail.com>
---
arch/arm64/boot/dts/qcom/ipq8074.dtsi | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
index dcea8ec6a160..4b99357a02e8 100644
--- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
@@ -438,9 +438,11 @@ qpic_pins: qpic-pins {
gcc: gcc@1800000 {
compatible = "qcom,gcc-ipq8074";
reg = <0x01800000 0x80000>;
- #clock-cells = <0x1>;
+ clocks = <&xo>, <&sleep_clk>;
+ clock-names = "xo", "sleep_clk";
+ #clock-cells = <1>;
#power-domain-cells = <1>;
- #reset-cells = <0x1>;
+ #reset-cells = <1>;
};
tcsr_mutex: hwlock@1905000 {
--
2.38.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: (subset) [PATCH 1/3] clk: qcom: ipq8074: convert to parent data
[not found] <20221030175703.1103224-1-robimarko@gmail.com>
2022-10-30 17:57 ` [PATCH 2/3] dt-bindings: clocks: qcom,gcc-ipq8074: allow XO and sleep clocks Robert Marko
2022-10-30 17:57 ` [PATCH 3/3] arm64: dts: qcom: ipq8074: pass XO and sleep clocks to GCC Robert Marko
@ 2022-11-08 1:27 ` Bjorn Andersson
2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2022-11-08 1:27 UTC (permalink / raw)
To: robimarko, mturquette, devicetree, robh+dt, sboyd, tdas,
linux-clk, krzysztof.kozlowski+dt, agross, konrad.dybcio,
linux-kernel, linux-arm-msm
On Sun, 30 Oct 2022 18:57:01 +0100, Robert Marko wrote:
> Convert the IPQ8074 GCC driver to use parent data instead of global
> name matching.
>
> Utilize ARRAY_SIZE for num_parents instead of hardcoding the value.
>
>
Applied, thanks!
[3/3] arm64: dts: qcom: ipq8074: pass XO and sleep clocks to GCC
commit: 3aa0b8cd957b3e7806004c2150c61c85a606821a
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread