From: Javier Martinez Canillas <javierm@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Brian Masney <bmasney@redhat.com>,
Bjorn Andersson <andersson@kernel.org>,
Douglas Anderson <dianders@chromium.org>,
John Stultz <jstultz@google.com>,
Peter Robinson <pbrobinson@redhat.com>,
Enric Balletbo i Serra <eballetbo@redhat.com>,
Steev Klimaszewski <steev@kali.org>,
Rob Herring <robh@kernel.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
linux-arm-msm@vger.kernel.org,
Saravana Kannan <saravanak@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Javier Martinez Canillas <javierm@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: [PATCH v2 1/4] driver core: Make driver_deferred_probe_timeout a static variable
Date: Wed, 16 Nov 2022 12:53:45 +0100 [thread overview]
Message-ID: <20221116115348.517599-2-javierm@redhat.com> (raw)
In-Reply-To: <20221116115348.517599-1-javierm@redhat.com>
It is not used outside of its compilation unit, so there's no need to
export this variable.
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---
(no changes since v1)
drivers/base/dd.c | 6 ++----
include/linux/device/driver.h | 1 -
2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/base/dd.c b/drivers/base/dd.c
index 3dda62503102..040b4060f903 100644
--- a/drivers/base/dd.c
+++ b/drivers/base/dd.c
@@ -257,13 +257,11 @@ static int deferred_devs_show(struct seq_file *s, void *data)
DEFINE_SHOW_ATTRIBUTE(deferred_devs);
#ifdef CONFIG_MODULES
-int driver_deferred_probe_timeout = 10;
+static int driver_deferred_probe_timeout = 10;
#else
-int driver_deferred_probe_timeout;
+static int driver_deferred_probe_timeout;
#endif
-EXPORT_SYMBOL_GPL(driver_deferred_probe_timeout);
-
static int __init deferred_probe_timeout_setup(char *str)
{
int timeout;
diff --git a/include/linux/device/driver.h b/include/linux/device/driver.h
index 2114d65b862f..50d0a416a5e7 100644
--- a/include/linux/device/driver.h
+++ b/include/linux/device/driver.h
@@ -240,7 +240,6 @@ driver_find_device_by_acpi_dev(struct device_driver *drv, const void *adev)
}
#endif
-extern int driver_deferred_probe_timeout;
void driver_deferred_probe_add(struct device *dev);
int driver_deferred_probe_check_state(struct device *dev);
void driver_init(void);
--
2.38.1
next prev parent reply other threads:[~2022-11-16 12:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 11:53 [PATCH v2 0/4] driver core: Decouple device links enforcing and probe deferral timeouts Javier Martinez Canillas
2022-11-16 11:53 ` Javier Martinez Canillas [this message]
2022-11-16 12:57 ` [PATCH v2 1/4] driver core: Make driver_deferred_probe_timeout a static variable Andrew Halaney
2022-11-17 19:14 ` John Stultz
2022-12-12 8:50 ` Javier Martinez Canillas
2022-12-12 8:59 ` Greg Kroah-Hartman
2022-12-12 9:06 ` Javier Martinez Canillas
2022-11-16 12:00 ` [PATCH v2 2/4] driver core: Set deferred probe timeout to 0 if modules are disabled Javier Martinez Canillas
2022-11-16 16:39 ` Andrew Halaney
2022-11-16 16:51 ` Javier Martinez Canillas
2022-11-16 12:01 ` [PATCH v2 3/4] driver core: Add fw_devlink.timeout param to stop waiting for devlinks Javier Martinez Canillas
2022-11-16 16:09 ` Randy Dunlap
2022-11-16 19:05 ` Andrew Halaney
2022-11-17 15:19 ` Andrew Halaney
2022-11-17 18:55 ` Javier Martinez Canillas
2022-11-17 19:07 ` John Stultz
2022-11-17 19:16 ` Javier Martinez Canillas
2022-11-16 12:02 ` [PATCH v2 4/4] driver core: Disable driver deferred probe timeout by default Javier Martinez Canillas
2022-11-16 19:15 ` Andrew Halaney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221116115348.517599-2-javierm@redhat.com \
--to=javierm@redhat.com \
--cc=andersson@kernel.org \
--cc=ast@kernel.org \
--cc=bmasney@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dianders@chromium.org \
--cc=eballetbo@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jstultz@google.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbrobinson@redhat.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
--cc=steev@kali.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox