* [PATCH linux-next] soc: qcom: smem_state: Use device_match_of_node()
@ 2022-11-17 7:48 ye.xingchen
2022-12-05 22:01 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: ye.xingchen @ 2022-11-17 7:48 UTC (permalink / raw)
To: agross; +Cc: andersson, konrad.dybcio, linux-arm-msm, linux-kernel
From: ye xingchen <ye.xingchen@zte.com.cn>
Replace the open-code with device_match_of_node().
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
drivers/soc/qcom/smem_state.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/qcom/smem_state.c b/drivers/soc/qcom/smem_state.c
index e848cc9a3cf8..a7844841a727 100644
--- a/drivers/soc/qcom/smem_state.c
+++ b/drivers/soc/qcom/smem_state.c
@@ -63,7 +63,7 @@ static struct qcom_smem_state *of_node_to_state(struct device_node *np)
mutex_lock(&list_lock);
list_for_each_entry(state, &smem_states, list) {
- if (state->of_node == np) {
+ if (device_match_of_node(state, np)) {
kref_get(&state->refcount);
goto unlock;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH linux-next] soc: qcom: smem_state: Use device_match_of_node()
2022-11-17 7:48 [PATCH linux-next] soc: qcom: smem_state: Use device_match_of_node() ye.xingchen
@ 2022-12-05 22:01 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2022-12-05 22:01 UTC (permalink / raw)
To: ye.xingchen; +Cc: agross, konrad.dybcio, linux-arm-msm, linux-kernel
On Thu, Nov 17, 2022 at 03:48:06PM +0800, ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Replace the open-code with device_match_of_node().
>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
> drivers/soc/qcom/smem_state.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/smem_state.c b/drivers/soc/qcom/smem_state.c
> index e848cc9a3cf8..a7844841a727 100644
> --- a/drivers/soc/qcom/smem_state.c
> +++ b/drivers/soc/qcom/smem_state.c
> @@ -63,7 +63,7 @@ static struct qcom_smem_state *of_node_to_state(struct device_node *np)
> mutex_lock(&list_lock);
>
> list_for_each_entry(state, &smem_states, list) {
> - if (state->of_node == np) {
> + if (device_match_of_node(state, np)) {
I don't find this form easier to read, nor is state a struct device *...
Regards,
Bjorn
> kref_get(&state->refcount);
> goto unlock;
> }
> --
> 2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-05 22:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-17 7:48 [PATCH linux-next] soc: qcom: smem_state: Use device_match_of_node() ye.xingchen
2022-12-05 22:01 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox