* [PATCH] drm/msm/mdp5: set varaiable msm8x76_config storage-class-specifier to static
@ 2023-04-04 18:53 Tom Rix
2023-04-04 21:49 ` Dmitry Baryshkov
2023-04-05 1:35 ` Dmitry Baryshkov
0 siblings, 2 replies; 3+ messages in thread
From: Tom Rix @ 2023-04-04 18:53 UTC (permalink / raw)
To: robdclark, quic_abhinavk, dmitry.baryshkov, sean, airlied, daniel,
vladimir.lypak
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, Tom Rix
smatch reports
drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c:658:26: warning: symbol
'msm8x76_config' was not declared. Should it be static?
This variable is only used in one file so should be static.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c
index 1f1555aa02d2..2eec2d78f32a 100644
--- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c
+++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c
@@ -655,7 +655,7 @@ static const struct mdp5_cfg_hw msm8x96_config = {
.max_clk = 412500000,
};
-const struct mdp5_cfg_hw msm8x76_config = {
+static const struct mdp5_cfg_hw msm8x76_config = {
.name = "msm8x76",
.mdp = {
.count = 1,
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/msm/mdp5: set varaiable msm8x76_config storage-class-specifier to static
2023-04-04 18:53 [PATCH] drm/msm/mdp5: set varaiable msm8x76_config storage-class-specifier to static Tom Rix
@ 2023-04-04 21:49 ` Dmitry Baryshkov
2023-04-05 1:35 ` Dmitry Baryshkov
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2023-04-04 21:49 UTC (permalink / raw)
To: Tom Rix, robdclark, quic_abhinavk, sean, airlied, daniel,
vladimir.lypak
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel
On 04/04/2023 21:53, Tom Rix wrote:
> smatch reports
> drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c:658:26: warning: symbol
> 'msm8x76_config' was not declared. Should it be static?
>
> This variable is only used in one file so should be static.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/msm/mdp5: set varaiable msm8x76_config storage-class-specifier to static
2023-04-04 18:53 [PATCH] drm/msm/mdp5: set varaiable msm8x76_config storage-class-specifier to static Tom Rix
2023-04-04 21:49 ` Dmitry Baryshkov
@ 2023-04-05 1:35 ` Dmitry Baryshkov
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2023-04-05 1:35 UTC (permalink / raw)
To: robdclark, quic_abhinavk, sean, airlied, daniel, vladimir.lypak,
Tom Rix
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel
On Tue, 04 Apr 2023 14:53:29 -0400, Tom Rix wrote:
> smatch reports
> drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c:658:26: warning: symbol
> 'msm8x76_config' was not declared. Should it be static?
>
> This variable is only used in one file so should be static.
>
>
> [...]
Applied, thanks!
[1/1] drm/msm/mdp5: set varaiable msm8x76_config storage-class-specifier to static
https://gitlab.freedesktop.org/lumag/msm/-/commit/d2f762745162
Best regards,
--
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-05 1:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-04 18:53 [PATCH] drm/msm/mdp5: set varaiable msm8x76_config storage-class-specifier to static Tom Rix
2023-04-04 21:49 ` Dmitry Baryshkov
2023-04-05 1:35 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox