* [PATCH] arm64: dts: qcom: ipq8074: Add QUP5 SPI node
@ 2023-04-26 18:56 Robert Marko
2023-05-01 10:02 ` Krzysztof Kozlowski
2023-05-25 4:54 ` Bjorn Andersson
0 siblings, 2 replies; 4+ messages in thread
From: Robert Marko @ 2023-04-26 18:56 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
linux-arm-msm, devicetree, linux-kernel
Cc: Robert Marko
Add node to support the QUP5 SPI controller inside of IPQ8074.
Some devices use this bus in order to manage external switches.
Signed-off-by: Robert Marko <robimarko@gmail.com>
---
arch/arm64/boot/dts/qcom/ipq8074.dtsi | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
index 64c2a30d9c25..4a682e3442f8 100644
--- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
@@ -774,6 +774,20 @@ blsp1_i2c5: i2c@78b9000 {
status = "disabled";
};
+ blsp1_spi5: spi@78b9000 {
+ compatible = "qcom,spi-qup-v2.2.1";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0x78b9000 0x600>;
+ interrupts = <GIC_SPI 299 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&gcc GCC_BLSP1_QUP5_SPI_APPS_CLK>,
+ <&gcc GCC_BLSP1_AHB_CLK>;
+ clock-names = "core", "iface";
+ dmas = <&blsp_dma 20>, <&blsp_dma 21>;
+ dma-names = "tx", "rx";
+ status = "disabled";
+ };
+
blsp1_i2c6: i2c@78ba000 {
compatible = "qcom,i2c-qup-v2.2.1";
#address-cells = <1>;
--
2.40.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: ipq8074: Add QUP5 SPI node
2023-04-26 18:56 [PATCH] arm64: dts: qcom: ipq8074: Add QUP5 SPI node Robert Marko
@ 2023-05-01 10:02 ` Krzysztof Kozlowski
2023-05-03 19:56 ` Robert Marko
2023-05-25 4:54 ` Bjorn Andersson
1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-01 10:02 UTC (permalink / raw)
To: Robert Marko, agross, andersson, konrad.dybcio, robh+dt,
krzysztof.kozlowski+dt, linux-arm-msm, devicetree, linux-kernel
On 26/04/2023 20:56, Robert Marko wrote:
> Add node to support the QUP5 SPI controller inside of IPQ8074.
> Some devices use this bus in order to manage external switches.
>
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---
> arch/arm64/boot/dts/qcom/ipq8074.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> index 64c2a30d9c25..4a682e3442f8 100644
> --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> @@ -774,6 +774,20 @@ blsp1_i2c5: i2c@78b9000 {
> status = "disabled";
> };
>
> + blsp1_spi5: spi@78b9000 {
> + compatible = "qcom,spi-qup-v2.2.1";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x78b9000 0x600>;
reg is always after compatible.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: ipq8074: Add QUP5 SPI node
2023-05-01 10:02 ` Krzysztof Kozlowski
@ 2023-05-03 19:56 ` Robert Marko
0 siblings, 0 replies; 4+ messages in thread
From: Robert Marko @ 2023-05-03 19:56 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: agross, andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt,
linux-arm-msm, devicetree, linux-kernel
On Mon, 1 May 2023 at 12:03, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 26/04/2023 20:56, Robert Marko wrote:
> > Add node to support the QUP5 SPI controller inside of IPQ8074.
> > Some devices use this bus in order to manage external switches.
> >
> > Signed-off-by: Robert Marko <robimarko@gmail.com>
> > ---
> > arch/arm64/boot/dts/qcom/ipq8074.dtsi | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> > index 64c2a30d9c25..4a682e3442f8 100644
> > --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> > @@ -774,6 +774,20 @@ blsp1_i2c5: i2c@78b9000 {
> > status = "disabled";
> > };
> >
> > + blsp1_spi5: spi@78b9000 {
> > + compatible = "qcom,spi-qup-v2.2.1";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + reg = <0x78b9000 0x600>;
>
> reg is always after compatible.
I agree usually, but here its just matching the same pattern like
other BLSP nodes.
Regards,
Robert
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: ipq8074: Add QUP5 SPI node
2023-04-26 18:56 [PATCH] arm64: dts: qcom: ipq8074: Add QUP5 SPI node Robert Marko
2023-05-01 10:02 ` Krzysztof Kozlowski
@ 2023-05-25 4:54 ` Bjorn Andersson
1 sibling, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2023-05-25 4:54 UTC (permalink / raw)
To: linux-kernel, agross, linux-arm-msm, devicetree, Robert Marko,
robh+dt, krzysztof.kozlowski+dt, konrad.dybcio
On Wed, 26 Apr 2023 20:56:47 +0200, Robert Marko wrote:
> Add node to support the QUP5 SPI controller inside of IPQ8074.
> Some devices use this bus in order to manage external switches.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: ipq8074: Add QUP5 SPI node
commit: cb0c14dae63fae037db41174fc95a59dea0ecf77
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-25 4:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-26 18:56 [PATCH] arm64: dts: qcom: ipq8074: Add QUP5 SPI node Robert Marko
2023-05-01 10:02 ` Krzysztof Kozlowski
2023-05-03 19:56 ` Robert Marko
2023-05-25 4:54 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox