Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch, airlied@gmail.com,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	javierm@redhat.com, sam@ravnborg.org
Cc: dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,
	intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
	linux-tegra@vger.kernel.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Russell King <linux@armlinux.org.uk>
Subject: [PATCH v4 03/13] drm/armada: Use regular fbdev I/O helpers
Date: Wed, 24 May 2023 11:21:40 +0200	[thread overview]
Message-ID: <20230524092150.11776-4-tzimmermann@suse.de> (raw)
In-Reply-To: <20230524092150.11776-1-tzimmermann@suse.de>

Use the regular fbdev helpers for framebuffer I/O instead of DRM's
helpers. Armada does not use damage handling, so DRM's fbdev helpers
are mere wrappers around the fbdev code.

By using fbdev helpers directly within each DRM fbdev emulation,
we can eventually remove DRM's wrapper functions entirely.

v4:
	* use initializer macros for struct fb_ops
v2:
	* use FB_IO_HELPERS option

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Russell King <linux@armlinux.org.uk>
---
 drivers/gpu/drm/armada/Kconfig        | 1 +
 drivers/gpu/drm/armada/armada_fbdev.c | 7 ++-----
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/armada/Kconfig b/drivers/gpu/drm/armada/Kconfig
index f5c66d89ba99..5afade25e217 100644
--- a/drivers/gpu/drm/armada/Kconfig
+++ b/drivers/gpu/drm/armada/Kconfig
@@ -3,6 +3,7 @@ config DRM_ARMADA
 	tristate "DRM support for Marvell Armada SoCs"
 	depends on DRM && HAVE_CLK && ARM && MMU
 	select DRM_KMS_HELPER
+	select FB_IO_HELPERS if DRM_FBDEV_EMULATION
 	help
 	  Support the "LCD" controllers found on the Marvell Armada 510
 	  devices.  There are two controllers on the device, each controller
diff --git a/drivers/gpu/drm/armada/armada_fbdev.c b/drivers/gpu/drm/armada/armada_fbdev.c
index 0a5fd1aa86eb..3943e89cc06c 100644
--- a/drivers/gpu/drm/armada/armada_fbdev.c
+++ b/drivers/gpu/drm/armada/armada_fbdev.c
@@ -5,6 +5,7 @@
  */
 
 #include <linux/errno.h>
+#include <linux/fb.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
 
@@ -33,12 +34,8 @@ static void armada_fbdev_fb_destroy(struct fb_info *info)
 
 static const struct fb_ops armada_fb_ops = {
 	.owner		= THIS_MODULE,
+	FB_DEFAULT_IO_OPS,
 	DRM_FB_HELPER_DEFAULT_OPS,
-	.fb_read	= drm_fb_helper_cfb_read,
-	.fb_write	= drm_fb_helper_cfb_write,
-	.fb_fillrect	= drm_fb_helper_cfb_fillrect,
-	.fb_copyarea	= drm_fb_helper_cfb_copyarea,
-	.fb_imageblit	= drm_fb_helper_cfb_imageblit,
 	.fb_destroy	= armada_fbdev_fb_destroy,
 };
 
-- 
2.40.1


  parent reply	other threads:[~2023-05-24  9:22 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-24  9:21 [PATCH v4 00/13] drm/fbdev: Remove DRM's helpers for fbdev I/O Thomas Zimmermann
2023-05-24  9:21 ` [PATCH v4 01/13] fbdev: Add Kconfig options to select different fb_ops helpers Thomas Zimmermann
2023-05-24 20:46   ` [v4,01/13] " Sui Jingfeng
2023-05-29 19:17   ` [PATCH v4 01/13] " Sam Ravnborg
2023-05-24  9:21 ` [PATCH v4 02/13] fbdev: Add initializer macros for struct fb_ops Thomas Zimmermann
2023-05-24 20:57   ` [v4,02/13] " Sui Jingfeng
2023-05-26 12:38     ` Thomas Zimmermann
2023-05-29 19:23   ` [PATCH v4 02/13] " Sam Ravnborg
2023-05-24  9:21 ` Thomas Zimmermann [this message]
2023-05-29 19:24   ` [PATCH v4 03/13] drm/armada: Use regular fbdev I/O helpers Sam Ravnborg
2023-05-24  9:21 ` [PATCH v4 04/13] drm/exynos: " Thomas Zimmermann
2023-05-24  9:21 ` [PATCH v4 05/13] drm/gma500: " Thomas Zimmermann
2023-05-24  9:21 ` [PATCH v4 06/13] drm/radeon: " Thomas Zimmermann
2023-05-24  9:21 ` [PATCH v4 07/13] drm/fbdev-dma: " Thomas Zimmermann
2023-05-24  9:21 ` [PATCH v4 08/13] drm/msm: " Thomas Zimmermann
2023-05-24  9:21 ` [PATCH v4 09/13] drm/omapdrm: " Thomas Zimmermann
2023-05-24  9:21 ` [PATCH v4 10/13] drm/tegra: " Thomas Zimmermann
2023-05-24  9:21 ` [PATCH v4 11/13] drm/fb-helper: Export helpers for marking damage areas Thomas Zimmermann
2023-05-29 19:38   ` Sam Ravnborg
2023-05-24  9:21 ` [PATCH v4 12/13] drm/fbdev-generic: Implement dedicated fbdev I/O helpers Thomas Zimmermann
2023-05-24 20:23   ` [v4,12/13] " Sui Jingfeng
2023-05-26 12:44     ` Thomas Zimmermann
2023-05-25  2:46   ` Sui Jingfeng
2023-05-24  9:21 ` [PATCH v4 13/13] drm/i915: " Thomas Zimmermann
2023-05-24 21:25   ` [v4,13/13] " Sui Jingfeng
2023-05-29 19:36   ` [PATCH v4 13/13] " Sam Ravnborg
2023-05-30  4:02     ` Sui Jingfeng
2023-05-30  7:12     ` Thomas Zimmermann
2023-05-30 15:37       ` Sam Ravnborg
2023-05-29 19:41   ` Sam Ravnborg
2023-05-29 19:37 ` [PATCH v4 00/13] drm/fbdev: Remove DRM's helpers for fbdev I/O Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230524092150.11776-4-tzimmermann@suse.de \
    --to=tzimmermann@suse.de \
    --cc=airlied@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=javierm@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox