From: Thomas Zimmermann <tzimmermann@suse.de>
To: daniel@ffwll.ch, airlied@gmail.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
javierm@redhat.com, sam@ravnborg.org
Cc: dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
freedreno@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
linux-tegra@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Inki Dae <inki.dae@samsung.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>
Subject: [PATCH v4 04/13] drm/exynos: Use regular fbdev I/O helpers
Date: Wed, 24 May 2023 11:21:41 +0200 [thread overview]
Message-ID: <20230524092150.11776-5-tzimmermann@suse.de> (raw)
In-Reply-To: <20230524092150.11776-1-tzimmermann@suse.de>
Use the regular fbdev helpers for framebuffer I/O instead of DRM's
helpers. Exynos does not use damage handling, so DRM's fbdev helpers
are mere wrappers around the fbdev code.
By using fbdev helpers directly within each DRM fbdev emulation,
we can eventually remove DRM's wrapper functions entirely.
v4:
* use initializer macros for struct fb_ops
v3:
* don't reorder Makefile rules (Sam)
v2:
* use FB_IO_HELPERS option
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Inki Dae <inki.dae@samsung.com>
Cc: Seung-Woo Kim <sw0312.kim@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>
---
drivers/gpu/drm/exynos/Kconfig | 1 +
drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 9 ++++-----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig
index 0cb92d651ff1..7ca7e1dab52c 100644
--- a/drivers/gpu/drm/exynos/Kconfig
+++ b/drivers/gpu/drm/exynos/Kconfig
@@ -7,6 +7,7 @@ config DRM_EXYNOS
select DRM_DISPLAY_HELPER if DRM_EXYNOS_DP
select DRM_KMS_HELPER
select VIDEOMODE_HELPERS
+ select FB_IO_HELPERS if DRM_FBDEV_EMULATION
select SND_SOC_HDMI_CODEC if SND_SOC
help
Choose this option if you have a Samsung SoC Exynos chipset.
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
index ea4b3d248aac..fdf65587f1fe 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
@@ -8,6 +8,8 @@
* Seung-Woo Kim <sw0312.kim@samsung.com>
*/
+#include <linux/fb.h>
+
#include <drm/drm_crtc_helper.h>
#include <drm/drm_drv.h>
#include <drm/drm_fb_helper.h>
@@ -47,13 +49,10 @@ static void exynos_drm_fb_destroy(struct fb_info *info)
static const struct fb_ops exynos_drm_fb_ops = {
.owner = THIS_MODULE,
+ __FB_DEFAULT_IO_OPS_RDWR,
DRM_FB_HELPER_DEFAULT_OPS,
+ __FB_DEFAULT_IO_OPS_DRAW,
.fb_mmap = exynos_drm_fb_mmap,
- .fb_read = drm_fb_helper_cfb_read,
- .fb_write = drm_fb_helper_cfb_write,
- .fb_fillrect = drm_fb_helper_cfb_fillrect,
- .fb_copyarea = drm_fb_helper_cfb_copyarea,
- .fb_imageblit = drm_fb_helper_cfb_imageblit,
.fb_destroy = exynos_drm_fb_destroy,
};
--
2.40.1
next prev parent reply other threads:[~2023-05-24 9:22 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 9:21 [PATCH v4 00/13] drm/fbdev: Remove DRM's helpers for fbdev I/O Thomas Zimmermann
2023-05-24 9:21 ` [PATCH v4 01/13] fbdev: Add Kconfig options to select different fb_ops helpers Thomas Zimmermann
2023-05-24 20:46 ` [v4,01/13] " Sui Jingfeng
2023-05-29 19:17 ` [PATCH v4 01/13] " Sam Ravnborg
2023-05-24 9:21 ` [PATCH v4 02/13] fbdev: Add initializer macros for struct fb_ops Thomas Zimmermann
2023-05-24 20:57 ` [v4,02/13] " Sui Jingfeng
2023-05-26 12:38 ` Thomas Zimmermann
2023-05-29 19:23 ` [PATCH v4 02/13] " Sam Ravnborg
2023-05-24 9:21 ` [PATCH v4 03/13] drm/armada: Use regular fbdev I/O helpers Thomas Zimmermann
2023-05-29 19:24 ` Sam Ravnborg
2023-05-24 9:21 ` Thomas Zimmermann [this message]
2023-05-24 9:21 ` [PATCH v4 05/13] drm/gma500: " Thomas Zimmermann
2023-05-24 9:21 ` [PATCH v4 06/13] drm/radeon: " Thomas Zimmermann
2023-05-24 9:21 ` [PATCH v4 07/13] drm/fbdev-dma: " Thomas Zimmermann
2023-05-24 9:21 ` [PATCH v4 08/13] drm/msm: " Thomas Zimmermann
2023-05-24 9:21 ` [PATCH v4 09/13] drm/omapdrm: " Thomas Zimmermann
2023-05-24 9:21 ` [PATCH v4 10/13] drm/tegra: " Thomas Zimmermann
2023-05-24 9:21 ` [PATCH v4 11/13] drm/fb-helper: Export helpers for marking damage areas Thomas Zimmermann
2023-05-29 19:38 ` Sam Ravnborg
2023-05-24 9:21 ` [PATCH v4 12/13] drm/fbdev-generic: Implement dedicated fbdev I/O helpers Thomas Zimmermann
2023-05-24 20:23 ` [v4,12/13] " Sui Jingfeng
2023-05-26 12:44 ` Thomas Zimmermann
2023-05-25 2:46 ` Sui Jingfeng
2023-05-24 9:21 ` [PATCH v4 13/13] drm/i915: " Thomas Zimmermann
2023-05-24 21:25 ` [v4,13/13] " Sui Jingfeng
2023-05-29 19:36 ` [PATCH v4 13/13] " Sam Ravnborg
2023-05-30 4:02 ` Sui Jingfeng
2023-05-30 7:12 ` Thomas Zimmermann
2023-05-30 15:37 ` Sam Ravnborg
2023-05-29 19:41 ` Sam Ravnborg
2023-05-29 19:37 ` [PATCH v4 00/13] drm/fbdev: Remove DRM's helpers for fbdev I/O Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230524092150.11776-5-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=sam@ravnborg.org \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox