From: Maximilian Luz <luzmaximilian@gmail.com>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Maximilian Luz <luzmaximilian@gmail.com>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Ard Biesheuvel <ardb@kernel.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Johan Hovold <johan@kernel.org>,
Steev Klimaszewski <steev@kali.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v5 0/3] firmware: Add support for Qualcomm UEFI Secure Application
Date: Sun, 30 Jul 2023 18:19:01 +0200 [thread overview]
Message-ID: <20230730161906.606163-1-luzmaximilian@gmail.com> (raw)
This series adds basic support for the QSEECOM interface used to
communicate with secure applications running in the TrustZone on certain
Qualcomm devices. In addition to that, it also provides a driver for
"uefisecapp", the secure application managing access to UEFI variables
on such platforms.
For a more detailed description, see the blurb of v1.
Previous versions:
- V4: https://lore.kernel.org/lkml/72c0359a-eda6-30ea-0ec0-b7e9b804b87b@gmail.com/t/
- V3: https://lore.kernel.org/lkml/20230305022119.1331495-4-luzmaximilian@gmail.com/t/
- V2: https://lore.kernel.org/lkml/20230127184650.756795-1-luzmaximilian@gmail.com/
- V1: https://lore.kernel.org/lkml/20220723224949.1089973-1-luzmaximilian@gmail.com/
Changes in v5:
- Re-introduce a dedicated platform device for managing QSEECOM client
devices. The device is now added via qcom_scm.c instead of the device
tree (as has been done in v3).
- Replace ucs2_strlcpy() with ucs2_strscpy()
- Drop "firmware: qcom_scm: Clear scm pointer on probe failure" and
sort out probe-related issue.
- Clean up comments in qcom_qseecom_uefisecapp.c
Changes in v4:
- Integrate the QSEECOM interface into qcom_scm.c instead of
instantiating a custom device and requiring device-tree bindings for
it. With that, drop the respective patches exporting SCM call
functions from qcom_scm.c and the DT bindings.
- Restructure management of DMA memory and move DMA mapping entirely
into the app_send() command, removing the need for DMA handling in
app client drivers.
- Add support for EFI's query_variable_info() call.
- Move UCS-2 string helpers to lib/ucs2_string.c (introduces patch 1).
- Add fix for related cleanup-issue in qcom_scm.c (introduces patch 2).
(Refer to individual patches for more details.)
Changes in v3:
- Fix doc comment in qcom_scm.c
- Rebase on top of latest changes to qcom_scm.
Changes in v2:
- Bind the qseecom interface to a device.
- Establish a device link between the new qseecom device and the SCM
device to ensure proper PM and remove ordering.
- Remove the compatible for uefisecapp. Instead, introduce a compatible
for the qseecom device. This directly reflects ACPI tables and the
QCOM0476 device described therein, which is responsible for the
secure app / qseecom interface (i.e., the same purpose).
Client devices representing apps handled by the kernel (such as
uefisecapp) are now directly instantiated by the qseecom driver,
based on the respective platform-specific compatible.
- Rename the base name (qctree -> qseecom) to allow differentiation
between old (qseecom) and new (smcinvoke) interfaces to the trusted
execution environment. This directly reflects downstream naming by
Qualcomm.
Maximilian Luz (3):
lib/ucs2_string: Add UCS-2 strscpy function
firmware: qcom_scm: Add support for Qualcomm Secure Execution
Environment SCM interface
firmware: Add support for Qualcomm UEFI Secure Application
MAINTAINERS | 12 +
drivers/firmware/Kconfig | 33 +
drivers/firmware/Makefile | 2 +
drivers/firmware/qcom_qseecom.c | 130 +++
drivers/firmware/qcom_qseecom_uefisecapp.c | 869 +++++++++++++++++++++
drivers/firmware/qcom_scm.c | 392 ++++++++++
include/linux/firmware/qcom/qcom_qseecom.h | 46 ++
include/linux/firmware/qcom/qcom_scm.h | 21 +
include/linux/ucs2_string.h | 1 +
lib/ucs2_string.c | 35 +
10 files changed, 1541 insertions(+)
create mode 100644 drivers/firmware/qcom_qseecom.c
create mode 100644 drivers/firmware/qcom_qseecom_uefisecapp.c
create mode 100644 include/linux/firmware/qcom/qcom_qseecom.h
--
2.41.0
next reply other threads:[~2023-07-30 16:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-30 16:19 Maximilian Luz [this message]
2023-07-30 16:19 ` [PATCH v5 1/3] lib/ucs2_string: Add UCS-2 strscpy function Maximilian Luz
2023-08-03 15:17 ` Bjorn Andersson
2023-08-04 8:18 ` Kees Cook
2023-08-04 19:23 ` Maximilian Luz
2023-07-30 16:19 ` [PATCH v5 2/3] firmware: qcom_scm: Add support for Qualcomm Secure Execution Environment SCM interface Maximilian Luz
2023-07-30 18:04 ` Maximilian Luz
2023-07-30 18:47 ` Maximilian Luz
2023-08-04 16:48 ` Johan Hovold
2023-08-04 20:11 ` Maximilian Luz
2023-08-07 8:46 ` Johan Hovold
2023-07-30 16:19 ` [PATCH v5 3/3] firmware: Add support for Qualcomm UEFI Secure Application Maximilian Luz
2023-08-03 15:44 ` Ard Biesheuvel
2023-08-03 17:09 ` Maximilian Luz
2023-08-04 10:56 ` Ard Biesheuvel
2023-08-04 16:54 ` Johan Hovold
2023-08-04 19:44 ` Maximilian Luz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230730161906.606163-1-luzmaximilian@gmail.com \
--to=luzmaximilian@gmail.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=ardb@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=johan@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=steev@kali.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox