From: Maximilian Luz <luzmaximilian@gmail.com>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Ard Biesheuvel <ardb@kernel.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Johan Hovold <johan@kernel.org>,
Steev Klimaszewski <steev@kali.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/3] firmware: qcom_scm: Add support for Qualcomm Secure Execution Environment SCM interface
Date: Sun, 30 Jul 2023 20:47:09 +0200 [thread overview]
Message-ID: <bb80fc94-7a80-f951-13a9-a0c055c8dbc8@gmail.com> (raw)
In-Reply-To: <20230730161906.606163-3-luzmaximilian@gmail.com>
On 7/30/23 18:19, Maximilian Luz wrote:
[...]
> diff --git a/drivers/firmware/qcom_qseecom.c b/drivers/firmware/qcom_qseecom.c
> new file mode 100644
> index 000000000000..e9edd500c3d9
> --- /dev/null
> +++ b/drivers/firmware/qcom_qseecom.c
> @@ -0,0 +1,128 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * Driver for Qualcomm Secure Execution Environment (SEE) interface (QSEECOM).
> + * Responsible for setting up and managing QSEECOM client devices.
> + *
> + * Copyright (C) 2023 Maximilian Luz <luzmaximilian@gmail.com>
> + */
> +#include <linux/auxiliary_bus.h>
> +#include <linux/platform_device.h>
> +#include <linux/types.h>
This is missing a linux/slab.h include for kzalloc() and kfree(). Fixed
for v6 as well.
Kernel test robot caught this as well... I guess I need to look into
building with more warnings enabled because I didn't catch that on my
system.
Regards
Max
next prev parent reply other threads:[~2023-07-30 18:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-30 16:19 [PATCH v5 0/3] firmware: Add support for Qualcomm UEFI Secure Application Maximilian Luz
2023-07-30 16:19 ` [PATCH v5 1/3] lib/ucs2_string: Add UCS-2 strscpy function Maximilian Luz
2023-08-03 15:17 ` Bjorn Andersson
2023-08-04 8:18 ` Kees Cook
2023-08-04 19:23 ` Maximilian Luz
2023-07-30 16:19 ` [PATCH v5 2/3] firmware: qcom_scm: Add support for Qualcomm Secure Execution Environment SCM interface Maximilian Luz
2023-07-30 18:04 ` Maximilian Luz
2023-07-30 18:47 ` Maximilian Luz [this message]
2023-08-04 16:48 ` Johan Hovold
2023-08-04 20:11 ` Maximilian Luz
2023-08-07 8:46 ` Johan Hovold
2023-07-30 16:19 ` [PATCH v5 3/3] firmware: Add support for Qualcomm UEFI Secure Application Maximilian Luz
2023-08-03 15:44 ` Ard Biesheuvel
2023-08-03 17:09 ` Maximilian Luz
2023-08-04 10:56 ` Ard Biesheuvel
2023-08-04 16:54 ` Johan Hovold
2023-08-04 19:44 ` Maximilian Luz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb80fc94-7a80-f951-13a9-a0c055c8dbc8@gmail.com \
--to=luzmaximilian@gmail.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=ardb@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=johan@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=steev@kali.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox