Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Benjamin Gaignard <benjamin.gaignard@collabora.com>
To: mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com,
	ming.qian@nxp.com, ezequiel@vanguardiasur.com.ar,
	p.zabel@pengutronix.de, gregkh@linuxfoundation.org,
	hverkuil-cisco@xs4all.nl, nicolas.dufresne@collabora.com
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-staging@lists.linux.dev, kernel@collabora.com,
	Benjamin Gaignard <benjamin.gaignard@collabora.com>
Subject: [PATCH v8 13/53] media: Report the maximum possible number of buffers for the queue
Date: Wed, 27 Sep 2023 17:35:18 +0200	[thread overview]
Message-ID: <20230927153558.159278-14-benjamin.gaignard@collabora.com> (raw)
In-Reply-To: <20230927153558.159278-1-benjamin.gaignard@collabora.com>

Use one of the struct v4l2_create_buffers reserved bytes to report
the maximum possible number of buffers for the queue.
V4l2 framework set V4L2_BUF_CAP_SUPPORTS_SET_MAX_BUFS flags in queue
capabilities so userland can know when the field is valid.

Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
---
 .../userspace-api/media/v4l/vidioc-create-bufs.rst       | 8 ++++++--
 Documentation/userspace-api/media/v4l/vidioc-reqbufs.rst | 1 +
 drivers/media/common/videobuf2/videobuf2-v4l2.c          | 9 +++++++--
 drivers/media/v4l2-core/v4l2-ioctl.c                     | 4 ++--
 include/uapi/linux/videodev2.h                           | 7 ++++++-
 5 files changed, 22 insertions(+), 7 deletions(-)

diff --git a/Documentation/userspace-api/media/v4l/vidioc-create-bufs.rst b/Documentation/userspace-api/media/v4l/vidioc-create-bufs.rst
index a048a9f6b7b6..1a46549e7462 100644
--- a/Documentation/userspace-api/media/v4l/vidioc-create-bufs.rst
+++ b/Documentation/userspace-api/media/v4l/vidioc-create-bufs.rst
@@ -116,9 +116,13 @@ than the number requested.
       - ``flags``
       - Specifies additional buffer management attributes.
 	See :ref:`memory-flags`.
-
     * - __u32
-      - ``reserved``\ [6]
+      - ``max_buffers``
+      - If V4L2_BUF_CAP_SUPPORTS_SET_MAX_BUFS capability flag is set
+        this field indicate the maximum possible number of buffers
+        for this queue.
+    * - __u32
+      - ``reserved``\ [5]
       - A place holder for future extensions. Drivers and applications
 	must set the array to zero.
 
diff --git a/Documentation/userspace-api/media/v4l/vidioc-reqbufs.rst b/Documentation/userspace-api/media/v4l/vidioc-reqbufs.rst
index 099fa6695167..0395187e1a5a 100644
--- a/Documentation/userspace-api/media/v4l/vidioc-reqbufs.rst
+++ b/Documentation/userspace-api/media/v4l/vidioc-reqbufs.rst
@@ -120,6 +120,7 @@ aborting or finishing any DMA in progress, an implicit
 .. _V4L2-BUF-CAP-SUPPORTS-ORPHANED-BUFS:
 .. _V4L2-BUF-CAP-SUPPORTS-M2M-HOLD-CAPTURE-BUF:
 .. _V4L2-BUF-CAP-SUPPORTS-MMAP-CACHE-HINTS:
+.. _V4L2-BUF-CAP-SUPPORTS-SET-MAX-BUFS:
 
 .. raw:: latex
 
diff --git a/drivers/media/common/videobuf2/videobuf2-v4l2.c b/drivers/media/common/videobuf2/videobuf2-v4l2.c
index 278ea1107b01..655133f1ae2b 100644
--- a/drivers/media/common/videobuf2/videobuf2-v4l2.c
+++ b/drivers/media/common/videobuf2/videobuf2-v4l2.c
@@ -686,6 +686,7 @@ EXPORT_SYMBOL(vb2_querybuf);
 static void fill_buf_caps(struct vb2_queue *q, u32 *caps)
 {
 	*caps = V4L2_BUF_CAP_SUPPORTS_ORPHANED_BUFS;
+	*caps |= V4L2_BUF_CAP_SUPPORTS_SET_MAX_BUFS;
 	if (q->io_modes & VB2_MMAP)
 		*caps |= V4L2_BUF_CAP_SUPPORTS_MMAP;
 	if (q->io_modes & VB2_USERPTR)
@@ -767,9 +768,13 @@ int vb2_create_bufs(struct vb2_queue *q, struct v4l2_create_buffers *create)
 
 	fill_buf_caps(q, &create->capabilities);
 	validate_memory_flags(q, create->memory, &create->flags);
-	create->index = q->num_buffers;
-	if (create->count == 0)
+
+	create->max_buffers = q->max_num_buffers;
+
+	if (create->count == 0) {
+		create->index = vb2_get_num_buffers(q);
 		return ret != -EBUSY ? ret : 0;
+	}
 
 	switch (f->type) {
 	case V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE:
diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
index f4d9d6279094..700db197e371 100644
--- a/drivers/media/v4l2-core/v4l2-ioctl.c
+++ b/drivers/media/v4l2-core/v4l2-ioctl.c
@@ -483,9 +483,9 @@ static void v4l_print_create_buffers(const void *arg, bool write_only)
 {
 	const struct v4l2_create_buffers *p = arg;
 
-	pr_cont("index=%d, count=%d, memory=%s, capabilities=0x%08x, ",
+	pr_cont("index=%d, count=%d, memory=%s, capabilities=0x%08x, max buffers=%u",
 		p->index, p->count, prt_names(p->memory, v4l2_memory_names),
-		p->capabilities);
+		p->capabilities, p->max_buffers);
 	v4l_print_format(&p->format, write_only);
 }
 
diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
index 78260e5d9985..b0dbb1be728c 100644
--- a/include/uapi/linux/videodev2.h
+++ b/include/uapi/linux/videodev2.h
@@ -1034,6 +1034,7 @@ struct v4l2_requestbuffers {
 #define V4L2_BUF_CAP_SUPPORTS_ORPHANED_BUFS		(1 << 4)
 #define V4L2_BUF_CAP_SUPPORTS_M2M_HOLD_CAPTURE_BUF	(1 << 5)
 #define V4L2_BUF_CAP_SUPPORTS_MMAP_CACHE_HINTS		(1 << 6)
+#define V4L2_BUF_CAP_SUPPORTS_SET_MAX_BUFS		(1 << 7)
 
 /**
  * struct v4l2_plane - plane info for multi-planar buffers
@@ -2604,6 +2605,9 @@ struct v4l2_dbg_chip_info {
  * @flags:	additional buffer management attributes (ignored unless the
  *		queue has V4L2_BUF_CAP_SUPPORTS_MMAP_CACHE_HINTS capability
  *		and configured for MMAP streaming I/O).
+ * @max_buffers: if V4L2_BUF_CAP_SUPPORTS_SET_MAX_BUFS capability flag is set
+ *		 this field indicate the maximum possible number of buffers
+ *		 for this queue.
  * @reserved:	future extensions
  */
 struct v4l2_create_buffers {
@@ -2613,7 +2617,8 @@ struct v4l2_create_buffers {
 	struct v4l2_format	format;
 	__u32			capabilities;
 	__u32			flags;
-	__u32			reserved[6];
+	__u32			max_buffers;
+	__u32			reserved[5];
 };
 
 /*
-- 
2.39.2


  parent reply	other threads:[~2023-09-27 15:36 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-27 15:35 [PATCH v8 00/53] Add DELETE_BUF ioctl Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 01/53] media: videobuf2: Rework offset 'cookie' encoding pattern Benjamin Gaignard
2023-09-30  8:52   ` Hans Verkuil
2023-09-27 15:35 ` [PATCH v8 02/53] media: videobuf2: Stop spamming kernel log with all queue counter Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 03/53] media: videobuf2: Use vb2_buffer instead of index Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 04/53] media: amphion: Use vb2_get_buffer() instead of directly access to buffers array Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 05/53] media: mediatek: jpeg: " Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 06/53] media: mediatek: vdec: Remove useless loop Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 07/53] media: sti: hva: Use vb2_get_buffer() instead of directly access to buffers array Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 08/53] media: visl: " Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 09/53] media: atomisp: " Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 10/53] media: dvb-core: " Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 11/53] media: videobuf2: Access vb2_queue bufs array through helper functions Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 12/53] media: videobuf2: Be more flexible on the number of queue stored buffers Benjamin Gaignard
2023-09-27 15:35 ` Benjamin Gaignard [this message]
2023-10-02 13:37   ` [PATCH v8 13/53] media: Report the maximum possible number of buffers for the queue Hans Verkuil
2023-10-02 13:46     ` Benjamin Gaignard
2023-10-02 13:49       ` Hans Verkuil
2023-09-27 15:35 ` [PATCH v8 14/53] media: test-drivers: vivid: Increase max supported buffers for capture queues Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 15/53] media: test-drivers: vicodec: Increase max supported capture queue buffers Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 16/53] media: verisilicon: Refactor postprocessor to store more buffers Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 17/53] media: verisilicon: Store chroma and motion vectors offset Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 18/53] media: verisilicon: g2: Use common helpers to compute chroma and mv offsets Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 19/53] media: verisilicon: vp9: Allow to change resolution while streaming Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 20/53] media: Remove duplicated index vs q->num_buffers check Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 21/53] media: core: Add helper to get queue number of buffers Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 22/53] media: dvb-core: Do not initialize twice queue num_buffer field Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 23/53] media: dvb-frontends: rtl2832_srd: Use queue min_buffers_needed field Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 24/53] media: video-i2c: Set min_buffers_needed to 2 Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 25/53] media: pci: cx18: Set correct value to min_buffers_needed field Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 26/53] media: pci: dt3155: Remove useless check Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 27/53] media: pci: netup_unidvb: Remove useless number of buffers check Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 28/53] media: pci: tw68: Stop direct calls to queue num_buffers field Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 29/53] media: pci: tw686x: Set min_buffers_needed to 3 Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 30/53] media: amphion: Stop direct calls to queue num_buffers field Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 31/53] media: coda: " Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 32/53] media: mediatek: vcodec: " Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 33/53] media: nxp: " Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 34/53] media: renesas: Set min_buffers_needed to 16 Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 35/53] media: ti: Use queue min_buffers_needed field to set the min number of buffers Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 36/53] media: verisilicon: Stop direct calls to queue num_buffers field Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 37/53] media: test-drivers: " Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 38/53] media: usb: airspy: Set min_buffers_needed to 8 Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 39/53] media: usb: cx231xx: Set min_buffers_needed to CX231XX_MIN_BUF Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 40/53] media: usb: hackrf: Set min_buffers_needed to 8 Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 41/53] media: usb: usbtv: Set min_buffers_needed to 2 Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 42/53] media: atomisp: Stop direct calls to queue num_buffers field Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 43/53] media: imx: " Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 44/53] media: meson: vdec: " Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 45/53] touchscreen: sur40: " Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 46/53] sample: v4l: " Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 47/53] media: cedrus: " Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 48/53] media: core: Rework how create_buf index returned value is computed Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 49/53] media: core: Add bitmap manage bufs array entries Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 50/53] media: core: Free range of buffers Benjamin Gaignard
2023-09-30  5:09   ` kernel test robot
2023-09-27 15:35 ` [PATCH v8 51/53] media: v4l2: Add DELETE_BUFS ioctl Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 52/53] media: v4l2: Add mem2mem helpers for " Benjamin Gaignard
2023-09-27 15:35 ` [PATCH v8 53/53] media: test-drivers: Use helper " Benjamin Gaignard
2023-09-28 13:04 ` [PATCH v8 00/53] Add DELETE_BUF ioctl Hans Verkuil
2023-09-28 13:16   ` Benjamin Gaignard
2023-09-29 11:44     ` Benjamin Gaignard
2023-09-29 13:17       ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230927153558.159278-14-benjamin.gaignard@collabora.com \
    --to=benjamin.gaignard@collabora.com \
    --cc=ezequiel@vanguardiasur.com.ar \
    --cc=gregkh@linuxfoundation.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=kernel@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=m.szyprowski@samsung.com \
    --cc=mchehab@kernel.org \
    --cc=ming.qian@nxp.com \
    --cc=nicolas.dufresne@collabora.com \
    --cc=p.zabel@pengutronix.de \
    --cc=tfiga@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox