* [PATCH v2] drm/msm/dsi: use the correct VREG_CTRL_1 value for 4nm cphy
@ 2023-11-10 0:02 Jonathan Marek
2023-11-16 20:36 ` Abhinav Kumar
2023-11-21 18:29 ` Abhinav Kumar
0 siblings, 2 replies; 4+ messages in thread
From: Jonathan Marek @ 2023-11-10 0:02 UTC (permalink / raw)
To: freedreno
Cc: Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
Marijn Suijten, David Airlie, Daniel Vetter, Konrad Dybcio,
Vinod Koul, Robert Foss, Neil Armstrong,
open list:DRM DRIVER FOR MSM ADRENO GPU,
open list:DRM DRIVER FOR MSM ADRENO GPU, open list
Use the same value as the downstream driver. This change is needed for CPHY
mode to work correctly.
Fixes: 8b034e6771113 ("drm/msm/dsi: add support for DSI-PHY on SM8550")
Signed-off-by: Jonathan Marek <jonathan@marek.ca>
---
v2: fixed the Fixes: line
drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c
index 3b1ed02f644d..89a6344bc865 100644
--- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c
+++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c
@@ -918,7 +918,7 @@ static int dsi_7nm_phy_enable(struct msm_dsi_phy *phy,
if ((phy->cfg->quirks & DSI_PHY_7NM_QUIRK_V5_2)) {
if (phy->cphy_mode) {
vreg_ctrl_0 = 0x45;
- vreg_ctrl_1 = 0x45;
+ vreg_ctrl_1 = 0x41;
glbl_rescode_top_ctrl = 0x00;
glbl_rescode_bot_ctrl = 0x00;
} else {
--
2.26.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] drm/msm/dsi: use the correct VREG_CTRL_1 value for 4nm cphy
2023-11-10 0:02 [PATCH v2] drm/msm/dsi: use the correct VREG_CTRL_1 value for 4nm cphy Jonathan Marek
@ 2023-11-16 20:36 ` Abhinav Kumar
2023-11-16 20:49 ` [Freedreno] " Abhinav Kumar
2023-11-21 18:29 ` Abhinav Kumar
1 sibling, 1 reply; 4+ messages in thread
From: Abhinav Kumar @ 2023-11-16 20:36 UTC (permalink / raw)
To: Jonathan Marek, freedreno
Cc: Rob Clark, Dmitry Baryshkov, Sean Paul, Marijn Suijten,
David Airlie, Daniel Vetter, Konrad Dybcio, Vinod Koul,
Robert Foss, Neil Armstrong,
open list:DRM DRIVER FOR MSM ADRENO GPU,
open list:DRM DRIVER FOR MSM ADRENO GPU, open list
On 11/9/2023 4:02 PM, Jonathan Marek wrote:
> Use the same value as the downstream driver. This change is needed for CPHY
> mode to work correctly.
>
> Fixes: 8b034e6771113 ("drm/msm/dsi: add support for DSI-PHY on SM8550")
> Signed-off-by: Jonathan Marek <jonathan@marek.ca>
> ---
> v2: fixed the Fixes: line
>
> drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Good catch !
LGTM
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c
> index 3b1ed02f644d..89a6344bc865 100644
> --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c
> +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c
> @@ -918,7 +918,7 @@ static int dsi_7nm_phy_enable(struct msm_dsi_phy *phy,
> if ((phy->cfg->quirks & DSI_PHY_7NM_QUIRK_V5_2)) {
> if (phy->cphy_mode) {
> vreg_ctrl_0 = 0x45;
> - vreg_ctrl_1 = 0x45;
> + vreg_ctrl_1 = 0x41;
> glbl_rescode_top_ctrl = 0x00;
> glbl_rescode_bot_ctrl = 0x00;
> } else {
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Freedreno] [PATCH v2] drm/msm/dsi: use the correct VREG_CTRL_1 value for 4nm cphy
2023-11-16 20:36 ` Abhinav Kumar
@ 2023-11-16 20:49 ` Abhinav Kumar
0 siblings, 0 replies; 4+ messages in thread
From: Abhinav Kumar @ 2023-11-16 20:49 UTC (permalink / raw)
To: Jonathan Marek, freedreno
Cc: Neil Armstrong, Robert Foss, David Airlie, Konrad Dybcio,
Vinod Koul, open list:DRM DRIVER FOR MSM ADRENO GPU, open list,
Rob Clark, Daniel Vetter, open list:DRM DRIVER FOR MSM ADRENO GPU,
Dmitry Baryshkov, Marijn Suijten, Sean Paul
On 11/16/2023 12:36 PM, Abhinav Kumar wrote:
>
>
> On 11/9/2023 4:02 PM, Jonathan Marek wrote:
>> Use the same value as the downstream driver. This change is needed for
>> CPHY
>> mode to work correctly.
>>
>> Fixes: 8b034e6771113 ("drm/msm/dsi: add support for DSI-PHY on SM8550")
One error here. We need 12 chars of SHA but you have 13 otherwise
checkpatch cries
Fixes: 8b034e677111 ("drm/msm/dsi: add support for DSI-PHY on SM8550")
Will fix this up while applying.
>> Signed-off-by: Jonathan Marek <jonathan@marek.ca>
>> ---
>> v2: fixed the Fixes: line
>>
>> drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>
> Good catch !
>
> LGTM
>
> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
>
>> diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c
>> b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c
>> index 3b1ed02f644d..89a6344bc865 100644
>> --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c
>> +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c
>> @@ -918,7 +918,7 @@ static int dsi_7nm_phy_enable(struct msm_dsi_phy
>> *phy,
>> if ((phy->cfg->quirks & DSI_PHY_7NM_QUIRK_V5_2)) {
>> if (phy->cphy_mode) {
>> vreg_ctrl_0 = 0x45;
>> - vreg_ctrl_1 = 0x45;
>> + vreg_ctrl_1 = 0x41;
>> glbl_rescode_top_ctrl = 0x00;
>> glbl_rescode_bot_ctrl = 0x00;
>> } else {
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drm/msm/dsi: use the correct VREG_CTRL_1 value for 4nm cphy
2023-11-10 0:02 [PATCH v2] drm/msm/dsi: use the correct VREG_CTRL_1 value for 4nm cphy Jonathan Marek
2023-11-16 20:36 ` Abhinav Kumar
@ 2023-11-21 18:29 ` Abhinav Kumar
1 sibling, 0 replies; 4+ messages in thread
From: Abhinav Kumar @ 2023-11-21 18:29 UTC (permalink / raw)
To: freedreno, Jonathan Marek
Cc: Abhinav Kumar, Rob Clark, Dmitry Baryshkov, Sean Paul,
Marijn Suijten, David Airlie, Daniel Vetter, Konrad Dybcio,
Vinod Koul, Robert Foss, Neil Armstrong, linux-arm-msm, dri-devel,
linux-kernel
On Thu, 09 Nov 2023 19:02:14 -0500, Jonathan Marek wrote:
> Use the same value as the downstream driver. This change is needed for CPHY
> mode to work correctly.
>
>
Applied, thanks!
[1/1] drm/msm/dsi: use the correct VREG_CTRL_1 value for 4nm cphy
https://gitlab.freedesktop.org/drm/msm/-/commit/b3e0f94d1570
Best regards,
--
Abhinav Kumar <quic_abhinavk@quicinc.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-21 18:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-10 0:02 [PATCH v2] drm/msm/dsi: use the correct VREG_CTRL_1 value for 4nm cphy Jonathan Marek
2023-11-16 20:36 ` Abhinav Kumar
2023-11-16 20:49 ` [Freedreno] " Abhinav Kumar
2023-11-21 18:29 ` Abhinav Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox