From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Qingqing Zhou <quic_qqzhou@quicinc.com>
Cc: Andrew Halaney <ahalaney@redhat.com>,
andersson@kernel.org, konrad.dybcio@linaro.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sa8775p: Mark APPS and PCIE SMMUs as DMA coherent
Date: Tue, 16 Jul 2024 11:35:36 +0530 [thread overview]
Message-ID: <20240716060536.GH3446@thinkpad> (raw)
In-Reply-To: <c8b0c7ce-f02a-4d38-8473-4c20287ddbcc@quicinc.com>
On Tue, Jul 16, 2024 at 02:00:15PM +0800, Qingqing Zhou wrote:
>
>
> 在 7/16/2024 2:14 AM, Andrew Halaney 写道:
> > On Mon, Jul 15, 2024 at 12:46:49PM GMT, Qingqing Zhou wrote:
> >> The SMMUs on sa8775p are cache-coherent. GPU SMMU is marked as such,
> >> mark the APPS and PCIE ones as well.
> >>
> >> Signed-off-by: Qingqing Zhou <quic_qqzhou@quicinc.com>
> >
> > I think this deserves a Fixes tag as well, not treating it as
> > dma-coherent is a bug and can lead to difficult to debug errors based on
> > a quick search through lkml.
> >
> > Thanks,
> > Andrew
> >
>
> Andrew, thanks for your review comments, do you mean to add below two lines?
> Fixes: 603f96d4c9d0 ("arm64: dts: qcom: add initial support for qcom sa8775p-ride")
> Fixes: 2dba7a613a6e ("arm64: dts: qcom: sa8775p: add the pcie smmu node")
>
Yes, looks to be it. With the tags added,
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
And CC stable if the offending commits went into any stable kernels.
- Mani
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2024-07-16 6:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 7:16 [PATCH] arm64: dts: qcom: sa8775p: Mark APPS and PCIE SMMUs as DMA coherent Qingqing Zhou
2024-07-15 16:39 ` Konrad Dybcio
2024-07-15 16:40 ` Konrad Dybcio
2024-07-15 18:14 ` Andrew Halaney
2024-07-16 6:00 ` Qingqing Zhou
2024-07-16 6:05 ` Manivannan Sadhasivam [this message]
2024-07-16 7:00 ` Qingqing Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240716060536.GH3446@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=ahalaney@redhat.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_qqzhou@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox