* [PATCH 1/6] arm64: dts: qcom: x1e78100-t14s: fix nvme regulator boot glitch
2024-10-16 14:51 [PATCH 0/6] arm64: dts: qcom: x1e80100: fix nvme regulator boot glitch Johan Hovold
@ 2024-10-16 14:51 ` Johan Hovold
2024-10-16 14:51 ` [PATCH 2/6] arm64: dts: qcom: x1e80100-crd: " Johan Hovold
` (7 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Johan Hovold @ 2024-10-16 14:51 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa,
linux-arm-msm, devicetree, linux-kernel, Johan Hovold
The NVMe regulator has been left enabled by the boot firmware. Mark it
as such to avoid disabling the regulator temporarily during boot.
Fixes: 7d1cbe2f4985 ("arm64: dts: qcom: Add X1E78100 ThinkPad T14s Gen 6")
Cc: Konrad Dybcio <konradybcio@kernel.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts
index 941dfddd6713..fdde988ae01e 100644
--- a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts
+++ b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts
@@ -139,6 +139,8 @@ vreg_nvme: regulator-nvme {
pinctrl-0 = <&nvme_reg_en>;
pinctrl-names = "default";
+
+ regulator-boot-on;
};
vph_pwr: regulator-vph-pwr {
--
2.45.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 2/6] arm64: dts: qcom: x1e80100-crd: fix nvme regulator boot glitch
2024-10-16 14:51 [PATCH 0/6] arm64: dts: qcom: x1e80100: fix nvme regulator boot glitch Johan Hovold
2024-10-16 14:51 ` [PATCH 1/6] arm64: dts: qcom: x1e78100-t14s: " Johan Hovold
@ 2024-10-16 14:51 ` Johan Hovold
2024-10-16 14:51 ` [PATCH 3/6] arm64: dts: qcom: x1e80100-vivobook-s15: " Johan Hovold
` (6 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Johan Hovold @ 2024-10-16 14:51 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa,
linux-arm-msm, devicetree, linux-kernel, Johan Hovold, stable
The NVMe regulator has been left enabled by the boot firmware. Mark it
as such to avoid disabling the regulator temporarily during boot.
Fixes: eb57cbe730d1 ("arm64: dts: qcom: x1e80100: Describe the PCIe 6a resources")
Cc: stable@vger.kernel.org # 6.11
Cc: Abel Vesa <abel.vesa@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
index 10b28d870f08..5d2eec8590ce 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts
@@ -300,6 +300,8 @@ vreg_nvme: regulator-nvme {
pinctrl-names = "default";
pinctrl-0 = <&nvme_reg_en>;
+
+ regulator-boot-on;
};
vreg_wwan: regulator-wwan {
--
2.45.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 3/6] arm64: dts: qcom: x1e80100-vivobook-s15: fix nvme regulator boot glitch
2024-10-16 14:51 [PATCH 0/6] arm64: dts: qcom: x1e80100: fix nvme regulator boot glitch Johan Hovold
2024-10-16 14:51 ` [PATCH 1/6] arm64: dts: qcom: x1e78100-t14s: " Johan Hovold
2024-10-16 14:51 ` [PATCH 2/6] arm64: dts: qcom: x1e80100-crd: " Johan Hovold
@ 2024-10-16 14:51 ` Johan Hovold
2024-10-16 14:51 ` [PATCH 4/6] arm64: dts: qcom: x1e80100-yoga-slim7x: " Johan Hovold
` (5 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Johan Hovold @ 2024-10-16 14:51 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa,
linux-arm-msm, devicetree, linux-kernel, Johan Hovold, stable,
Xilin Wu
The NVMe regulator has been left enabled by the boot firmware. Mark it
as such to avoid disabling the regulator temporarily during boot.
Fixes: d0e2f8f62dff ("arm64: dts: qcom: Add device tree for ASUS Vivobook S 15")
Cc: stable@vger.kernel.org # 6.11
Cc: Xilin Wu <wuxilin123@gmail.com>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
index 20616bd4aa6c..fb4a48a1e2a8 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
@@ -134,6 +134,8 @@ vreg_nvme: regulator-nvme {
pinctrl-0 = <&nvme_reg_en>;
pinctrl-names = "default";
+
+ regulator-boot-on;
};
};
--
2.45.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 4/6] arm64: dts: qcom: x1e80100-yoga-slim7x: fix nvme regulator boot glitch
2024-10-16 14:51 [PATCH 0/6] arm64: dts: qcom: x1e80100: fix nvme regulator boot glitch Johan Hovold
` (2 preceding siblings ...)
2024-10-16 14:51 ` [PATCH 3/6] arm64: dts: qcom: x1e80100-vivobook-s15: " Johan Hovold
@ 2024-10-16 14:51 ` Johan Hovold
2024-10-16 14:51 ` [PATCH 5/6] arm64: dts: qcom: x1e80100-microsoft-romulus: " Johan Hovold
` (4 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Johan Hovold @ 2024-10-16 14:51 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa,
linux-arm-msm, devicetree, linux-kernel, Johan Hovold, stable,
Srinivas Kandagatla
The NVMe regulator has been left enabled by the boot firmware. Mark it
as such to avoid disabling the regulator temporarily during boot.
Fixes: 45247fe17db2 ("arm64: dts: qcom: x1e80100: add Lenovo Thinkpad Yoga slim 7x devicetree")
Cc: stable@vger.kernel.org # 6.11
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
index 3c13331a9ef4..0cdaff9c8cf0 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
@@ -205,6 +205,8 @@ vreg_nvme: regulator-nvme {
pinctrl-0 = <&nvme_reg_en>;
pinctrl-names = "default";
+
+ regulator-boot-on;
};
};
--
2.45.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 5/6] arm64: dts: qcom: x1e80100-microsoft-romulus: fix nvme regulator boot glitch
2024-10-16 14:51 [PATCH 0/6] arm64: dts: qcom: x1e80100: fix nvme regulator boot glitch Johan Hovold
` (3 preceding siblings ...)
2024-10-16 14:51 ` [PATCH 4/6] arm64: dts: qcom: x1e80100-yoga-slim7x: " Johan Hovold
@ 2024-10-16 14:51 ` Johan Hovold
2024-10-16 14:51 ` [PATCH 6/6] arm64: dts: qcom: x1e80100-qcp: " Johan Hovold
` (3 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Johan Hovold @ 2024-10-16 14:51 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa,
linux-arm-msm, devicetree, linux-kernel, Johan Hovold,
Konrad Dybcio
The NVMe regulator has been left enabled by the boot firmware. Mark it
as such to avoid disabling the regulator temporarily during boot.
Fixes: 09d77be56093 ("arm64: dts: qcom: Add support for X1-based Surface Laptop 7 devices")
Cc: Konrad Dybcio <quic_kdybcio@quicinc.com>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi b/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi
index 42e02ad6a9c3..cdb401767c42 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi
@@ -164,6 +164,8 @@ vreg_nvme: regulator-nvme {
pinctrl-0 = <&nvme_reg_en>;
pinctrl-names = "default";
+
+ regulator-boot-on;
};
};
--
2.45.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH 6/6] arm64: dts: qcom: x1e80100-qcp: fix nvme regulator boot glitch
2024-10-16 14:51 [PATCH 0/6] arm64: dts: qcom: x1e80100: fix nvme regulator boot glitch Johan Hovold
` (4 preceding siblings ...)
2024-10-16 14:51 ` [PATCH 5/6] arm64: dts: qcom: x1e80100-microsoft-romulus: " Johan Hovold
@ 2024-10-16 14:51 ` Johan Hovold
2024-10-16 15:44 ` [PATCH 0/6] arm64: dts: qcom: x1e80100: " Stephan Gerhold
` (2 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Johan Hovold @ 2024-10-16 14:51 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa,
linux-arm-msm, devicetree, linux-kernel, Johan Hovold, stable
The NVMe regulator has been left enabled by the boot firmware. Mark it
as such to avoid disabling the regulator temporarily during boot.
Fixes: eb57cbe730d1 ("arm64: dts: qcom: x1e80100: Describe the PCIe 6a resources")
Cc: stable@vger.kernel.org # 6.11
Cc: Abel Vesa <abel.vesa@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
index 1c3a6a7b3ed6..5ef030c60abe 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts
@@ -253,6 +253,8 @@ vreg_nvme: regulator-nvme {
pinctrl-names = "default";
pinctrl-0 = <&nvme_reg_en>;
+
+ regulator-boot-on;
};
};
--
2.45.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 0/6] arm64: dts: qcom: x1e80100: fix nvme regulator boot glitch
2024-10-16 14:51 [PATCH 0/6] arm64: dts: qcom: x1e80100: fix nvme regulator boot glitch Johan Hovold
` (5 preceding siblings ...)
2024-10-16 14:51 ` [PATCH 6/6] arm64: dts: qcom: x1e80100-qcp: " Johan Hovold
@ 2024-10-16 15:44 ` Stephan Gerhold
2024-10-16 15:52 ` Aleksandrs Vinarskis
2024-10-18 0:33 ` Konrad Dybcio
2024-10-24 14:59 ` Bjorn Andersson
8 siblings, 1 reply; 11+ messages in thread
From: Stephan Gerhold @ 2024-10-16 15:44 UTC (permalink / raw)
To: Johan Hovold, Aleksandrs Vinarskis
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Abel Vesa, linux-arm-msm, devicetree, linux-kernel
On Wed, Oct 16, 2024 at 04:51:06PM +0200, Johan Hovold wrote:
> The NVMe regulator has been left enabled by the boot firmware. Mark it
> as such to avoid disabling the regulator temporarily during boot.
>
> Johan
These look good to me, thanks!
Can you or Aleksandrs send another one for the x1e80100-dell-xps13-9345
that was applied by Bjorn yesterday?
FWIW, for these patches:
Reviewed-by: Stephan Gerhold <stephan.gerhold@linaro.org>
>
>
> Johan Hovold (6):
> arm64: dts: qcom: x1e78100-t14s: fix nvme regulator boot glitch
> arm64: dts: qcom: x1e80100-crd: fix nvme regulator boot glitch
> arm64: dts: qcom: x1e80100-vivobook-s15: fix nvme regulator boot
> glitch
> arm64: dts: qcom: x1e80100-yoga-slim7x: fix nvme regulator boot glitch
> arm64: dts: qcom: x1e80100-microsoft-romulus: fix nvme regulator boot
> glitch
> arm64: dts: qcom: x1e80100-qcp: fix nvme regulator boot glitch
>
> arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts | 2 ++
> arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts | 2 ++
> arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 2 ++
> arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 2 ++
> arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi | 2 ++
> arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 2 ++
> 6 files changed, 12 insertions(+)
>
> --
> 2.45.2
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 0/6] arm64: dts: qcom: x1e80100: fix nvme regulator boot glitch
2024-10-16 15:44 ` [PATCH 0/6] arm64: dts: qcom: x1e80100: " Stephan Gerhold
@ 2024-10-16 15:52 ` Aleksandrs Vinarskis
0 siblings, 0 replies; 11+ messages in thread
From: Aleksandrs Vinarskis @ 2024-10-16 15:52 UTC (permalink / raw)
To: Stephan Gerhold
Cc: Johan Hovold, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Abel Vesa, linux-arm-msm,
devicetree, linux-kernel
On Wed, 16 Oct 2024 at 17:45, Stephan Gerhold
<stephan.gerhold@linaro.org> wrote:
>
> On Wed, Oct 16, 2024 at 04:51:06PM +0200, Johan Hovold wrote:
> > The NVMe regulator has been left enabled by the boot firmware. Mark it
> > as such to avoid disabling the regulator temporarily during boot.
> >
> > Johan
>
> These look good to me, thanks!
>
> Can you or Aleksandrs send another one for the x1e80100-dell-xps13-9345
> that was applied by Bjorn yesterday?
Hi,
Sure, will give it a quick test and mail it later tonight (along with
a few other fixes).
Alex
>
> FWIW, for these patches:
>
> Reviewed-by: Stephan Gerhold <stephan.gerhold@linaro.org>
>
> >
> >
> > Johan Hovold (6):
> > arm64: dts: qcom: x1e78100-t14s: fix nvme regulator boot glitch
> > arm64: dts: qcom: x1e80100-crd: fix nvme regulator boot glitch
> > arm64: dts: qcom: x1e80100-vivobook-s15: fix nvme regulator boot
> > glitch
> > arm64: dts: qcom: x1e80100-yoga-slim7x: fix nvme regulator boot glitch
> > arm64: dts: qcom: x1e80100-microsoft-romulus: fix nvme regulator boot
> > glitch
> > arm64: dts: qcom: x1e80100-qcp: fix nvme regulator boot glitch
> >
> > arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts | 2 ++
> > arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts | 2 ++
> > arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 2 ++
> > arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 2 ++
> > arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi | 2 ++
> > arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 2 ++
> > 6 files changed, 12 insertions(+)
> >
> > --
> > 2.45.2
> >
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/6] arm64: dts: qcom: x1e80100: fix nvme regulator boot glitch
2024-10-16 14:51 [PATCH 0/6] arm64: dts: qcom: x1e80100: fix nvme regulator boot glitch Johan Hovold
` (6 preceding siblings ...)
2024-10-16 15:44 ` [PATCH 0/6] arm64: dts: qcom: x1e80100: " Stephan Gerhold
@ 2024-10-18 0:33 ` Konrad Dybcio
2024-10-24 14:59 ` Bjorn Andersson
8 siblings, 0 replies; 11+ messages in thread
From: Konrad Dybcio @ 2024-10-18 0:33 UTC (permalink / raw)
To: Johan Hovold, Bjorn Andersson, Konrad Dybcio
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa,
linux-arm-msm, devicetree, linux-kernel
On 16.10.2024 4:51 PM, Johan Hovold wrote:
> The NVMe regulator has been left enabled by the boot firmware. Mark it
> as such to avoid disabling the regulator temporarily during boot.
>
> Johan
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 0/6] arm64: dts: qcom: x1e80100: fix nvme regulator boot glitch
2024-10-16 14:51 [PATCH 0/6] arm64: dts: qcom: x1e80100: fix nvme regulator boot glitch Johan Hovold
` (7 preceding siblings ...)
2024-10-18 0:33 ` Konrad Dybcio
@ 2024-10-24 14:59 ` Bjorn Andersson
8 siblings, 0 replies; 11+ messages in thread
From: Bjorn Andersson @ 2024-10-24 14:59 UTC (permalink / raw)
To: Konrad Dybcio, Johan Hovold
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa,
linux-arm-msm, devicetree, linux-kernel
On Wed, 16 Oct 2024 16:51:06 +0200, Johan Hovold wrote:
> The NVMe regulator has been left enabled by the boot firmware. Mark it
> as such to avoid disabling the regulator temporarily during boot.
>
> Johan
>
>
> Johan Hovold (6):
> arm64: dts: qcom: x1e78100-t14s: fix nvme regulator boot glitch
> arm64: dts: qcom: x1e80100-crd: fix nvme regulator boot glitch
> arm64: dts: qcom: x1e80100-vivobook-s15: fix nvme regulator boot
> glitch
> arm64: dts: qcom: x1e80100-yoga-slim7x: fix nvme regulator boot glitch
> arm64: dts: qcom: x1e80100-microsoft-romulus: fix nvme regulator boot
> glitch
> arm64: dts: qcom: x1e80100-qcp: fix nvme regulator boot glitch
>
> [...]
Applied, thanks!
[1/6] arm64: dts: qcom: x1e78100-t14s: fix nvme regulator boot glitch
commit: dec19f1406fc5d73512cacdcf612e7bb161c2101
[2/6] arm64: dts: qcom: x1e80100-crd: fix nvme regulator boot glitch
commit: 37f9477ce9d07ed87f6efe9b99de580bc9d27df5
[3/6] arm64: dts: qcom: x1e80100-vivobook-s15: fix nvme regulator boot glitch
commit: c6d151f61b6703124e14bc0eae98d05206e36e02
[4/6] arm64: dts: qcom: x1e80100-yoga-slim7x: fix nvme regulator boot glitch
commit: 1badd07e4c0e1ecfb187dcba05357c0f3e70e797
[5/6] arm64: dts: qcom: x1e80100-microsoft-romulus: fix nvme regulator boot glitch
commit: 5462190b11aa62a945dc2fd74e1531b9c1bc9952
[6/6] arm64: dts: qcom: x1e80100-qcp: fix nvme regulator boot glitch
commit: 717f0637ffc6a6a59f838df94a7d61e643c98d62
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread