* [PATCH v1 0/2] X1E Dell XPS 9345 Improvements 1
@ 2024-10-16 20:15 Aleksandrs Vinarskis
2024-10-16 20:15 ` [PATCH v1 1/2] arm64: dts: qcom: x1e80100-dell-xps13-9345: route edp-panel enable gpio Aleksandrs Vinarskis
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Aleksandrs Vinarskis @ 2024-10-16 20:15 UTC (permalink / raw)
To: Bjorn Andersson, linux-arm-msm, devicetree, linux-kernel
Cc: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bryan.Kemp, tudor.laurentiu.oss, tephan.gerhold, johan+linaro,
Aleksandrs Vinarskis
First round of improvements.
* Add experimentally discovered edp enable gpio. Drop panel info, as it is
now documented in [1]
* Add Johan Hovold's fix for nvme regulator
[1] https://lore.kernel.org/all/CAD=FV=Wu3vaY4Rtw4OZwgAf_b44JpDsKJhUa-EXiuu1hn3aJoQ@mail.gmail.com/
Aleksandrs Vinarskis (2):
arm64: dts: qcom: x1e80100-dell-xps13-9345: route edp-panel enable
gpio
arm64: dts: qcom: x1e80100-dell-xps13-9345: fix nvme regulator boot
glitch
.../boot/dts/qcom/x1e80100-dell-xps13-9345.dts | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
--
2.45.2
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v1 1/2] arm64: dts: qcom: x1e80100-dell-xps13-9345: route edp-panel enable gpio 2024-10-16 20:15 [PATCH v1 0/2] X1E Dell XPS 9345 Improvements 1 Aleksandrs Vinarskis @ 2024-10-16 20:15 ` Aleksandrs Vinarskis 2024-10-16 20:15 ` [PATCH v1 2/2] arm64: dts: qcom: x1e80100-dell-xps13-9345: fix nvme regulator boot glitch Aleksandrs Vinarskis ` (2 subsequent siblings) 3 siblings, 0 replies; 6+ messages in thread From: Aleksandrs Vinarskis @ 2024-10-16 20:15 UTC (permalink / raw) To: Bjorn Andersson, linux-arm-msm, devicetree, linux-kernel Cc: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bryan.Kemp, tudor.laurentiu.oss, tephan.gerhold, johan+linaro, Aleksandrs Vinarskis tlmm 74 was experimentally found to be panel enable pin, which shall be high for panel (both low-res IPS, OLED) to work. Define it as such. Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com> --- .../arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts index 6f78b61f8da3..93d90209060c 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts +++ b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts @@ -560,10 +560,13 @@ &mdss_dp3 { aux-bus { panel { - /* 1920x1200 IPS panel is SHP1593, PNP09FF compatible */ compatible = "edp-panel"; + enable-gpios = <&tlmm 74 GPIO_ACTIVE_HIGH>; power-supply = <&vreg_edp_3p3>; + pinctrl-0 = <&edp_bl_en>; + pinctrl-names = "default"; + port { edp_panel_in: endpoint { remote-endpoint = <&mdss_dp3_out>; @@ -677,6 +680,13 @@ cam_indicator_en: cam-indicator-en-state { bias-disable; }; + edp_bl_en: edp-bl-en-state { + pins = "gpio74"; + function = "gpio"; + drive-strength = <2>; + bias-disable; + }; + edp_reg_en: edp-reg-en-state { pins = "gpio70"; function = "gpio"; -- 2.45.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v1 2/2] arm64: dts: qcom: x1e80100-dell-xps13-9345: fix nvme regulator boot glitch 2024-10-16 20:15 [PATCH v1 0/2] X1E Dell XPS 9345 Improvements 1 Aleksandrs Vinarskis 2024-10-16 20:15 ` [PATCH v1 1/2] arm64: dts: qcom: x1e80100-dell-xps13-9345: route edp-panel enable gpio Aleksandrs Vinarskis @ 2024-10-16 20:15 ` Aleksandrs Vinarskis 2024-10-18 9:25 ` Johan Hovold 2024-10-17 16:26 ` [PATCH v1 0/2] X1E Dell XPS 9345 Improvements 1 Rob Herring (Arm) 2024-10-24 14:59 ` Bjorn Andersson 3 siblings, 1 reply; 6+ messages in thread From: Aleksandrs Vinarskis @ 2024-10-16 20:15 UTC (permalink / raw) To: Bjorn Andersson, linux-arm-msm, devicetree, linux-kernel Cc: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bryan.Kemp, tudor.laurentiu.oss, tephan.gerhold, johan+linaro, Aleksandrs Vinarskis The NVMe regulator has been left enabled by the boot firmware. Mark it as such to avoid disabling the regulator temporarily during boot. Based on https://lore.kernel.org/all/20241016145112.24785-1-johan+linaro@kernel.org/ Fixes: f5b788d0e8cd ("arm64: dts: qcom: Add support for X1-based Dell XPS 13 9345") Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com> --- arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts index 93d90209060c..05624226faf9 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts +++ b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts @@ -162,6 +162,8 @@ vreg_nvme: regulator-nvme { pinctrl-0 = <&nvme_reg_en>; pinctrl-names = "default"; + + regulator-boot-on; }; vreg_vph_pwr: regulator-vph-pwr { -- 2.45.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v1 2/2] arm64: dts: qcom: x1e80100-dell-xps13-9345: fix nvme regulator boot glitch 2024-10-16 20:15 ` [PATCH v1 2/2] arm64: dts: qcom: x1e80100-dell-xps13-9345: fix nvme regulator boot glitch Aleksandrs Vinarskis @ 2024-10-18 9:25 ` Johan Hovold 0 siblings, 0 replies; 6+ messages in thread From: Johan Hovold @ 2024-10-18 9:25 UTC (permalink / raw) To: Aleksandrs Vinarskis Cc: Bjorn Andersson, linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bryan.Kemp, tudor.laurentiu.oss, tephan.gerhold, johan+linaro On Wed, Oct 16, 2024 at 10:15:49PM +0200, Aleksandrs Vinarskis wrote: > The NVMe regulator has been left enabled by the boot firmware. Mark it > as such to avoid disabling the regulator temporarily during boot. > > Based on https://lore.kernel.org/all/20241016145112.24785-1-johan+linaro@kernel.org/ > > Fixes: f5b788d0e8cd ("arm64: dts: qcom: Add support for X1-based Dell XPS 13 9345") > Signed-off-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com> Reviewed-by: Johan Hovold <johan+linaro@kernel.org> Johan ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 0/2] X1E Dell XPS 9345 Improvements 1 2024-10-16 20:15 [PATCH v1 0/2] X1E Dell XPS 9345 Improvements 1 Aleksandrs Vinarskis 2024-10-16 20:15 ` [PATCH v1 1/2] arm64: dts: qcom: x1e80100-dell-xps13-9345: route edp-panel enable gpio Aleksandrs Vinarskis 2024-10-16 20:15 ` [PATCH v1 2/2] arm64: dts: qcom: x1e80100-dell-xps13-9345: fix nvme regulator boot glitch Aleksandrs Vinarskis @ 2024-10-17 16:26 ` Rob Herring (Arm) 2024-10-24 14:59 ` Bjorn Andersson 3 siblings, 0 replies; 6+ messages in thread From: Rob Herring (Arm) @ 2024-10-17 16:26 UTC (permalink / raw) To: Aleksandrs Vinarskis Cc: linux-arm-msm, devicetree, Conor Dooley, linux-kernel, Konrad Dybcio, johan+linaro, Krzysztof Kozlowski, tephan.gerhold, tudor.laurentiu.oss, Bryan.Kemp, Bjorn Andersson On Wed, 16 Oct 2024 22:15:47 +0200, Aleksandrs Vinarskis wrote: > First round of improvements. > > * Add experimentally discovered edp enable gpio. Drop panel info, as it is > now documented in [1] > * Add Johan Hovold's fix for nvme regulator > > [1] https://lore.kernel.org/all/CAD=FV=Wu3vaY4Rtw4OZwgAf_b44JpDsKJhUa-EXiuu1hn3aJoQ@mail.gmail.com/ > > Aleksandrs Vinarskis (2): > arm64: dts: qcom: x1e80100-dell-xps13-9345: route edp-panel enable > gpio > arm64: dts: qcom: x1e80100-dell-xps13-9345: fix nvme regulator boot > glitch > > .../boot/dts/qcom/x1e80100-dell-xps13-9345.dts | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > -- > 2.45.2 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y qcom/x1e80100-dell-xps13-9345.dtb' for 20241016202253.9677-1-alex.vinarskis@gmail.com: arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dtb: phy@1bfc000: resets: [[53, 37], [53, 36]] is too long from schema $id: http://devicetree.org/schemas/phy/qcom,sc8280xp-qmp-pcie-phy.yaml# arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dtb: phy@1bfc000: reset-names: ['phy', 'phy_nocsr'] is too long from schema $id: http://devicetree.org/schemas/phy/qcom,sc8280xp-qmp-pcie-phy.yaml# arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dtb: phy@1c06000: clocks: [[53, 107], [53, 109], [33, 1], [53, 111], [53, 113], [53, 115]] is too long from schema $id: http://devicetree.org/schemas/phy/qcom,sc8280xp-qmp-pcie-phy.yaml# arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dtb: phy@1c06000: clock-names: ['aux', 'cfg_ahb', 'ref', 'rchng', 'pipe', 'pipediv2'] is too long from schema $id: http://devicetree.org/schemas/phy/qcom,sc8280xp-qmp-pcie-phy.yaml# arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dtb: phy@1c0e000: clocks: [[53, 96], [53, 98], [33, 0], [53, 100], [53, 102], [53, 104]] is too long from schema $id: http://devicetree.org/schemas/phy/qcom,sc8280xp-qmp-pcie-phy.yaml# arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dtb: phy@1c0e000: clock-names: ['aux', 'cfg_ahb', 'ref', 'rchng', 'pipe', 'pipediv2'] is too long from schema $id: http://devicetree.org/schemas/phy/qcom,sc8280xp-qmp-pcie-phy.yaml# arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dtb: usb@a2f8800: interrupt-names: ['pwr_event', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml# arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dtb: system-cache-controller@25000000: reg: [[0, 620756992, 0, 2097152], [0, 622854144, 0, 2097152], [0, 624951296, 0, 2097152], [0, 627048448, 0, 2097152], [0, 629145600, 0, 2097152], [0, 631242752, 0, 2097152], [0, 633339904, 0, 2097152], [0, 635437056, 0, 2097152], [0, 637534208, 0, 2097152], [0, 639631360, 0, 2097152]] is too long from schema $id: http://devicetree.org/schemas/cache/qcom,llcc.yaml# arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dtb: system-cache-controller@25000000: reg-names: ['llcc0_base', 'llcc1_base', 'llcc2_base', 'llcc3_base', 'llcc4_base', 'llcc5_base', 'llcc6_base', 'llcc7_base', 'llcc_broadcast_base', 'llcc_broadcast_and_base'] is too long from schema $id: http://devicetree.org/schemas/cache/qcom,llcc.yaml# arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dtb: system-cache-controller@25000000: reg: [[0, 620756992, 0, 2097152], [0, 622854144, 0, 2097152], [0, 624951296, 0, 2097152], [0, 627048448, 0, 2097152], [0, 629145600, 0, 2097152], [0, 631242752, 0, 2097152], [0, 633339904, 0, 2097152], [0, 635437056, 0, 2097152], [0, 637534208, 0, 2097152], [0, 639631360, 0, 2097152]] is too long from schema $id: http://devicetree.org/schemas/cache/qcom,llcc.yaml# arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dtb: system-cache-controller@25000000: reg-names: ['llcc0_base', 'llcc1_base', 'llcc2_base', 'llcc3_base', 'llcc4_base', 'llcc5_base', 'llcc6_base', 'llcc7_base', 'llcc_broadcast_base', 'llcc_broadcast_and_base'] is too long from schema $id: http://devicetree.org/schemas/cache/qcom,llcc.yaml# ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v1 0/2] X1E Dell XPS 9345 Improvements 1 2024-10-16 20:15 [PATCH v1 0/2] X1E Dell XPS 9345 Improvements 1 Aleksandrs Vinarskis ` (2 preceding siblings ...) 2024-10-17 16:26 ` [PATCH v1 0/2] X1E Dell XPS 9345 Improvements 1 Rob Herring (Arm) @ 2024-10-24 14:59 ` Bjorn Andersson 3 siblings, 0 replies; 6+ messages in thread From: Bjorn Andersson @ 2024-10-24 14:59 UTC (permalink / raw) To: linux-arm-msm, devicetree, linux-kernel, Aleksandrs Vinarskis Cc: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bryan.Kemp, tudor.laurentiu.oss, tephan.gerhold, johan+linaro On Wed, 16 Oct 2024 22:15:47 +0200, Aleksandrs Vinarskis wrote: > First round of improvements. > > * Add experimentally discovered edp enable gpio. Drop panel info, as it is > now documented in [1] > * Add Johan Hovold's fix for nvme regulator > > [1] https://lore.kernel.org/all/CAD=FV=Wu3vaY4Rtw4OZwgAf_b44JpDsKJhUa-EXiuu1hn3aJoQ@mail.gmail.com/ > > [...] Applied, thanks! [1/2] arm64: dts: qcom: x1e80100-dell-xps13-9345: route edp-panel enable gpio commit: 4e9b7787f80ae366f8a62a5a28955e134e522cc8 [2/2] arm64: dts: qcom: x1e80100-dell-xps13-9345: fix nvme regulator boot glitch commit: 06d6fe987bda731b7c6619495aebedf638d37f2d Best regards, -- Bjorn Andersson <andersson@kernel.org> ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-10-24 14:59 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-10-16 20:15 [PATCH v1 0/2] X1E Dell XPS 9345 Improvements 1 Aleksandrs Vinarskis 2024-10-16 20:15 ` [PATCH v1 1/2] arm64: dts: qcom: x1e80100-dell-xps13-9345: route edp-panel enable gpio Aleksandrs Vinarskis 2024-10-16 20:15 ` [PATCH v1 2/2] arm64: dts: qcom: x1e80100-dell-xps13-9345: fix nvme regulator boot glitch Aleksandrs Vinarskis 2024-10-18 9:25 ` Johan Hovold 2024-10-17 16:26 ` [PATCH v1 0/2] X1E Dell XPS 9345 Improvements 1 Rob Herring (Arm) 2024-10-24 14:59 ` Bjorn Andersson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox