Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Jishnu Prakash <quic_jprakash@quicinc.com>,
	jic23@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	agross@kernel.org, andersson@kernel.org,
	dmitry.baryshkov@linaro.org, konrad.dybcio@linaro.org,
	daniel.lezcano@linaro.org, sboyd@kernel.org,
	quic_subbaram@quicinc.com, quic_collinsd@quicinc.com,
	quic_amelende@quicinc.com, quic_kamalw@quicinc.com,
	amitk@kernel.org
Cc: oe-kbuild-all@lists.linux.dev, lee@kernel.org, rafael@kernel.org,
	rui.zhang@intel.com, lukasz.luba@arm.com, lars@metafoo.de,
	quic_skakitap@quicinc.com, neil.armstrong@linaro.org,
	devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, cros-qcom-dts-watchers@chromium.org,
	Jishnu Prakash <quic_jprakash@quicinc.com>
Subject: Re: [PATCH V4 3/4] iio: adc: Add support for QCOM PMIC5 Gen3 ADC
Date: Sat, 2 Nov 2024 18:46:53 +0800	[thread overview]
Message-ID: <202411021830.6iNtNN1E-lkp@intel.com> (raw)
In-Reply-To: <20241030185854.4015348-4-quic_jprakash@quicinc.com>

Hi Jishnu,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 6fb2fa9805c501d9ade047fc511961f3273cdcb5]

url:    https://github.com/intel-lab-lkp/linux/commits/Jishnu-Prakash/dt-bindings-iio-adc-Move-QCOM-ADC-bindings-to-iio-adc-folder/20241031-030237
base:   6fb2fa9805c501d9ade047fc511961f3273cdcb5
patch link:    https://lore.kernel.org/r/20241030185854.4015348-4-quic_jprakash%40quicinc.com
patch subject: [PATCH V4 3/4] iio: adc: Add support for QCOM PMIC5 Gen3 ADC
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20241102/202411021830.6iNtNN1E-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241102/202411021830.6iNtNN1E-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411021830.6iNtNN1E-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/iio/adc/qcom-spmi-adc5-gen3.c:31: warning: Cannot understand  * @adc_tm: indicates TM type if the channel is used for TM measurements.
    on line 31 - I thought it was a doc line
>> drivers/iio/adc/qcom-spmi-adc5-gen3.c:70: warning: Function parameter or struct member 'dev_data' not described in 'adc5_chip'
>> drivers/iio/adc/qcom-spmi-adc5-gen3.c:70: warning: Function parameter or struct member 'tm_aux' not described in 'adc5_chip'


vim +31 drivers/iio/adc/qcom-spmi-adc5-gen3.c

    29	
    30	/**
  > 31	 * @adc_tm: indicates TM type if the channel is used for TM measurements.
    32	 * @chip: pointer to top-level ADC device structure.
    33	 */
    34	
    35	struct adc5_channel_prop {
    36		struct adc5_channel_common_prop common_props;
    37		int				adc_tm;
    38		struct adc5_chip		*chip;
    39	};
    40	
    41	/**
    42	 * struct adc5_chip - ADC private structure.
    43	 * @dev: SPMI ADC5 Gen3 device.
    44	 * @num_sdams: number of SDAMs (Shared Direct Access Memory Module) being used.
    45	 * @nchannels: number of ADC channels.
    46	 * @chan_props: array of ADC channel properties.
    47	 * @iio_chans: array of IIO channels specification.
    48	 * @complete: ADC result notification after interrupt is received.
    49	 * @lock: ADC lock for access to the peripheral, to prevent concurrent
    50	 * requests from multiple clients.
    51	 * @n_tm_channels: number of ADC channels used for TM measurements.
    52	 * @data: software configuration data.
    53	 */
    54	struct adc5_chip {
    55		struct device			*dev;
    56		struct adc5_device_data	dev_data;
    57		unsigned int			num_sdams;
    58		unsigned int			nchannels;
    59		struct adc5_channel_prop	*chan_props;
    60		struct iio_chan_spec		*iio_chans;
    61		struct completion		complete;
    62		/*
    63		 * lock for access to the peripheral, to prevent concurrent
    64		 * requests from multiple clients.
    65		 */
    66		struct mutex			lock;
    67		const struct adc5_data		*data;
    68		unsigned int			n_tm_channels;
    69		struct auxiliary_device		*tm_aux;
  > 70	};
    71	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  parent reply	other threads:[~2024-11-02 10:47 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30 18:58 [PATCH V4 0/4] Add support for QCOM SPMI PMIC5 Gen3 ADC Jishnu Prakash
2024-10-30 18:58 ` [PATCH V4 1/4] dt-bindings: iio/adc: Move QCOM ADC bindings to iio/adc folder Jishnu Prakash
2024-10-30 20:20   ` Rob Herring (Arm)
2024-11-04 10:21     ` Jishnu Prakash
2024-10-30 18:58 ` [PATCH V4 2/4] dt-bindings: iio: adc: Add support for QCOM PMIC5 Gen3 ADC Jishnu Prakash
2024-10-30 20:20   ` Rob Herring (Arm)
2024-10-31 10:58   ` Krzysztof Kozlowski
2024-11-13 14:05     ` Jishnu Prakash
2024-11-19  9:02       ` Krzysztof Kozlowski
2024-12-10  6:05         ` Jishnu Prakash
2024-10-31 17:57   ` Dmitry Baryshkov
2024-11-13 14:06     ` Jishnu Prakash
2024-11-15 16:44       ` Dmitry Baryshkov
2024-12-10  6:04         ` Jishnu Prakash
2024-10-30 18:58 ` [PATCH V4 3/4] " Jishnu Prakash
2024-10-31 11:03   ` Krzysztof Kozlowski
2024-11-13 14:06     ` Jishnu Prakash
2024-11-19  9:04       ` Krzysztof Kozlowski
2024-11-02 10:46   ` kernel test robot [this message]
2024-10-30 18:58 ` [PATCH V4 4/4] thermal: qcom: add support for PMIC5 Gen3 ADC thermal monitoring Jishnu Prakash
2024-10-31 11:00   ` Krzysztof Kozlowski
2024-11-13 14:06     ` Jishnu Prakash
2024-11-02 11:07   ` kernel test robot
2024-11-02 11:39   ` kernel test robot
2024-10-31  7:36 ` [PATCH V4 0/4] Add support for QCOM SPMI PMIC5 Gen3 ADC Krzysztof Kozlowski
2024-11-13 14:07   ` Jishnu Prakash

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202411021830.6iNtNN1E-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=agross@kernel.org \
    --cc=amitk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=cros-qcom-dts-watchers@chromium.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=jic23@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=lee@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=neil.armstrong@linaro.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=quic_amelende@quicinc.com \
    --cc=quic_collinsd@quicinc.com \
    --cc=quic_jprakash@quicinc.com \
    --cc=quic_kamalw@quicinc.com \
    --cc=quic_skakitap@quicinc.com \
    --cc=quic_subbaram@quicinc.com \
    --cc=rafael@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox