From: Krishna chaitanya chundru <quic_krichai@quicinc.com>
To: "Jingoo Han" <jingoohan1@gmail.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Konrad Dybcio" <konradybcio@kernel.org>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
andersson@kernel.org, quic_vbadigan@quicinc.com,
quic_mrana@quicinc.com,
"Krishna chaitanya chundru" <quic_krichai@quicinc.com>
Subject: [PATCH v5 1/3] PCI: dwc: Skip waiting for link up if vendor drivers can detect Link up event
Date: Sat, 23 Nov 2024 00:39:59 +0530 [thread overview]
Message-ID: <20241123-remove_wait2-v5-1-b5f9e6b794c2@quicinc.com> (raw)
In-Reply-To: <20241123-remove_wait2-v5-0-b5f9e6b794c2@quicinc.com>
If the vendor drivers can detect the Link up event using mechanisms
such as Link up IRQ and if the driver can enumerate downstream devices
instead of waiting here, then waiting for Link up during probe is not
needed here, which optimizes the boot time.
So skip waiting for link to be up if the driver supports 'use_linkup_irq'.
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>
---
drivers/pci/controller/dwc/pcie-designware-host.c | 10 ++++++++--
drivers/pci/controller/dwc/pcie-designware.h | 1 +
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
index d2291c3ceb8b..cc172255d3b6 100644
--- a/drivers/pci/controller/dwc/pcie-designware-host.c
+++ b/drivers/pci/controller/dwc/pcie-designware-host.c
@@ -530,8 +530,14 @@ int dw_pcie_host_init(struct dw_pcie_rp *pp)
goto err_remove_edma;
}
- /* Ignore errors, the link may come up later */
- dw_pcie_wait_for_link(pci);
+ /*
+ * Note: The link up delay is skipped only when a link up IRQ is present.
+ * This flag should not be used to bypass the link up delay for arbitrary
+ * reasons.
+ */
+ if (!pp->use_linkup_irq)
+ /* Ignore errors, the link may come up later */
+ dw_pcie_wait_for_link(pci);
bridge->sysdata = pp;
diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h
index 347ab74ac35a..1d0ec47e1986 100644
--- a/drivers/pci/controller/dwc/pcie-designware.h
+++ b/drivers/pci/controller/dwc/pcie-designware.h
@@ -379,6 +379,7 @@ struct dw_pcie_rp {
bool use_atu_msg;
int msg_atu_index;
struct resource *msg_res;
+ bool use_linkup_irq;
};
struct dw_pcie_ep_ops {
--
2.34.1
next prev parent reply other threads:[~2024-11-22 19:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-22 19:09 [PATCH v5 0/3] PCI: dwc: Skip waiting for link up if vendor drivers can detect Link up event Krishna chaitanya chundru
2024-11-22 19:09 ` Krishna chaitanya chundru [this message]
2024-11-22 19:10 ` [PATCH v5 2/3] PCI: qcom: Set use_linkup_irq if global IRQ handler is present Krishna chaitanya chundru
2024-11-22 19:10 ` [PATCH v5 3/3] PCI: qcom: Update ICC and OPP values during link up event Krishna chaitanya chundru
2024-12-23 6:55 ` [PATCH v5 0/3] PCI: dwc: Skip waiting for link up if vendor drivers can detect Link " Krishna Chaitanya Chundru
2025-01-16 1:57 ` Krzysztof Wilczyński
2025-01-02 16:42 ` Niklas Cassel
2025-01-15 11:19 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241123-remove_wait2-v5-1-b5f9e6b794c2@quicinc.com \
--to=quic_krichai@quicinc.com \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=jingoohan1@gmail.com \
--cc=konradybcio@kernel.org \
--cc=kw@linux.com \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_mrana@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox