From: Krishna chaitanya chundru <quic_krichai@quicinc.com>
To: "Jingoo Han" <jingoohan1@gmail.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Konrad Dybcio" <konradybcio@kernel.org>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
andersson@kernel.org, quic_vbadigan@quicinc.com,
quic_mrana@quicinc.com,
"Krishna chaitanya chundru" <quic_krichai@quicinc.com>
Subject: [PATCH v5 2/3] PCI: qcom: Set use_linkup_irq if global IRQ handler is present
Date: Sat, 23 Nov 2024 00:40:00 +0530 [thread overview]
Message-ID: <20241123-remove_wait2-v5-2-b5f9e6b794c2@quicinc.com> (raw)
In-Reply-To: <20241123-remove_wait2-v5-0-b5f9e6b794c2@quicinc.com>
In cases where a global IRQ handler is present to manage link up
interrupts, it may not be necessary to wait for the link to be up
during PCI initialization which optimizes the bootup time.
So, set use_linkup_irq flag if global IRQ is present and in order to set
the use_linkup_irq flag before calling dw_pcie_host_init() call, which
waits for link to be up, move platform_get_irq_byname_optional() API
above dw_pcie_host_init().
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>
---
drivers/pci/controller/dwc/pcie-qcom.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
index dc102d8bd58c..656d2be9d87f 100644
--- a/drivers/pci/controller/dwc/pcie-qcom.c
+++ b/drivers/pci/controller/dwc/pcie-qcom.c
@@ -1703,6 +1703,10 @@ static int qcom_pcie_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, pcie);
+ irq = platform_get_irq_byname_optional(pdev, "global");
+ if (irq > 0)
+ pp->use_linkup_irq = true;
+
ret = dw_pcie_host_init(pp);
if (ret) {
dev_err(dev, "cannot initialize host\n");
@@ -1716,7 +1720,6 @@ static int qcom_pcie_probe(struct platform_device *pdev)
goto err_host_deinit;
}
- irq = platform_get_irq_byname_optional(pdev, "global");
if (irq > 0) {
ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
qcom_pcie_global_irq_thread,
--
2.34.1
next prev parent reply other threads:[~2024-11-22 19:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-22 19:09 [PATCH v5 0/3] PCI: dwc: Skip waiting for link up if vendor drivers can detect Link up event Krishna chaitanya chundru
2024-11-22 19:09 ` [PATCH v5 1/3] " Krishna chaitanya chundru
2024-11-22 19:10 ` Krishna chaitanya chundru [this message]
2024-11-22 19:10 ` [PATCH v5 3/3] PCI: qcom: Update ICC and OPP values during link " Krishna chaitanya chundru
2024-12-23 6:55 ` [PATCH v5 0/3] PCI: dwc: Skip waiting for link up if vendor drivers can detect Link " Krishna Chaitanya Chundru
2025-01-16 1:57 ` Krzysztof Wilczyński
2025-01-02 16:42 ` Niklas Cassel
2025-01-15 11:19 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241123-remove_wait2-v5-2-b5f9e6b794c2@quicinc.com \
--to=quic_krichai@quicinc.com \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=jingoohan1@gmail.com \
--cc=konradybcio@kernel.org \
--cc=kw@linux.com \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_mrana@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox