* [PATCH] bus: mhi: host: Enable MSIx if the endpoint supports
@ 2025-01-06 4:47 Vivek Pernamitta
2025-01-06 14:51 ` Manivannan Sadhasivam
0 siblings, 1 reply; 2+ messages in thread
From: Vivek Pernamitta @ 2025-01-06 4:47 UTC (permalink / raw)
To: Manivannan Sadhasivam; +Cc: mhi, linux-arm-msm, linux-kernel, Vivek Pernamitta
Enable MSIx if the end point supports.
Signed-off-by: Vivek Pernamitta <quic_vpernami@quicinc.com>
---
Enable MSIx if the endpoint supports.
---
drivers/bus/mhi/host/pci_generic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
index 56ba4192c89c16b4882d2e7c95f0dc689fd1e267..af1380220904a7e6232ff1b374da0a4ea49cb470 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -949,7 +949,7 @@ static int mhi_pci_get_irqs(struct mhi_controller *mhi_cntrl,
*/
mhi_cntrl->nr_irqs = 1 + mhi_cntrl_config->num_events;
- nr_vectors = pci_alloc_irq_vectors(pdev, 1, mhi_cntrl->nr_irqs, PCI_IRQ_MSI);
+ nr_vectors = pci_alloc_irq_vectors(pdev, 1, mhi_cntrl->nr_irqs, PCI_IRQ_MSIX | PCI_IRQ_MSI);
if (nr_vectors < 0) {
dev_err(&pdev->dev, "Error allocating MSI vectors %d\n",
nr_vectors);
---
base-commit: 8155b4ef3466f0e289e8fcc9e6e62f3f4dceeac2
change-id: 20250106-msix-a4c5488ecafe
Best regards,
--
Vivek Pernamitta <quic_vpernami@quicinc.com>
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] bus: mhi: host: Enable MSIx if the endpoint supports
2025-01-06 4:47 [PATCH] bus: mhi: host: Enable MSIx if the endpoint supports Vivek Pernamitta
@ 2025-01-06 14:51 ` Manivannan Sadhasivam
0 siblings, 0 replies; 2+ messages in thread
From: Manivannan Sadhasivam @ 2025-01-06 14:51 UTC (permalink / raw)
To: Vivek Pernamitta; +Cc: mhi, linux-arm-msm, linux-kernel
On Mon, Jan 06, 2025 at 10:17:33AM +0530, Vivek Pernamitta wrote:
> Enable MSIx if the end point supports.
>
s/MSIx/MSI-X
s/end point/endpoint
> Signed-off-by: Vivek Pernamitta <quic_vpernami@quicinc.com>
> ---
> Enable MSIx if the endpoint supports.
No need of the comment here.
Change LGTM!
- Mani
> ---
> drivers/bus/mhi/host/pci_generic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 56ba4192c89c16b4882d2e7c95f0dc689fd1e267..af1380220904a7e6232ff1b374da0a4ea49cb470 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -949,7 +949,7 @@ static int mhi_pci_get_irqs(struct mhi_controller *mhi_cntrl,
> */
> mhi_cntrl->nr_irqs = 1 + mhi_cntrl_config->num_events;
>
> - nr_vectors = pci_alloc_irq_vectors(pdev, 1, mhi_cntrl->nr_irqs, PCI_IRQ_MSI);
> + nr_vectors = pci_alloc_irq_vectors(pdev, 1, mhi_cntrl->nr_irqs, PCI_IRQ_MSIX | PCI_IRQ_MSI);
> if (nr_vectors < 0) {
> dev_err(&pdev->dev, "Error allocating MSI vectors %d\n",
> nr_vectors);
>
> ---
> base-commit: 8155b4ef3466f0e289e8fcc9e6e62f3f4dceeac2
> change-id: 20250106-msix-a4c5488ecafe
>
> Best regards,
> --
> Vivek Pernamitta <quic_vpernami@quicinc.com>
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-06 14:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-06 4:47 [PATCH] bus: mhi: host: Enable MSIx if the endpoint supports Vivek Pernamitta
2025-01-06 14:51 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox