Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: "James A. MacInnes" <james.a.macinnes@gmail.com>
To: Rob Clark <robdclark@gmail.com>,
	 Abhinav Kumar <quic_abhinavk@quicinc.com>,
	 Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Sean Paul <sean@poorly.run>,
	 Marijn Suijten <marijn.suijten@somainline.org>,
	 David Airlie <airlied@gmail.com>,
	Simona Vetter <simona@ffwll.ch>,
	 Chandan Uddaraju <chandanu@codeaurora.org>,
	 Stephen Boyd <swboyd@chromium.org>,
	Vara Reddy <quic_varar@quicinc.com>,
	 Tanmay Shah <tanmay@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	 freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	 Guenter Roeck <groeck@chromium.org>,
	Rob Clark <robdclark@chromium.org>,
	 "James A. MacInnes" <james.a.macinnes@gmail.com>
Subject: [PATCH v2 0/2] drm/msm/dp: Fix Type-C Timing
Date: Wed, 12 Feb 2025 15:03:45 -0800	[thread overview]
Message-ID: <20250212-sdm845_dp-v2-0-4954e51458f4@gmail.com> (raw)

SDM845 Type-C DisplayPort output inactive on DP Monitor and tears on HDMI.

During testing and research found that the dp and dpu drivers more
closely match later incarnations of the Android driver.
Compared against the 4.9 Android and found the porch timing and
wide bus elements were disabled.
Tested by commenting out code and the graphical glitches on
HDMI improved.
Fully turning off wide_bus resolved the single vertical line and
vblank errors when using non-native resolutions.
Removing the porch adjustment fixed HDMI and DisplayPort operated
correctly (for the first time) for all monitor supported resolutions.

Changes v1:
- Patch 1/2: Separated the descriptor from the sc7180 and turned off
             wide_bus support.
- Patch 2/2: Removed porch timing adjustment.

Changes v2:
- Patch 1/2: Removed unneeded assignment.
             Increased verbosity of commit message.
- Patch 2/2: Added comments to explain use of wide_bus_en.
             Increased verbosity of commit message.

Verified functionality on SDM845 using Lantronix SOM.
Tested with Type-C to DisplayPort and Dell Monitor.
Tested with Type-C hub with HDMI to Samsung 4k TV.

James A. MacInnes (2):
  drm/msm/dp: Disable wide bus support for SDM845
  drm/msm/disp: Correct porch timing for SDM845

 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 8 ++++----
 drivers/gpu/drm/msm/dp/dp_display.c                  | 7 ++++++-
 2 files changed, 10 insertions(+), 5 deletions(-)

--
2.43.0

---
James A. MacInnes (2):
      drm/msm/dp: Disable wide bus support for SDM845
      drm/msm/disp: Correct porch timing for SDM845

 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 14 +++++++++-----
 drivers/gpu/drm/msm/dp/dp_display.c                  |  7 ++++++-
 2 files changed, 15 insertions(+), 6 deletions(-)
---
base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04
change-id: 20250212-sdm845_dp-6ed993977a53

Best regards,
-- 
James A. MacInnes <james.a.macinnes@gmail.com>


             reply	other threads:[~2025-02-12 23:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-12 23:03 James A. MacInnes [this message]
2025-02-12 23:03 ` [PATCH v2 1/2] drm/msm/dp: Disable wide bus support for SDM845 James A. MacInnes
2025-02-12 23:41   ` Marijn Suijten
2025-02-12 23:58     ` Dmitry Baryshkov
2025-02-27 16:46       ` James A. MacInnes
2025-02-13  3:03     ` Abhinav Kumar
2025-02-12 23:03 ` [PATCH v2 2/2] drm/msm/disp: Correct porch timing " James A. MacInnes
2025-02-13  0:04   ` Dmitry Baryshkov
2025-02-13  3:23     ` Abhinav Kumar
2025-06-08 22:35   ` Dmitry Baryshkov
2025-06-08 22:35   ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250212-sdm845_dp-v2-0-4954e51458f4@gmail.com \
    --to=james.a.macinnes@gmail.com \
    --cc=airlied@gmail.com \
    --cc=chandanu@codeaurora.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=groeck@chromium.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_varar@quicinc.com \
    --cc=robdclark@chromium.org \
    --cc=robdclark@gmail.com \
    --cc=sean@poorly.run \
    --cc=simona@ffwll.ch \
    --cc=swboyd@chromium.org \
    --cc=tanmay@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox