* [PATCH] soundwire: qcom: demote probe registration printk
@ 2025-05-23 8:53 Johan Hovold
2025-05-23 17:27 ` Dmitry Baryshkov
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Johan Hovold @ 2025-05-23 8:53 UTC (permalink / raw)
To: Vinod Koul, Bard Liao
Cc: Pierre-Louis Bossart, Sanyog Kale, linux-arm-msm, linux-sound,
linux-kernel, Johan Hovold
Driver should generally by quiet on successful probe.
Demote the Qualcomm controller registration info message to debug level
to make boot logs a little less noisy:
qcom-soundwire 6ab0000.soundwire: Qualcomm Soundwire controller v2.0.0 Registered
qcom-soundwire 6ad0000.soundwire: Qualcomm Soundwire controller v2.0.0 Registered
qcom-soundwire 6b10000.soundwire: Qualcomm Soundwire controller v2.0.0 Registered
qcom-soundwire 6d30000.soundwire: Qualcomm Soundwire controller v2.0.0 Registered
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
drivers/soundwire/qcom.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index 295a46dc2be7..3265c39e6b51 100644
--- a/drivers/soundwire/qcom.c
+++ b/drivers/soundwire/qcom.c
@@ -1648,9 +1648,9 @@ static int qcom_swrm_probe(struct platform_device *pdev)
if (ret)
goto err_master_add;
- dev_info(dev, "Qualcomm Soundwire controller v%x.%x.%x Registered\n",
- (ctrl->version >> 24) & 0xff, (ctrl->version >> 16) & 0xff,
- ctrl->version & 0xffff);
+ dev_dbg(dev, "Qualcomm Soundwire controller v%x.%x.%x registered\n",
+ (ctrl->version >> 24) & 0xff, (ctrl->version >> 16) & 0xff,
+ ctrl->version & 0xffff);
pm_runtime_set_autosuspend_delay(dev, 3000);
pm_runtime_use_autosuspend(dev);
--
2.49.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] soundwire: qcom: demote probe registration printk
2025-05-23 8:53 [PATCH] soundwire: qcom: demote probe registration printk Johan Hovold
@ 2025-05-23 17:27 ` Dmitry Baryshkov
2025-06-09 12:12 ` Srinivas Kandagatla
2025-06-09 16:17 ` Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2025-05-23 17:27 UTC (permalink / raw)
To: Johan Hovold
Cc: Vinod Koul, Bard Liao, Pierre-Louis Bossart, Sanyog Kale,
linux-arm-msm, linux-sound, linux-kernel
On Fri, May 23, 2025 at 10:53:17AM +0200, Johan Hovold wrote:
> Driver should generally by quiet on successful probe.
>
> Demote the Qualcomm controller registration info message to debug level
> to make boot logs a little less noisy:
>
> qcom-soundwire 6ab0000.soundwire: Qualcomm Soundwire controller v2.0.0 Registered
> qcom-soundwire 6ad0000.soundwire: Qualcomm Soundwire controller v2.0.0 Registered
> qcom-soundwire 6b10000.soundwire: Qualcomm Soundwire controller v2.0.0 Registered
> qcom-soundwire 6d30000.soundwire: Qualcomm Soundwire controller v2.0.0 Registered
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
> drivers/soundwire/qcom.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soundwire: qcom: demote probe registration printk
2025-05-23 8:53 [PATCH] soundwire: qcom: demote probe registration printk Johan Hovold
2025-05-23 17:27 ` Dmitry Baryshkov
@ 2025-06-09 12:12 ` Srinivas Kandagatla
2025-06-09 16:17 ` Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Srinivas Kandagatla @ 2025-06-09 12:12 UTC (permalink / raw)
To: Johan Hovold, Vinod Koul, Bard Liao
Cc: Pierre-Louis Bossart, Sanyog Kale, linux-arm-msm, linux-sound,
linux-kernel
On 5/23/25 9:53 AM, Johan Hovold wrote:
> Driver should generally by quiet on successful probe.
>
> Demote the Qualcomm controller registration info message to debug level
> to make boot logs a little less noisy:
>
> qcom-soundwire 6ab0000.soundwire: Qualcomm Soundwire controller v2.0.0 Registered
> qcom-soundwire 6ad0000.soundwire: Qualcomm Soundwire controller v2.0.0 Registered
> qcom-soundwire 6b10000.soundwire: Qualcomm Soundwire controller v2.0.0 Registered
> qcom-soundwire 6d30000.soundwire: Qualcomm Soundwire controller v2.0.0 Registered
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
Acked-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
--srini
> drivers/soundwire/qcom.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
> index 295a46dc2be7..3265c39e6b51 100644
> --- a/drivers/soundwire/qcom.c
> +++ b/drivers/soundwire/qcom.c
> @@ -1648,9 +1648,9 @@ static int qcom_swrm_probe(struct platform_device *pdev)
> if (ret)
> goto err_master_add;
>
> - dev_info(dev, "Qualcomm Soundwire controller v%x.%x.%x Registered\n",
> - (ctrl->version >> 24) & 0xff, (ctrl->version >> 16) & 0xff,
> - ctrl->version & 0xffff);
> + dev_dbg(dev, "Qualcomm Soundwire controller v%x.%x.%x registered\n",
> + (ctrl->version >> 24) & 0xff, (ctrl->version >> 16) & 0xff,
> + ctrl->version & 0xffff);
>
> pm_runtime_set_autosuspend_delay(dev, 3000);
> pm_runtime_use_autosuspend(dev);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soundwire: qcom: demote probe registration printk
2025-05-23 8:53 [PATCH] soundwire: qcom: demote probe registration printk Johan Hovold
2025-05-23 17:27 ` Dmitry Baryshkov
2025-06-09 12:12 ` Srinivas Kandagatla
@ 2025-06-09 16:17 ` Vinod Koul
2 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2025-06-09 16:17 UTC (permalink / raw)
To: Bard Liao, Johan Hovold
Cc: Pierre-Louis Bossart, Sanyog Kale, linux-arm-msm, linux-sound,
linux-kernel
On Fri, 23 May 2025 10:53:17 +0200, Johan Hovold wrote:
> Driver should generally by quiet on successful probe.
>
> Demote the Qualcomm controller registration info message to debug level
> to make boot logs a little less noisy:
>
> qcom-soundwire 6ab0000.soundwire: Qualcomm Soundwire controller v2.0.0 Registered
> qcom-soundwire 6ad0000.soundwire: Qualcomm Soundwire controller v2.0.0 Registered
> qcom-soundwire 6b10000.soundwire: Qualcomm Soundwire controller v2.0.0 Registered
> qcom-soundwire 6d30000.soundwire: Qualcomm Soundwire controller v2.0.0 Registered
>
> [...]
Applied, thanks!
[1/1] soundwire: qcom: demote probe registration printk
commit: 5b8c1f39b5e46505cf9cf7775759a9e9c2bfc2d9
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-06-09 16:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-23 8:53 [PATCH] soundwire: qcom: demote probe registration printk Johan Hovold
2025-05-23 17:27 ` Dmitry Baryshkov
2025-06-09 12:12 ` Srinivas Kandagatla
2025-06-09 16:17 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox