From: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
To: Rob Clark <robin.clark@oss.qualcomm.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Jessica Zhang <jesszhan0024@gmail.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Kuogee Hsieh <quic_khsieh@quicinc.com>,
Yongxing Mou <yongxing.mou@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Jessica Zhang <jessica.zhang@oss.qualcomm.com>
Subject: [PATCH v4 8/9] drm/msm/dp: Add sink_count to debug logs
Date: Thu, 05 Mar 2026 16:30:50 +0200 [thread overview]
Message-ID: <20260305-hpd-refactor-v4-8-39c9d1fef321@oss.qualcomm.com> (raw)
In-Reply-To: <20260305-hpd-refactor-v4-0-39c9d1fef321@oss.qualcomm.com>
From: Jessica Zhang <jessica.zhang@oss.qualcomm.com>
Add sink count to the debug logs for [un]plug and HPD IRQ handling.
Signed-off-by: Jessica Zhang <jessica.zhang@oss.qualcomm.com>
[DB: dropped link_ready handling]
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
drivers/gpu/drm/msm/dp/dp_display.c | 30 ++++++++++++++++++------------
1 file changed, 18 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
index e3b43d73b67a..a1fb9c62bb0e 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -388,8 +388,9 @@ static int msm_dp_hpd_plug_handle(struct msm_dp_display_private *dp)
int ret;
struct platform_device *pdev = dp->msm_dp_display.pdev;
- drm_dbg_dp(dp->drm_dev, "Before, type=%d\n",
- dp->msm_dp_display.connector_type);
+ drm_dbg_dp(dp->drm_dev, "Before, type=%d sink_count=%d\n",
+ dp->msm_dp_display.connector_type,
+ dp->link->sink_count);
if (dp->msm_dp_display.link_ready)
return 0;
@@ -411,8 +412,9 @@ static int msm_dp_hpd_plug_handle(struct msm_dp_display_private *dp)
pm_runtime_put_sync(&pdev->dev);
}
- drm_dbg_dp(dp->drm_dev, "After, type=%d\n",
- dp->msm_dp_display.connector_type);
+ drm_dbg_dp(dp->drm_dev, "After, type=%d sink_count=%d\n",
+ dp->msm_dp_display.connector_type,
+ dp->link->sink_count);
/* uevent will complete connection part */
return 0;
@@ -440,8 +442,9 @@ static int msm_dp_hpd_unplug_handle(struct msm_dp_display_private *dp)
msm_dp_aux_enable_xfers(dp->aux, false);
- drm_dbg_dp(dp->drm_dev, "Before, type=%d\n",
- dp->msm_dp_display.connector_type);
+ drm_dbg_dp(dp->drm_dev, "Before, type=%d sink_count=%d\n",
+ dp->msm_dp_display.connector_type,
+ dp->link->sink_count);
if (!dp->msm_dp_display.link_ready)
return 0;
@@ -465,8 +468,9 @@ static int msm_dp_hpd_unplug_handle(struct msm_dp_display_private *dp)
/* signal the disconnect event early to ensure proper teardown */
msm_dp_display_handle_plugged_change(&dp->msm_dp_display, false);
- drm_dbg_dp(dp->drm_dev, "After, type=%d\n",
- dp->msm_dp_display.connector_type);
+ drm_dbg_dp(dp->drm_dev, "After, type=%d, sink_count=%d\n",
+ dp->msm_dp_display.connector_type,
+ dp->link->sink_count);
/* uevent will complete disconnection part */
pm_runtime_put_sync(&pdev->dev);
@@ -479,8 +483,9 @@ static int msm_dp_irq_hpd_handle(struct msm_dp_display_private *dp)
int rc = 0;
/* irq_hpd can happen at either connected or disconnected state */
- drm_dbg_dp(dp->drm_dev, "Before, type=%d\n",
- dp->msm_dp_display.connector_type);
+ drm_dbg_dp(dp->drm_dev, "Before, type=%d, sink_count=%d\n",
+ dp->msm_dp_display.connector_type,
+ dp->link->sink_count);
/* check for any test request issued by sink */
rc = msm_dp_link_process_request(dp->link);
@@ -493,8 +498,9 @@ static int msm_dp_irq_hpd_handle(struct msm_dp_display_private *dp)
rc = msm_dp_display_handle_irq_hpd(dp);
}
- drm_dbg_dp(dp->drm_dev, "After, type=%d\n",
- dp->msm_dp_display.connector_type);
+ drm_dbg_dp(dp->drm_dev, "After, type=%d, sink_count=%d\n",
+ dp->msm_dp_display.connector_type,
+ dp->link->sink_count);
return rc;
}
--
2.47.3
next prev parent reply other threads:[~2026-03-05 14:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 14:30 [PATCH v4 0/9] drm/msm/dp: Drop the HPD state machine Dmitry Baryshkov
2026-03-05 14:30 ` [PATCH v4 1/9] drm/msm/dp: fix HPD state status bit shift value Dmitry Baryshkov
2026-03-09 12:45 ` Konrad Dybcio
2026-03-05 14:30 ` [PATCH v4 2/9] drm/msm/dp: Fix the ISR_* enum values Dmitry Baryshkov
2026-03-09 12:45 ` Konrad Dybcio
2026-03-05 14:30 ` [PATCH v4 3/9] drm/msm/dp: Read DPCD and sink count in bridge detect() Dmitry Baryshkov
2026-03-05 14:30 ` [PATCH v4 4/9] drm/msm/dp: Move link training to atomic_enable() Dmitry Baryshkov
2026-03-05 14:30 ` [PATCH v4 5/9] drm/msm/dp: Drop EV_USER_NOTIFICATION Dmitry Baryshkov
2026-03-10 14:02 ` Konrad Dybcio
2026-03-05 14:30 ` [PATCH v4 6/9] drm/msm/dp: drop event data Dmitry Baryshkov
2026-03-10 14:02 ` Konrad Dybcio
2026-03-05 14:30 ` [PATCH v4 7/9] drm/msm/dp: rework HPD handling Dmitry Baryshkov
2026-03-05 14:30 ` Dmitry Baryshkov [this message]
2026-03-05 14:30 ` [PATCH v4 9/9] drm/msm/dp: turn link_ready into plugged Dmitry Baryshkov
2026-03-09 12:45 ` [PATCH v4 0/9] drm/msm/dp: Drop the HPD state machine Konrad Dybcio
2026-03-09 19:59 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260305-hpd-refactor-v4-8-39c9d1fef321@oss.qualcomm.com \
--to=dmitry.baryshkov@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jessica.zhang@oss.qualcomm.com \
--cc=jesszhan0024@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_khsieh@quicinc.com \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=yongxing.mou@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox