From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Rob Clark <robin.clark@oss.qualcomm.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Jessica Zhang <jesszhan0024@gmail.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Kuogee Hsieh <quic_khsieh@quicinc.com>,
Yongxing Mou <yongxing.mou@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Jessica Zhang <jessica.zhang@oss.qualcomm.com>
Subject: Re: [PATCH v4 0/9] drm/msm/dp: Drop the HPD state machine
Date: Mon, 9 Mar 2026 13:45:34 +0100 [thread overview]
Message-ID: <f1e77005-8af0-4628-87ea-b38263418bdf@oss.qualcomm.com> (raw)
In-Reply-To: <20260305-hpd-refactor-v4-0-39c9d1fef321@oss.qualcomm.com>
On 3/5/26 3:30 PM, Dmitry Baryshkov wrote:
> Currently, all HPD interrupt handling must go through the HPD state
> machine.
>
> This has caused many issues where the DRM framework assumes that DP is
> in one state while the state machine is stuck in another state.
>
> As discussed here [1], this series:
>
> - Removes the state machine
> - Moves link training to atomic_enable()
> - Changes the detect() behavior to return true if a display is physically
> plugged in (as opposed to if the DP link is ready).
> - Remove event queue and move internal HPD handling to hpd_notify()
>
> Note: eDP is mostly untested. This will be sorted out before the next
> iteration, but it will not affect the series in a major way.
>
> Note 2: there is an issue with the DP connectors using GPIO for HPD
> (rather than using the nativate DP HPD pin), the DP will not detect a
> display if it is plugged in before the board is booted. This is not an
> issue of this series and it will be handled by a separate series to be
> posted today or tomorrow.
>
> [1] https://patchwork.freedesktop.org/patch/656312/?series=142010&rev=2#comment_1201738
>
> ---
> Changes in v4:
> - Fixed PM runtime handling
> - Fixed several cases where the HPD machine would loose its state
> - Fixed the case where detection was ignoring the plugging in display.
- forgot to run b4 trailers -u
(no worries though)
Konrad
next prev parent reply other threads:[~2026-03-09 12:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 14:30 [PATCH v4 0/9] drm/msm/dp: Drop the HPD state machine Dmitry Baryshkov
2026-03-05 14:30 ` [PATCH v4 1/9] drm/msm/dp: fix HPD state status bit shift value Dmitry Baryshkov
2026-03-09 12:45 ` Konrad Dybcio
2026-03-05 14:30 ` [PATCH v4 2/9] drm/msm/dp: Fix the ISR_* enum values Dmitry Baryshkov
2026-03-09 12:45 ` Konrad Dybcio
2026-03-05 14:30 ` [PATCH v4 3/9] drm/msm/dp: Read DPCD and sink count in bridge detect() Dmitry Baryshkov
2026-03-05 14:30 ` [PATCH v4 4/9] drm/msm/dp: Move link training to atomic_enable() Dmitry Baryshkov
2026-03-05 14:30 ` [PATCH v4 5/9] drm/msm/dp: Drop EV_USER_NOTIFICATION Dmitry Baryshkov
2026-03-10 14:02 ` Konrad Dybcio
2026-03-05 14:30 ` [PATCH v4 6/9] drm/msm/dp: drop event data Dmitry Baryshkov
2026-03-10 14:02 ` Konrad Dybcio
2026-03-05 14:30 ` [PATCH v4 7/9] drm/msm/dp: rework HPD handling Dmitry Baryshkov
2026-03-05 14:30 ` [PATCH v4 8/9] drm/msm/dp: Add sink_count to debug logs Dmitry Baryshkov
2026-03-05 14:30 ` [PATCH v4 9/9] drm/msm/dp: turn link_ready into plugged Dmitry Baryshkov
2026-03-09 12:45 ` Konrad Dybcio [this message]
2026-03-09 19:59 ` [PATCH v4 0/9] drm/msm/dp: Drop the HPD state machine Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1e77005-8af0-4628-87ea-b38263418bdf@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jessica.zhang@oss.qualcomm.com \
--cc=jesszhan0024@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_khsieh@quicinc.com \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=yongxing.mou@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox