Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Val Packett <val@packett.cool>
Cc: Val Packett <val@packett.cool>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Johan Hovold <johan+linaro@kernel.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Dmitry Baryshkov <lumag@kernel.org>,
	Maximilian Luz <luzmaximilian@gmail.com>,
	linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 0/7] clk: qcom: sc8180x: PM-related fixes
Date: Sun,  8 Mar 2026 22:00:22 -0300	[thread overview]
Message-ID: <20260309010214.224621-1-val@packett.cool> (raw)

This series mostly ports the fixes that were made over the years to the
sc8280xp drivers to the sc8180x ones. (With apologies to everyone for
somewhat stealing the commit messages in places :D)

The most pressing issue this resolves is s2idle exit on the Surface Pro X
being slow and breaking NVMe:

    nvme 0002:01:00.0: Unable to change power state from D3cold to D0, device inaccessible
    xhci-hcd xhci-hcd.0.auto: xHC error in resume, USBSTS 0x401, Reinit
    usb usb1: root hub lost power or was reset
    usb usb2: root hub lost power or was reset
    nvme nvme0: controller is down; will reset: CSTS=0xffffffff, PCI_STATUS read failed (134)
    nvme nvme0: Does your device have a faulty power saving mode enabled?
    nvme nvme0: Try "nvme_core.default_ps_max_latency_us=0 pcie_aspm=off pcie_port_pm=off" and report a bug
    nvme 0002:01:00.0: Unable to change power state from D3cold to D0, device inaccessible

Hopefully it also contributes towards improving power usage eventually..

One thing I'm left wondering about is 8d114b94fc39 ("clk: qcom:
gcc-sc8280xp: use collapse-voting for PCIe GDSCs"), not sure if it
applies and if it does, where I'd find the values. (Downstream dtsi for
sdmshrike, which is the closest SoC that the msm kernel supports AFAIK,
was my only reference and it doesn't seem to have anything related.)

And 9410fb940114 ("clk: qcom: gcc-sc8280xp: use phy-mux clock for PCIe")
.. we don't have the _src clocks for PCIe defined at all here (o.0)

BTW there's also a dispcc patch I sent as an RFC but probably
should've been part of this series:

https://lore.kernel.org/all/20260307111801.631060-1-val@packett.cool/

Thanks,
~val

Val Packett (7):
  dt-bindings: clock: qcom,gcc-sc8180x: Add missing GDSCs
  clk: qcom: gcc-sc8180x: Add missing GDSCs
  clk: qcom: gcc-sc8180x: Use retention for USB power domains
  clk: qcom: gcc-sc8180x: Use retention for PCIe power domains
  clk: qcom: gcc-sc8180x: Add missing GDSC flags
  clk: qcom: gcc-sc8180x: Add runtime PM
  clk: qcom: camcc-sc8180x: Disable always-on clocks on probe failure

 drivers/clk/qcom/camcc-sc8180x.c             |  14 ++-
 drivers/clk/qcom/gcc-sc8180x.c               | 112 +++++++++++++++----
 include/dt-bindings/clock/qcom,gcc-sc8180x.h |   5 +
 3 files changed, 109 insertions(+), 22 deletions(-)

-- 
2.52.0


             reply	other threads:[~2026-03-09  1:02 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-09  1:00 Val Packett [this message]
2026-03-09  1:00 ` [PATCH 1/7] dt-bindings: clock: qcom,gcc-sc8180x: Add missing GDSCs Val Packett
2026-03-09  8:04   ` Krzysztof Kozlowski
2026-03-09 12:41     ` Konrad Dybcio
2026-03-09  1:00 ` [PATCH 2/7] clk: qcom: gcc-sc8180x: " Val Packett
2026-03-09 20:05   ` Dmitry Baryshkov
2026-03-10 11:44   ` Konrad Dybcio
2026-03-09  1:00 ` [PATCH 3/7] clk: qcom: gcc-sc8180x: Use retention for USB power domains Val Packett
2026-03-09 20:08   ` Dmitry Baryshkov
2026-03-10 11:47   ` Konrad Dybcio
2026-03-09  1:00 ` [PATCH 4/7] clk: qcom: gcc-sc8180x: Use retention for PCIe " Val Packett
2026-03-09 20:10   ` Dmitry Baryshkov
2026-03-09  1:00 ` [PATCH 5/7] clk: qcom: gcc-sc8180x: Add missing GDSC flags Val Packett
2026-03-09 20:17   ` Dmitry Baryshkov
2026-03-10 11:52   ` Konrad Dybcio
2026-03-09  1:06 ` [PATCH 6/7] clk: qcom: gcc-sc8180x: Add runtime PM Val Packett
2026-03-09  1:06   ` [PATCH 7/7] clk: qcom: camcc-sc8180x: Disable always-on clocks on probe failure Val Packett
2026-03-09 20:12     ` Dmitry Baryshkov
2026-03-09 20:10   ` [PATCH 6/7] clk: qcom: gcc-sc8180x: Add runtime PM Dmitry Baryshkov
2026-03-10 12:17   ` Konrad Dybcio
2026-03-10 11:42 ` [PATCH 0/7] clk: qcom: sc8180x: PM-related fixes Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260309010214.224621-1-val@packett.cool \
    --to=val@packett.cool \
    --cc=andersson@kernel.org \
    --cc=johan+linaro@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lumag@kernel.org \
    --cc=luzmaximilian@gmail.com \
    --cc=mani@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox