From: Val Packett <val@packett.cool>
To: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: Val Packett <val@packett.cool>,
Konrad Dybcio <konradybcio@kernel.org>,
Johan Hovold <johan+linaro@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Dmitry Baryshkov <lumag@kernel.org>,
Maximilian Luz <luzmaximilian@gmail.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 3/7] clk: qcom: gcc-sc8180x: Use retention for USB power domains
Date: Sun, 8 Mar 2026 22:00:25 -0300 [thread overview]
Message-ID: <20260309010214.224621-4-val@packett.cool> (raw)
In-Reply-To: <20260309010214.224621-1-val@packett.cool>
The USB subsystem does not expect to lose its state on suspend:
xhci-hcd xhci-hcd.0.auto: xHC error in resume, USBSTS 0x401, Reinit
usb usb1: root hub lost power or was reset
(The reinitialization usually succeeds, but it does slow down resume.)
To maintain state during suspend, the relevant GDSCs need to stay in
retention mode, like they do on other similar SoCs. Change the mode to
PWRSTS_RET_ON to fix.
Fixes: 4433594bbe5d ("clk: qcom: gcc: Add global clock controller driver for SC8180x")
Signed-off-by: Val Packett <val@packett.cool>
---
drivers/clk/qcom/gcc-sc8180x.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/clk/qcom/gcc-sc8180x.c b/drivers/clk/qcom/gcc-sc8180x.c
index 55dabf6259b2..b116a9c0b2d9 100644
--- a/drivers/clk/qcom/gcc-sc8180x.c
+++ b/drivers/clk/qcom/gcc-sc8180x.c
@@ -4172,7 +4172,7 @@ static struct gdsc usb30_sec_gdsc = {
.pd = {
.name = "usb30_sec_gdsc",
},
- .pwrsts = PWRSTS_OFF_ON,
+ .pwrsts = PWRSTS_RET_ON,
.flags = POLL_CFG_GDSCR,
};
@@ -4190,7 +4190,7 @@ static struct gdsc usb30_prim_gdsc = {
.pd = {
.name = "usb30_prim_gdsc",
},
- .pwrsts = PWRSTS_OFF_ON,
+ .pwrsts = PWRSTS_RET_ON,
.flags = POLL_CFG_GDSCR,
};
@@ -4262,7 +4262,7 @@ static struct gdsc usb30_mp_gdsc = {
.pd = {
.name = "usb30_mp_gdsc",
},
- .pwrsts = PWRSTS_OFF_ON,
+ .pwrsts = PWRSTS_RET_ON,
.flags = POLL_CFG_GDSCR,
};
--
2.52.0
next prev parent reply other threads:[~2026-03-09 1:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 1:00 [PATCH 0/7] clk: qcom: sc8180x: PM-related fixes Val Packett
2026-03-09 1:00 ` [PATCH 1/7] dt-bindings: clock: qcom,gcc-sc8180x: Add missing GDSCs Val Packett
2026-03-09 8:04 ` Krzysztof Kozlowski
2026-03-09 12:41 ` Konrad Dybcio
2026-03-09 1:00 ` [PATCH 2/7] clk: qcom: gcc-sc8180x: " Val Packett
2026-03-09 20:05 ` Dmitry Baryshkov
2026-03-10 11:44 ` Konrad Dybcio
2026-03-09 1:00 ` Val Packett [this message]
2026-03-09 20:08 ` [PATCH 3/7] clk: qcom: gcc-sc8180x: Use retention for USB power domains Dmitry Baryshkov
2026-03-10 11:47 ` Konrad Dybcio
2026-03-09 1:00 ` [PATCH 4/7] clk: qcom: gcc-sc8180x: Use retention for PCIe " Val Packett
2026-03-09 20:10 ` Dmitry Baryshkov
2026-03-09 1:00 ` [PATCH 5/7] clk: qcom: gcc-sc8180x: Add missing GDSC flags Val Packett
2026-03-09 20:17 ` Dmitry Baryshkov
2026-03-10 11:52 ` Konrad Dybcio
2026-03-09 1:06 ` [PATCH 6/7] clk: qcom: gcc-sc8180x: Add runtime PM Val Packett
2026-03-09 1:06 ` [PATCH 7/7] clk: qcom: camcc-sc8180x: Disable always-on clocks on probe failure Val Packett
2026-03-09 20:12 ` Dmitry Baryshkov
2026-03-09 20:10 ` [PATCH 6/7] clk: qcom: gcc-sc8180x: Add runtime PM Dmitry Baryshkov
2026-03-10 12:17 ` Konrad Dybcio
2026-03-10 11:42 ` [PATCH 0/7] clk: qcom: sc8180x: PM-related fixes Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260309010214.224621-4-val@packett.cool \
--to=val@packett.cool \
--cc=andersson@kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=mani@kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox