Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: kodiak: Add LPASS I2S2 pinctrl definitions
@ 2026-03-23  9:40 Val Packett
  2026-03-23 12:43 ` Konrad Dybcio
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Val Packett @ 2026-03-23  9:40 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: Val Packett, linux-arm-msm, devicetree, linux-kernel

Add the pinctrl definitions to configure gpio10-gpio13 of the lpass_tlmm
for I2S output.

Signed-off-by: Val Packett <val@packett.cool>
---
Similar to ff9c117c32bc6ace7 which just landed, this is for the other MI2S
interface on there. It is the Senary MI2S, so actually using it requires
the series from [1] and then more changes on top, but I have sound working
on my device with it, so let's get this DT chunk in first / at the same time
as the other prereqs land as well.

[1]: https://lore.kernel.org/all/20260320144918.1685838-1-srinivas.kandagatla@oss.qualcomm.com/

Thanks,
~val
---
 arch/arm64/boot/dts/qcom/kodiak.dtsi | 52 ++++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi
index 343da1b18095..f393d1c22223 100644
--- a/arch/arm64/boot/dts/qcom/kodiak.dtsi
+++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi
@@ -3088,6 +3088,58 @@ data-pins {
 				};
 			};
 
+			lpass_i2s2_active: i2s2-active-state {
+				clk-pins {
+					pins = "gpio10";
+					function = "i2s2_clk";
+					drive-strength = <8>;
+					bias-disable;
+					output-high;
+				};
+
+				ws-pins {
+					pins = "gpio11";
+					function = "i2s2_ws";
+					drive-strength = <8>;
+					bias-disable;
+					output-high;
+				};
+
+				data-pins {
+					pins = "gpio12", "gpio13";
+					function = "i2s2_data";
+					drive-strength = <8>;
+					bias-disable;
+					output-high;
+				};
+			};
+
+			lpass_i2s2_sleep: i2s2-sleep-state {
+				clk-pins {
+					pins = "gpio10";
+					function = "i2s2_clk";
+					drive-strength = <2>;
+					bias-pull-down;
+					input-enable;
+				};
+
+				ws-pins {
+					pins = "gpio11";
+					function = "i2s2_ws";
+					drive-strength = <2>;
+					bias-pull-down;
+					input-enable;
+				};
+
+				data-pins {
+					pins = "gpio12", "gpio13";
+					function = "i2s2_data";
+					drive-strength = <2>;
+					bias-pull-down;
+					input-enable;
+				};
+			};
+
 			lpass_rx_swr_clk: rx-swr-clk-state {
 				pins = "gpio3";
 				function = "swr_rx_clk";
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: qcom: kodiak: Add LPASS I2S2 pinctrl definitions
  2026-03-23  9:40 [PATCH] arm64: dts: qcom: kodiak: Add LPASS I2S2 pinctrl definitions Val Packett
@ 2026-03-23 12:43 ` Konrad Dybcio
  2026-03-24  0:14 ` Dmitry Baryshkov
  2026-03-26  3:19 ` Bjorn Andersson
  2 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2026-03-23 12:43 UTC (permalink / raw)
  To: Val Packett, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel

On 3/23/26 10:40 AM, Val Packett wrote:
> Add the pinctrl definitions to configure gpio10-gpio13 of the lpass_tlmm
> for I2S output.
> 
> Signed-off-by: Val Packett <val@packett.cool>
> ---
> Similar to ff9c117c32bc6ace7 which just landed, this is for the other MI2S
> interface on there. It is the Senary MI2S, so actually using it requires
> the series from [1] and then more changes on top, but I have sound working
> on my device with it, so let's get this DT chunk in first / at the same time
> as the other prereqs land as well.
> 
> [1]: https://lore.kernel.org/all/20260320144918.1685838-1-srinivas.kandagatla@oss.qualcomm.com/
> 
> Thanks,
> ~val

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: qcom: kodiak: Add LPASS I2S2 pinctrl definitions
  2026-03-23  9:40 [PATCH] arm64: dts: qcom: kodiak: Add LPASS I2S2 pinctrl definitions Val Packett
  2026-03-23 12:43 ` Konrad Dybcio
@ 2026-03-24  0:14 ` Dmitry Baryshkov
  2026-03-26  3:19 ` Bjorn Andersson
  2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2026-03-24  0:14 UTC (permalink / raw)
  To: Val Packett
  Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, linux-arm-msm, devicetree, linux-kernel

On Mon, Mar 23, 2026 at 06:40:47AM -0300, Val Packett wrote:
> Add the pinctrl definitions to configure gpio10-gpio13 of the lpass_tlmm
> for I2S output.
> 
> Signed-off-by: Val Packett <val@packett.cool>
> ---
> Similar to ff9c117c32bc6ace7 which just landed, this is for the other MI2S
> interface on there. It is the Senary MI2S, so actually using it requires
> the series from [1] and then more changes on top, but I have sound working
> on my device with it, so let's get this DT chunk in first / at the same time
> as the other prereqs land as well.
> 
> [1]: https://lore.kernel.org/all/20260320144918.1685838-1-srinivas.kandagatla@oss.qualcomm.com/
> 
> Thanks,
> ~val
> ---
>  arch/arm64/boot/dts/qcom/kodiak.dtsi | 52 ++++++++++++++++++++++++++++
>  1 file changed, 52 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: qcom: kodiak: Add LPASS I2S2 pinctrl definitions
  2026-03-23  9:40 [PATCH] arm64: dts: qcom: kodiak: Add LPASS I2S2 pinctrl definitions Val Packett
  2026-03-23 12:43 ` Konrad Dybcio
  2026-03-24  0:14 ` Dmitry Baryshkov
@ 2026-03-26  3:19 ` Bjorn Andersson
  2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2026-03-26  3:19 UTC (permalink / raw)
  To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Val Packett
  Cc: linux-arm-msm, devicetree, linux-kernel


On Mon, 23 Mar 2026 06:40:47 -0300, Val Packett wrote:
> Add the pinctrl definitions to configure gpio10-gpio13 of the lpass_tlmm
> for I2S output.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: kodiak: Add LPASS I2S2 pinctrl definitions
      commit: 5e25296941545e4739bbdec8084185b1a945381f

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-03-26  3:19 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-23  9:40 [PATCH] arm64: dts: qcom: kodiak: Add LPASS I2S2 pinctrl definitions Val Packett
2026-03-23 12:43 ` Konrad Dybcio
2026-03-24  0:14 ` Dmitry Baryshkov
2026-03-26  3:19 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox