* [PATCH] dt-bindings: mailbox: qcom: Add IPQ5210 APCS compatible @ 2026-06-29 4:40 Varadarajan Narayanan 2026-06-29 7:27 ` Krzysztof Kozlowski 0 siblings, 1 reply; 4+ messages in thread From: Varadarajan Narayanan @ 2026-06-29 4:40 UTC (permalink / raw) To: Jassi Brar, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: linux-arm-msm, linux-kernel, devicetree, Varadarajan Narayanan Add the APCS mailbox compatible for the IPQ5210 SoC. It uses the IPQ6018 APCS mailbox compatible as a fallback, so document the valid compatible string combination in the binding. Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com> --- no cover letter contents, it is a single patch --- Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml index 1b4ef0688ca7..39bc374300c3 100644 --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml @@ -19,6 +19,7 @@ properties: - items: - enum: - qcom,ipq5018-apcs-apps-global + - qcom,ipq5210-apcs-apps-global - qcom,ipq5332-apcs-apps-global - qcom,ipq5424-apcs-apps-global - qcom,ipq8074-apcs-apps-global --- base-commit: 533704f3c28c3f5f9e2542aa3a6a326c32e6f5c0 change-id: 20260625-mailbox-01f977bcceec prerequisite-change-id: 20260625-apss-clk-ed39c40ed468:v1 prerequisite-patch-id: d9efdd8a09b028b1343243c5f0e78cf3e8b1e253 prerequisite-patch-id: b4b3a2f745b4d83a81939f46ca3a4c871cde73f3 Best regards, -- Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com> ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: mailbox: qcom: Add IPQ5210 APCS compatible 2026-06-29 4:40 [PATCH] dt-bindings: mailbox: qcom: Add IPQ5210 APCS compatible Varadarajan Narayanan @ 2026-06-29 7:27 ` Krzysztof Kozlowski 2026-06-29 7:29 ` Krzysztof Kozlowski 0 siblings, 1 reply; 4+ messages in thread From: Krzysztof Kozlowski @ 2026-06-29 7:27 UTC (permalink / raw) To: Varadarajan Narayanan Cc: Jassi Brar, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, linux-kernel, devicetree On Mon, Jun 29, 2026 at 10:10:46AM +0530, Varadarajan Narayanan wrote: > Add the APCS mailbox compatible for the IPQ5210 SoC. It uses the IPQ6018 > APCS mailbox compatible as a fallback, so document the valid compatible > string combination in the binding. > > Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com> > --- > no cover letter contents, it is a single patch > --- > Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > index 1b4ef0688ca7..39bc374300c3 100644 > --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > @@ -19,6 +19,7 @@ properties: > - items: > - enum: > - qcom,ipq5018-apcs-apps-global > + - qcom,ipq5210-apcs-apps-global > - qcom,ipq5332-apcs-apps-global > - qcom,ipq5424-apcs-apps-global > - qcom,ipq8074-apcs-apps-global > > --- > base-commit: 533704f3c28c3f5f9e2542aa3a6a326c32e6f5c0 > change-id: 20260625-mailbox-01f977bcceec > prerequisite-change-id: 20260625-apss-clk-ed39c40ed468:v1 > prerequisite-patch-id: d9efdd8a09b028b1343243c5f0e78cf3e8b1e253 Same author, just squash them. I already complained within Qualcomm about this more than once. On the mailing list, on the internal company-wide open-source channel and in person now when I was in Hyderabad. Repeating the same is waste of my time, easier to have blanket NAK on your patches. NAK Best regards, Krzysztof ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: mailbox: qcom: Add IPQ5210 APCS compatible 2026-06-29 7:27 ` Krzysztof Kozlowski @ 2026-06-29 7:29 ` Krzysztof Kozlowski 2026-06-30 7:42 ` Varadarajan Narayanan 0 siblings, 1 reply; 4+ messages in thread From: Krzysztof Kozlowski @ 2026-06-29 7:29 UTC (permalink / raw) To: Varadarajan Narayanan Cc: Jassi Brar, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, linux-kernel, devicetree On 29/06/2026 09:27, Krzysztof Kozlowski wrote: > On Mon, Jun 29, 2026 at 10:10:46AM +0530, Varadarajan Narayanan wrote: >> Add the APCS mailbox compatible for the IPQ5210 SoC. It uses the IPQ6018 >> APCS mailbox compatible as a fallback, so document the valid compatible >> string combination in the binding. >> >> Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com> >> --- >> no cover letter contents, it is a single patch >> --- >> Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >> index 1b4ef0688ca7..39bc374300c3 100644 >> --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >> +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml >> @@ -19,6 +19,7 @@ properties: >> - items: >> - enum: >> - qcom,ipq5018-apcs-apps-global >> + - qcom,ipq5210-apcs-apps-global >> - qcom,ipq5332-apcs-apps-global >> - qcom,ipq5424-apcs-apps-global >> - qcom,ipq8074-apcs-apps-global >> >> --- >> base-commit: 533704f3c28c3f5f9e2542aa3a6a326c32e6f5c0 >> change-id: 20260625-mailbox-01f977bcceec >> prerequisite-change-id: 20260625-apss-clk-ed39c40ed468:v1 >> prerequisite-patch-id: d9efdd8a09b028b1343243c5f0e78cf3e8b1e253 > > Same author, just squash them. > > I already complained within Qualcomm about this more than once. On the > mailing list, on the internal company-wide open-source channel and in > person now when I was in Hyderabad. > > Repeating the same is waste of my time, easier to have blanket NAK on > your patches. > Oh, wait, this is even messier - when I look for these in lore, it directed me to that patch, which I took as some other work. That is my mistake, but still problem remain: 1. Dependencies are not easy to find. 2. The clk change-id is found and I do not understand why you made it as dependency. You are not making it easier for the community to understand this. Anyway, I drop from patchwork. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: mailbox: qcom: Add IPQ5210 APCS compatible 2026-06-29 7:29 ` Krzysztof Kozlowski @ 2026-06-30 7:42 ` Varadarajan Narayanan 0 siblings, 0 replies; 4+ messages in thread From: Varadarajan Narayanan @ 2026-06-30 7:42 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Jassi Brar, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, linux-kernel, devicetree On Mon, Jun 29, 2026 at 09:29:47AM +0200, Krzysztof Kozlowski wrote: > On 29/06/2026 09:27, Krzysztof Kozlowski wrote: > > On Mon, Jun 29, 2026 at 10:10:46AM +0530, Varadarajan Narayanan wrote: > >> Add the APCS mailbox compatible for the IPQ5210 SoC. It uses the IPQ6018 > >> APCS mailbox compatible as a fallback, so document the valid compatible > >> string combination in the binding. > >> > >> Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com> > >> --- > >> no cover letter contents, it is a single patch > >> --- > >> Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > >> index 1b4ef0688ca7..39bc374300c3 100644 > >> --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > >> +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > >> @@ -19,6 +19,7 @@ properties: > >> - items: > >> - enum: > >> - qcom,ipq5018-apcs-apps-global > >> + - qcom,ipq5210-apcs-apps-global > >> - qcom,ipq5332-apcs-apps-global > >> - qcom,ipq5424-apcs-apps-global > >> - qcom,ipq8074-apcs-apps-global > >> > >> --- > >> base-commit: 533704f3c28c3f5f9e2542aa3a6a326c32e6f5c0 > >> change-id: 20260625-mailbox-01f977bcceec > >> prerequisite-change-id: 20260625-apss-clk-ed39c40ed468:v1 > >> prerequisite-patch-id: d9efdd8a09b028b1343243c5f0e78cf3e8b1e253 > > > > Same author, just squash them. > > > > I already complained within Qualcomm about this more than once. On the > > mailing list, on the internal company-wide open-source channel and in > > person now when I was in Hyderabad. > > > > Repeating the same is waste of my time, easier to have blanket NAK on > > your patches. > > > > Oh, wait, this is even messier - when I look for these in lore, it > directed me to that patch, which I took as some other work. That is my > mistake, but still problem remain: > 1. Dependencies are not easy to find. > 2. The clk change-id is found and I do not understand why you made it as > dependency. > > You are not making it easier for the community to understand this. Sorry. Apologies for the inconvenience. Had posted three patches in the internal list [PATCH PREVIEW 0/2] Add APSS clock driver support for IPQ5210 - [1] [PATCH PREVIEW] dt-bindings: mailbox: qcom: add compatible for the IPQ5210 SoC - [2] [PATCH PREVIEW] cpufreq: qcom-nvmem: Introduce cpufreq for ipq5210 - [3] To test the cpufreq and thermal sensor based throttling all these patches and the tsens was needed. So marked them as dependencies. Since there was no negative feedback in the internal list, and the files had different maintainers assumed the split is correct and posted the same for upstream review. Should I combine them and post? Thanks -Varada 1 - http://shc-kerarch-hyd:8080/kernel_archive/20260626-apss-clk-v1-0-8c423d3cb94f@oss.qualcomm.com/ 2 - http://shc-kerarch-hyd:8080/kernel_archive/20260626-mailbox-v1-1-24b766dc2ebb@oss.qualcomm.com/ 3 - http://shc-kerarch-hyd:8080/kernel_archive/20260626-cpufreq-v1-1-0a1f26d5b734@oss.qualcomm.com/ ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-06-30 7:42 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-06-29 4:40 [PATCH] dt-bindings: mailbox: qcom: Add IPQ5210 APCS compatible Varadarajan Narayanan 2026-06-29 7:27 ` Krzysztof Kozlowski 2026-06-29 7:29 ` Krzysztof Kozlowski 2026-06-30 7:42 ` Varadarajan Narayanan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox