[PATCH] accel/qaic: Add xbl_config image entry for AIC200

[PATCH] accel/qaic: Add xbl_config image entry for AIC200

[Youssef Samir]

From: Aswin Venkatesan <aswivenk@qti.qualcomm.com>

Update the Sahara image table for the AIC200 to add an entry for xbl_config image at id 38.

Signed-off-by: Aswin Venkatesan <aswivenk@qti.qualcomm.com>
Signed-off-by: Youssef Samir <youssef.abdulrahman@oss.qualcomm.com>
---
 drivers/accel/qaic/sahara.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/accel/qaic/sahara.c b/drivers/accel/qaic/sahara.c
index 3ebcc1f7ff58..04e8acb94c04 100644
--- a/drivers/accel/qaic/sahara.c
+++ b/drivers/accel/qaic/sahara.c
@@ -194,6 +194,7 @@ static const char * const aic200_image_table[] = {
 	[23] = "qcom/aic200/aop.mbn",
 	[32] = "qcom/aic200/tz.mbn",
 	[33] = "qcom/aic200/hypvm.mbn",
+	[38] = "qcom/aic200/xbl_config.elf",
 	[39] = "qcom/aic200/aic200_abl.elf",
 	[40] = "qcom/aic200/apdp.mbn",
 	[41] = "qcom/aic200/devcfg.mbn",
-- 
2.43.0

Re: [PATCH] accel/qaic: Add xbl_config image entry for AIC200

[Konrad Dybcio]

On 10/8/25 12:15 AM, Youssef Samir wrote:
> From: Aswin Venkatesan <aswivenk@qti.qualcomm.com>
> 
> Update the Sahara image table for the AIC200 to add an entry for xbl_config image at id 38.
> 
> Signed-off-by: Aswin Venkatesan <aswivenk@qti.qualcomm.com>
> Signed-off-by: Youssef Samir <youssef.abdulrahman@oss.qualcomm.com>
> ---
>  drivers/accel/qaic/sahara.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/accel/qaic/sahara.c b/drivers/accel/qaic/sahara.c
> index 3ebcc1f7ff58..04e8acb94c04 100644
> --- a/drivers/accel/qaic/sahara.c
> +++ b/drivers/accel/qaic/sahara.c
> @@ -194,6 +194,7 @@ static const char * const aic200_image_table[] = {
>  	[23] = "qcom/aic200/aop.mbn",
>  	[32] = "qcom/aic200/tz.mbn",
>  	[33] = "qcom/aic200/hypvm.mbn",
> +	[38] = "qcom/aic200/xbl_config.elf",

This is the third oneliner extending this array you sent within 24h,
please get the list of required files and update this list once and
for good

Konrad

Re: [PATCH] accel/qaic: Add xbl_config image entry for AIC200

[Carl Vanderlip]

On 10/8/2025 12:49 AM, Konrad Dybcio wrote:
> On 10/8/25 12:15 AM, Youssef Samir wrote:
>> From: Aswin Venkatesan <aswivenk@qti.qualcomm.com>
>>
>> Update the Sahara image table for the AIC200 to add an entry for xbl_config image at id 38.
>>
>> Signed-off-by: Aswin Venkatesan <aswivenk@qti.qualcomm.com>
>> Signed-off-by: Youssef Samir <youssef.abdulrahman@oss.qualcomm.com>
>> ---
>>  drivers/accel/qaic/sahara.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/accel/qaic/sahara.c b/drivers/accel/qaic/sahara.c
>> index 3ebcc1f7ff58..04e8acb94c04 100644
>> --- a/drivers/accel/qaic/sahara.c
>> +++ b/drivers/accel/qaic/sahara.c
>> @@ -194,6 +194,7 @@ static const char * const aic200_image_table[] = {
>>  	[23] = "qcom/aic200/aop.mbn",
>>  	[32] = "qcom/aic200/tz.mbn",
>>  	[33] = "qcom/aic200/hypvm.mbn",
>> +	[38] = "qcom/aic200/xbl_config.elf",
> 
> This is the third oneliner extending this array you sent within 24h,
> please get the list of required files and update this list once and
> for good
> 
> Konrad

I wish it was that easy during bring-up.

These patches are being upstreamed from our internal branch and thus
reflect the different latencies across the sub-teams to that request.

Nevertheless, this is upstream and these changes should have been
squashed.

Once that happens...

Reviewed-by: Carl Vanderlip <carl.vanderlip@oss.qualcomm.com>

Re: [PATCH] accel/qaic: Add xbl_config image entry for AIC200

[Konrad Dybcio]

On 10/14/25 1:47 AM, Carl Vanderlip wrote:
> On 10/8/2025 12:49 AM, Konrad Dybcio wrote:
>> On 10/8/25 12:15 AM, Youssef Samir wrote:
>>> From: Aswin Venkatesan <aswivenk@qti.qualcomm.com>
>>>
>>> Update the Sahara image table for the AIC200 to add an entry for xbl_config image at id 38.
>>>
>>> Signed-off-by: Aswin Venkatesan <aswivenk@qti.qualcomm.com>
>>> Signed-off-by: Youssef Samir <youssef.abdulrahman@oss.qualcomm.com>
>>> ---
>>>  drivers/accel/qaic/sahara.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/accel/qaic/sahara.c b/drivers/accel/qaic/sahara.c
>>> index 3ebcc1f7ff58..04e8acb94c04 100644
>>> --- a/drivers/accel/qaic/sahara.c
>>> +++ b/drivers/accel/qaic/sahara.c
>>> @@ -194,6 +194,7 @@ static const char * const aic200_image_table[] = {
>>>  	[23] = "qcom/aic200/aop.mbn",
>>>  	[32] = "qcom/aic200/tz.mbn",
>>>  	[33] = "qcom/aic200/hypvm.mbn",
>>> +	[38] = "qcom/aic200/xbl_config.elf",
>>
>> This is the third oneliner extending this array you sent within 24h,
>> please get the list of required files and update this list once and
>> for good
>>
>> Konrad
> 
> I wish it was that easy during bring-up.
> 
> These patches are being upstreamed from our internal branch and thus
> reflect the different latencies across the sub-teams to that request.

That's upstream-first-first ;)

I would assume there's a single list of files that get loaded, perhaps
within the device programmer image.. Unless you're altering that on the
fly as well?

Konrad

Re: [PATCH] accel/qaic: Add xbl_config image entry for AIC200

[Jeff Hugo]

On 10/14/2025 1:48 AM, Konrad Dybcio wrote:
> On 10/14/25 1:47 AM, Carl Vanderlip wrote:
>> On 10/8/2025 12:49 AM, Konrad Dybcio wrote:
>>> On 10/8/25 12:15 AM, Youssef Samir wrote:
>>>> From: Aswin Venkatesan <aswivenk@qti.qualcomm.com>
>>>>
>>>> Update the Sahara image table for the AIC200 to add an entry for xbl_config image at id 38.
>>>>
>>>> Signed-off-by: Aswin Venkatesan <aswivenk@qti.qualcomm.com>
>>>> Signed-off-by: Youssef Samir <youssef.abdulrahman@oss.qualcomm.com>
>>>> ---
>>>>   drivers/accel/qaic/sahara.c | 1 +
>>>>   1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/accel/qaic/sahara.c b/drivers/accel/qaic/sahara.c
>>>> index 3ebcc1f7ff58..04e8acb94c04 100644
>>>> --- a/drivers/accel/qaic/sahara.c
>>>> +++ b/drivers/accel/qaic/sahara.c
>>>> @@ -194,6 +194,7 @@ static const char * const aic200_image_table[] = {
>>>>   	[23] = "qcom/aic200/aop.mbn",
>>>>   	[32] = "qcom/aic200/tz.mbn",
>>>>   	[33] = "qcom/aic200/hypvm.mbn",
>>>> +	[38] = "qcom/aic200/xbl_config.elf",
>>>
>>> This is the third oneliner extending this array you sent within 24h,
>>> please get the list of required files and update this list once and
>>> for good
>>>
>>> Konrad
>>
>> I wish it was that easy during bring-up.
>>
>> These patches are being upstreamed from our internal branch and thus
>> reflect the different latencies across the sub-teams to that request.
> 
> That's upstream-first-first ;)
> 
> I would assume there's a single list of files that get loaded, perhaps
> within the device programmer image.. Unless you're altering that on the
> fly as well?

There is no device programmer.  This device does not store runtime 
firmware in flash.

This device is still under development and not in the hands of anyone 
outside of Qualcomm, yet.  Much to my annoyance, the firmware developers 
are continuing to change the firmware images - adding new images, 
splitting up existing ones, etc.

I'm expecting to lock this down, with or without the firmware teams, 
once devices end up in the wild.

-Jeff

Re: [PATCH] accel/qaic: Add xbl_config image entry for AIC200

[Konrad Dybcio]

On 10/14/25 6:48 PM, Jeff Hugo wrote:
> On 10/14/2025 1:48 AM, Konrad Dybcio wrote:
>> On 10/14/25 1:47 AM, Carl Vanderlip wrote:
>>> On 10/8/2025 12:49 AM, Konrad Dybcio wrote:
>>>> On 10/8/25 12:15 AM, Youssef Samir wrote:
>>>>> From: Aswin Venkatesan <aswivenk@qti.qualcomm.com>
>>>>>
>>>>> Update the Sahara image table for the AIC200 to add an entry for xbl_config image at id 38.
>>>>>
>>>>> Signed-off-by: Aswin Venkatesan <aswivenk@qti.qualcomm.com>
>>>>> Signed-off-by: Youssef Samir <youssef.abdulrahman@oss.qualcomm.com>
>>>>> ---
>>>>>   drivers/accel/qaic/sahara.c | 1 +
>>>>>   1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/drivers/accel/qaic/sahara.c b/drivers/accel/qaic/sahara.c
>>>>> index 3ebcc1f7ff58..04e8acb94c04 100644
>>>>> --- a/drivers/accel/qaic/sahara.c
>>>>> +++ b/drivers/accel/qaic/sahara.c
>>>>> @@ -194,6 +194,7 @@ static const char * const aic200_image_table[] = {
>>>>>       [23] = "qcom/aic200/aop.mbn",
>>>>>       [32] = "qcom/aic200/tz.mbn",
>>>>>       [33] = "qcom/aic200/hypvm.mbn",
>>>>> +    [38] = "qcom/aic200/xbl_config.elf",
>>>>
>>>> This is the third oneliner extending this array you sent within 24h,
>>>> please get the list of required files and update this list once and
>>>> for good
>>>>
>>>> Konrad
>>>
>>> I wish it was that easy during bring-up.
>>>
>>> These patches are being upstreamed from our internal branch and thus
>>> reflect the different latencies across the sub-teams to that request.
>>
>> That's upstream-first-first ;)
>>
>> I would assume there's a single list of files that get loaded, perhaps
>> within the device programmer image.. Unless you're altering that on the
>> fly as well?
> 
> There is no device programmer.  This device does not store runtime firmware in flash.
> 
> This device is still under development and not in the hands of anyone outside of Qualcomm, yet.  Much to my annoyance, the firmware developers are continuing to change the firmware images - adding new images, splitting up existing ones, etc.
> 
> I'm expecting to lock this down, with or without the firmware teams, once devices end up in the wild.

Sounds annoying indeed.. Hopefully this settles down

Konrad

Re: [PATCH] accel/qaic: Add xbl_config image entry for AIC200

[Jeff Hugo]

On 10/7/2025 4:15 PM, Youssef Samir wrote:
> From: Aswin Venkatesan <aswivenk@qti.qualcomm.com>
> 
> Update the Sahara image table for the AIC200 to add an entry for xbl_config image at id 38.
> 
> Signed-off-by: Aswin Venkatesan <aswivenk@qti.qualcomm.com>
> Signed-off-by: Youssef Samir <youssef.abdulrahman@oss.qualcomm.com>

Reviewed-by: Jeff Hugo <jeff.hugo@oss.qualcomm.com>