From: Krzysztof Kozlowski <krzk@kernel.org>
To: Raviteja Laggyshetty <quic_rlaggysh@quicinc.com>,
Georgi Djakov <djakov@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Odelu Kukatla <quic_okukatla@quicinc.com>,
Mike Tipton <quic_mdtipton@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: interconnect: qcom: drop QPIC_CORE IDs
Date: Thu, 21 Nov 2024 18:39:30 +0100 [thread overview]
Message-ID: <22828bf2-45a7-464d-ae30-8224056d9f0f@kernel.org> (raw)
In-Reply-To: <20241121172737.255-2-quic_rlaggysh@quicinc.com>
On 21/11/2024 18:27, Raviteja Laggyshetty wrote:
> QPIC resources are modeled as clks, therefore remove corresponding
s/clks/clocks/
> defines from the binding as they're unused.
As clocks where? Details are needed since you are affecting the ABI.
>
> Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@quicinc.com>
> ---
> include/dt-bindings/interconnect/qcom,sdx75.h | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
This does not build.
../drivers/interconnect/qcom/sdx75.c:906:10: error: ‘MASTER_QPIC_CORE’
undeclared here (not in a function); did you mean ‘MASTER_QPIC’?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-11-21 17:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-21 17:27 [PATCH 0/2] Drop QPIC related interconnect and BCM nodes on Raviteja Laggyshetty
2024-11-21 17:27 ` [PATCH 1/2] dt-bindings: interconnect: qcom: drop QPIC_CORE IDs Raviteja Laggyshetty
2024-11-21 17:39 ` Krzysztof Kozlowski [this message]
2024-11-21 22:01 ` Dmitry Baryshkov
2024-11-21 17:27 ` [PATCH 2/2] interconnect: qcom: sdx75: Drop QP0 related interconnect and BCM nodes Raviteja Laggyshetty
2024-11-21 22:02 ` Dmitry Baryshkov
2024-11-22 8:42 ` kernel test robot
2024-11-23 10:36 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22828bf2-45a7-464d-ae30-8224056d9f0f@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_mdtipton@quicinc.com \
--cc=quic_okukatla@quicinc.com \
--cc=quic_rlaggysh@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox