* [PATCH 0/2] Drop QPIC related interconnect and BCM nodes on @ 2024-11-21 17:27 Raviteja Laggyshetty 2024-11-21 17:27 ` [PATCH 1/2] dt-bindings: interconnect: qcom: drop QPIC_CORE IDs Raviteja Laggyshetty 2024-11-21 17:27 ` [PATCH 2/2] interconnect: qcom: sdx75: Drop QP0 related interconnect and BCM nodes Raviteja Laggyshetty 0 siblings, 2 replies; 8+ messages in thread From: Raviteja Laggyshetty @ 2024-11-21 17:27 UTC (permalink / raw) To: Georgi Djakov, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: Odelu Kukatla, Mike Tipton, linux-arm-msm, linux-pm, devicetree, linux-kernel QPIC scaling is managed by clock framework on SDX75 SoC, hence dropping the QPIC related interconnect and BCM nodes from topology to avoid the risk of overriding the votes placed on QPIC resource by clock framework. Raviteja Laggyshetty (2): dt-bindings: interconnect: qcom: drop QPIC_CORE IDs interconnect: qcom: sdx75: Drop QP0 related interconnect and BCM nodes drivers/interconnect/qcom/sdx75.c | 25 ---- drivers/interconnect/qcom/sdx75.h | 118 +++++++++--------- include/dt-bindings/interconnect/qcom,sdx75.h | 6 +- 3 files changed, 60 insertions(+), 89 deletions(-) -- 2.39.2 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] dt-bindings: interconnect: qcom: drop QPIC_CORE IDs 2024-11-21 17:27 [PATCH 0/2] Drop QPIC related interconnect and BCM nodes on Raviteja Laggyshetty @ 2024-11-21 17:27 ` Raviteja Laggyshetty 2024-11-21 17:39 ` Krzysztof Kozlowski 2024-11-21 22:01 ` Dmitry Baryshkov 2024-11-21 17:27 ` [PATCH 2/2] interconnect: qcom: sdx75: Drop QP0 related interconnect and BCM nodes Raviteja Laggyshetty 1 sibling, 2 replies; 8+ messages in thread From: Raviteja Laggyshetty @ 2024-11-21 17:27 UTC (permalink / raw) To: Georgi Djakov, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: Odelu Kukatla, Mike Tipton, linux-arm-msm, linux-pm, devicetree, linux-kernel QPIC resources are modeled as clks, therefore remove corresponding defines from the binding as they're unused. Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@quicinc.com> --- include/dt-bindings/interconnect/qcom,sdx75.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/include/dt-bindings/interconnect/qcom,sdx75.h b/include/dt-bindings/interconnect/qcom,sdx75.h index e903f5f3dd8f..0746f1704ec0 100644 --- a/include/dt-bindings/interconnect/qcom,sdx75.h +++ b/include/dt-bindings/interconnect/qcom,sdx75.h @@ -6,10 +6,8 @@ #ifndef __DT_BINDINGS_INTERCONNECT_QCOM_SDX75_H #define __DT_BINDINGS_INTERCONNECT_QCOM_SDX75_H -#define MASTER_QPIC_CORE 0 -#define MASTER_QUP_CORE_0 1 -#define SLAVE_QPIC_CORE 2 -#define SLAVE_QUP_CORE_0 3 +#define MASTER_QUP_CORE_0 0 +#define SLAVE_QUP_CORE_0 1 #define MASTER_LLCC 0 #define SLAVE_EBI1 1 -- 2.39.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: interconnect: qcom: drop QPIC_CORE IDs 2024-11-21 17:27 ` [PATCH 1/2] dt-bindings: interconnect: qcom: drop QPIC_CORE IDs Raviteja Laggyshetty @ 2024-11-21 17:39 ` Krzysztof Kozlowski 2024-11-21 22:01 ` Dmitry Baryshkov 1 sibling, 0 replies; 8+ messages in thread From: Krzysztof Kozlowski @ 2024-11-21 17:39 UTC (permalink / raw) To: Raviteja Laggyshetty, Georgi Djakov, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: Odelu Kukatla, Mike Tipton, linux-arm-msm, linux-pm, devicetree, linux-kernel On 21/11/2024 18:27, Raviteja Laggyshetty wrote: > QPIC resources are modeled as clks, therefore remove corresponding s/clks/clocks/ > defines from the binding as they're unused. As clocks where? Details are needed since you are affecting the ABI. > > Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@quicinc.com> > --- > include/dt-bindings/interconnect/qcom,sdx75.h | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > This does not build. ../drivers/interconnect/qcom/sdx75.c:906:10: error: ‘MASTER_QPIC_CORE’ undeclared here (not in a function); did you mean ‘MASTER_QPIC’? Best regards, Krzysztof ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: interconnect: qcom: drop QPIC_CORE IDs 2024-11-21 17:27 ` [PATCH 1/2] dt-bindings: interconnect: qcom: drop QPIC_CORE IDs Raviteja Laggyshetty 2024-11-21 17:39 ` Krzysztof Kozlowski @ 2024-11-21 22:01 ` Dmitry Baryshkov 1 sibling, 0 replies; 8+ messages in thread From: Dmitry Baryshkov @ 2024-11-21 22:01 UTC (permalink / raw) To: Raviteja Laggyshetty Cc: Georgi Djakov, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Odelu Kukatla, Mike Tipton, linux-arm-msm, linux-pm, devicetree, linux-kernel On Thu, Nov 21, 2024 at 05:27:36PM +0000, Raviteja Laggyshetty wrote: > QPIC resources are modeled as clks, therefore remove corresponding > defines from the binding as they're unused. > > Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@quicinc.com> > --- > include/dt-bindings/interconnect/qcom,sdx75.h | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/include/dt-bindings/interconnect/qcom,sdx75.h b/include/dt-bindings/interconnect/qcom,sdx75.h > index e903f5f3dd8f..0746f1704ec0 100644 > --- a/include/dt-bindings/interconnect/qcom,sdx75.h > +++ b/include/dt-bindings/interconnect/qcom,sdx75.h > @@ -6,10 +6,8 @@ > #ifndef __DT_BINDINGS_INTERCONNECT_QCOM_SDX75_H > #define __DT_BINDINGS_INTERCONNECT_QCOM_SDX75_H > > -#define MASTER_QPIC_CORE 0 > -#define MASTER_QUP_CORE_0 1 > -#define SLAVE_QPIC_CORE 2 > -#define SLAVE_QUP_CORE_0 3 > +#define MASTER_QUP_CORE_0 0 > +#define SLAVE_QUP_CORE_0 1 This changes the ABI of the driver. If this intended, please provide a reason for that. Otherwise you can not change the values for the existing defines. > > #define MASTER_LLCC 0 > #define SLAVE_EBI1 1 > -- > 2.39.2 > -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] interconnect: qcom: sdx75: Drop QP0 related interconnect and BCM nodes 2024-11-21 17:27 [PATCH 0/2] Drop QPIC related interconnect and BCM nodes on Raviteja Laggyshetty 2024-11-21 17:27 ` [PATCH 1/2] dt-bindings: interconnect: qcom: drop QPIC_CORE IDs Raviteja Laggyshetty @ 2024-11-21 17:27 ` Raviteja Laggyshetty 2024-11-21 22:02 ` Dmitry Baryshkov ` (2 more replies) 1 sibling, 3 replies; 8+ messages in thread From: Raviteja Laggyshetty @ 2024-11-21 17:27 UTC (permalink / raw) To: Georgi Djakov, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: Odelu Kukatla, Mike Tipton, linux-arm-msm, linux-pm, devicetree, linux-kernel QP0 resource on sdx75 is managed by clk-rpmh. There are no interconnect clients voting for QP0, hence dropping the redundant nodes from topolgy to avoid the risk of overriding the vote placed on QP0 using clk-rpmh. Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@quicinc.com> --- drivers/interconnect/qcom/sdx75.c | 25 ------- drivers/interconnect/qcom/sdx75.h | 118 +++++++++++++++--------------- 2 files changed, 58 insertions(+), 85 deletions(-) diff --git a/drivers/interconnect/qcom/sdx75.c b/drivers/interconnect/qcom/sdx75.c index 7ef1f17f3292..4afcdc5f25a7 100644 --- a/drivers/interconnect/qcom/sdx75.c +++ b/drivers/interconnect/qcom/sdx75.c @@ -16,15 +16,6 @@ #include "icc-rpmh.h" #include "sdx75.h" -static struct qcom_icc_node qpic_core_master = { - .name = "qpic_core_master", - .id = SDX75_MASTER_QPIC_CORE, - .channels = 1, - .buswidth = 4, - .num_links = 1, - .links = { SDX75_SLAVE_QPIC_CORE }, -}; - static struct qcom_icc_node qup0_core_master = { .name = "qup0_core_master", .id = SDX75_MASTER_QUP_CORE_0, @@ -375,14 +366,6 @@ static struct qcom_icc_node xm_usb3 = { .links = { SDX75_SLAVE_A1NOC_CFG }, }; -static struct qcom_icc_node qpic_core_slave = { - .name = "qpic_core_slave", - .id = SDX75_SLAVE_QPIC_CORE, - .channels = 1, - .buswidth = 4, - .num_links = 0, -}; - static struct qcom_icc_node qup0_core_slave = { .name = "qup0_core_slave", .id = SDX75_SLAVE_QUP_CORE_0, @@ -831,12 +814,6 @@ static struct qcom_icc_bcm bcm_mc0 = { .nodes = { &ebi }, }; -static struct qcom_icc_bcm bcm_qp0 = { - .name = "QP0", - .num_nodes = 1, - .nodes = { &qpic_core_slave }, -}; - static struct qcom_icc_bcm bcm_qup0 = { .name = "QUP0", .keepalive = true, @@ -903,9 +880,7 @@ static struct qcom_icc_bcm * const clk_virt_bcms[] = { }; static struct qcom_icc_node * const clk_virt_nodes[] = { - [MASTER_QPIC_CORE] = &qpic_core_master, [MASTER_QUP_CORE_0] = &qup0_core_master, - [SLAVE_QPIC_CORE] = &qpic_core_slave, [SLAVE_QUP_CORE_0] = &qup0_core_slave, }; diff --git a/drivers/interconnect/qcom/sdx75.h b/drivers/interconnect/qcom/sdx75.h index 24e887159920..3fd2bfcdce84 100644 --- a/drivers/interconnect/qcom/sdx75.h +++ b/drivers/interconnect/qcom/sdx75.h @@ -33,65 +33,63 @@ #define SDX75_MASTER_QDSS_ETR 24 #define SDX75_MASTER_QDSS_ETR_1 25 #define SDX75_MASTER_QPIC 26 -#define SDX75_MASTER_QPIC_CORE 27 -#define SDX75_MASTER_QUP_0 28 -#define SDX75_MASTER_QUP_CORE_0 29 -#define SDX75_MASTER_SDCC_1 30 -#define SDX75_MASTER_SDCC_4 31 -#define SDX75_MASTER_SNOC_CFG 32 -#define SDX75_MASTER_SNOC_SF_MEM_NOC 33 -#define SDX75_MASTER_SYS_TCU 34 -#define SDX75_MASTER_USB3_0 35 -#define SDX75_SLAVE_A1NOC_CFG 36 -#define SDX75_SLAVE_ANOC_PCIE_GEM_NOC 37 -#define SDX75_SLAVE_AUDIO 38 -#define SDX75_SLAVE_CLK_CTL 39 -#define SDX75_SLAVE_CRYPTO_0_CFG 40 -#define SDX75_SLAVE_CNOC_MSS 41 -#define SDX75_SLAVE_DDRSS_CFG 42 -#define SDX75_SLAVE_EBI1 43 -#define SDX75_SLAVE_ETH0_CFG 44 -#define SDX75_SLAVE_ETH1_CFG 45 -#define SDX75_SLAVE_GEM_NOC_CFG 46 -#define SDX75_SLAVE_GEM_NOC_CNOC 47 -#define SDX75_SLAVE_ICBDI_MVMSS_CFG 48 -#define SDX75_SLAVE_IMEM 49 -#define SDX75_SLAVE_IMEM_CFG 50 -#define SDX75_SLAVE_IPA_CFG 51 -#define SDX75_SLAVE_IPC_ROUTER_CFG 52 -#define SDX75_SLAVE_LAGG_CFG 53 -#define SDX75_SLAVE_LLCC 54 -#define SDX75_SLAVE_MCCC_MASTER 55 -#define SDX75_SLAVE_MEM_NOC_PCIE_SNOC 56 -#define SDX75_SLAVE_PCIE_0 57 -#define SDX75_SLAVE_PCIE_1 58 -#define SDX75_SLAVE_PCIE_2 59 -#define SDX75_SLAVE_PCIE_0_CFG 60 -#define SDX75_SLAVE_PCIE_1_CFG 61 -#define SDX75_SLAVE_PCIE_2_CFG 62 -#define SDX75_SLAVE_PCIE_ANOC_CFG 63 -#define SDX75_SLAVE_PCIE_RSC_CFG 64 -#define SDX75_SLAVE_PDM 65 -#define SDX75_SLAVE_PRNG 66 -#define SDX75_SLAVE_QDSS_CFG 67 -#define SDX75_SLAVE_QDSS_STM 68 -#define SDX75_SLAVE_QPIC 69 -#define SDX75_SLAVE_QPIC_CORE 70 -#define SDX75_SLAVE_QUP_0 71 -#define SDX75_SLAVE_QUP_CORE_0 72 -#define SDX75_SLAVE_SDCC_1 73 -#define SDX75_SLAVE_SDCC_4 74 -#define SDX75_SLAVE_SERVICE_GEM_NOC 75 -#define SDX75_SLAVE_SERVICE_PCIE_ANOC 76 -#define SDX75_SLAVE_SERVICE_SNOC 77 -#define SDX75_SLAVE_SNOC_CFG 78 -#define SDX75_SLAVE_SNOC_GEM_NOC_SF 79 -#define SDX75_SLAVE_SNOOP_BWMON 80 -#define SDX75_SLAVE_SPMI_VGI_COEX 81 -#define SDX75_SLAVE_TCSR 82 -#define SDX75_SLAVE_TCU 83 -#define SDX75_SLAVE_TLMM 84 -#define SDX75_SLAVE_USB3 85 -#define SDX75_SLAVE_USB3_PHY_CFG 86 +#define SDX75_MASTER_QUP_0 27 +#define SDX75_MASTER_QUP_CORE_0 28 +#define SDX75_MASTER_SDCC_1 29 +#define SDX75_MASTER_SDCC_4 30 +#define SDX75_MASTER_SNOC_CFG 31 +#define SDX75_MASTER_SNOC_SF_MEM_NOC 32 +#define SDX75_MASTER_SYS_TCU 33 +#define SDX75_MASTER_USB3_0 34 +#define SDX75_SLAVE_A1NOC_CFG 35 +#define SDX75_SLAVE_ANOC_PCIE_GEM_NOC 36 +#define SDX75_SLAVE_AUDIO 37 +#define SDX75_SLAVE_CLK_CTL 38 +#define SDX75_SLAVE_CRYPTO_0_CFG 39 +#define SDX75_SLAVE_CNOC_MSS 40 +#define SDX75_SLAVE_DDRSS_CFG 41 +#define SDX75_SLAVE_EBI1 42 +#define SDX75_SLAVE_ETH0_CFG 43 +#define SDX75_SLAVE_ETH1_CFG 44 +#define SDX75_SLAVE_GEM_NOC_CFG 45 +#define SDX75_SLAVE_GEM_NOC_CNOC 46 +#define SDX75_SLAVE_ICBDI_MVMSS_CFG 47 +#define SDX75_SLAVE_IMEM 48 +#define SDX75_SLAVE_IMEM_CFG 49 +#define SDX75_SLAVE_IPA_CFG 50 +#define SDX75_SLAVE_IPC_ROUTER_CFG 51 +#define SDX75_SLAVE_LAGG_CFG 52 +#define SDX75_SLAVE_LLCC 53 +#define SDX75_SLAVE_MCCC_MASTER 54 +#define SDX75_SLAVE_MEM_NOC_PCIE_SNOC 55 +#define SDX75_SLAVE_PCIE_0 56 +#define SDX75_SLAVE_PCIE_1 57 +#define SDX75_SLAVE_PCIE_2 58 +#define SDX75_SLAVE_PCIE_0_CFG 59 +#define SDX75_SLAVE_PCIE_1_CFG 60 +#define SDX75_SLAVE_PCIE_2_CFG 61 +#define SDX75_SLAVE_PCIE_ANOC_CFG 62 +#define SDX75_SLAVE_PCIE_RSC_CFG 63 +#define SDX75_SLAVE_PDM 64 +#define SDX75_SLAVE_PRNG 65 +#define SDX75_SLAVE_QDSS_CFG 66 +#define SDX75_SLAVE_QDSS_STM 67 +#define SDX75_SLAVE_QPIC 68 +#define SDX75_SLAVE_QUP_0 69 +#define SDX75_SLAVE_QUP_CORE_0 70 +#define SDX75_SLAVE_SDCC_1 71 +#define SDX75_SLAVE_SDCC_4 72 +#define SDX75_SLAVE_SERVICE_GEM_NOC 73 +#define SDX75_SLAVE_SERVICE_PCIE_ANOC 74 +#define SDX75_SLAVE_SERVICE_SNOC 75 +#define SDX75_SLAVE_SNOC_CFG 76 +#define SDX75_SLAVE_SNOC_GEM_NOC_SF 77 +#define SDX75_SLAVE_SNOOP_BWMON 78 +#define SDX75_SLAVE_SPMI_VGI_COEX 79 +#define SDX75_SLAVE_TCSR 80 +#define SDX75_SLAVE_TCU 81 +#define SDX75_SLAVE_TLMM 82 +#define SDX75_SLAVE_USB3 83 +#define SDX75_SLAVE_USB3_PHY_CFG 84 #endif -- 2.39.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] interconnect: qcom: sdx75: Drop QP0 related interconnect and BCM nodes 2024-11-21 17:27 ` [PATCH 2/2] interconnect: qcom: sdx75: Drop QP0 related interconnect and BCM nodes Raviteja Laggyshetty @ 2024-11-21 22:02 ` Dmitry Baryshkov 2024-11-22 8:42 ` kernel test robot 2024-11-23 10:36 ` kernel test robot 2 siblings, 0 replies; 8+ messages in thread From: Dmitry Baryshkov @ 2024-11-21 22:02 UTC (permalink / raw) To: Raviteja Laggyshetty Cc: Georgi Djakov, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Odelu Kukatla, Mike Tipton, linux-arm-msm, linux-pm, devicetree, linux-kernel On Thu, Nov 21, 2024 at 05:27:37PM +0000, Raviteja Laggyshetty wrote: > QP0 resource on sdx75 is managed by clk-rpmh. > There are no interconnect clients voting for QP0, hence dropping the > redundant nodes from topolgy to avoid the risk of overriding the vote > placed on QP0 using clk-rpmh. > > Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@quicinc.com> > --- > drivers/interconnect/qcom/sdx75.c | 25 ------- > drivers/interconnect/qcom/sdx75.h | 118 +++++++++++++++--------------- > 2 files changed, 58 insertions(+), 85 deletions(-) > > diff --git a/drivers/interconnect/qcom/sdx75.c b/drivers/interconnect/qcom/sdx75.c > index 7ef1f17f3292..4afcdc5f25a7 100644 > --- a/drivers/interconnect/qcom/sdx75.c > +++ b/drivers/interconnect/qcom/sdx75.c > @@ -16,15 +16,6 @@ > #include "icc-rpmh.h" > #include "sdx75.h" > > -static struct qcom_icc_node qpic_core_master = { > - .name = "qpic_core_master", > - .id = SDX75_MASTER_QPIC_CORE, > - .channels = 1, > - .buswidth = 4, > - .num_links = 1, > - .links = { SDX75_SLAVE_QPIC_CORE }, > -}; > - > static struct qcom_icc_node qup0_core_master = { > .name = "qup0_core_master", > .id = SDX75_MASTER_QUP_CORE_0, > @@ -375,14 +366,6 @@ static struct qcom_icc_node xm_usb3 = { > .links = { SDX75_SLAVE_A1NOC_CFG }, > }; > > -static struct qcom_icc_node qpic_core_slave = { > - .name = "qpic_core_slave", > - .id = SDX75_SLAVE_QPIC_CORE, > - .channels = 1, > - .buswidth = 4, > - .num_links = 0, > -}; > - > static struct qcom_icc_node qup0_core_slave = { > .name = "qup0_core_slave", > .id = SDX75_SLAVE_QUP_CORE_0, > @@ -831,12 +814,6 @@ static struct qcom_icc_bcm bcm_mc0 = { > .nodes = { &ebi }, > }; > > -static struct qcom_icc_bcm bcm_qp0 = { > - .name = "QP0", > - .num_nodes = 1, > - .nodes = { &qpic_core_slave }, > -}; > - > static struct qcom_icc_bcm bcm_qup0 = { > .name = "QUP0", > .keepalive = true, > @@ -903,9 +880,7 @@ static struct qcom_icc_bcm * const clk_virt_bcms[] = { > }; > > static struct qcom_icc_node * const clk_virt_nodes[] = { > - [MASTER_QPIC_CORE] = &qpic_core_master, > [MASTER_QUP_CORE_0] = &qup0_core_master, > - [SLAVE_QPIC_CORE] = &qpic_core_slave, > [SLAVE_QUP_CORE_0] = &qup0_core_slave, > }; > > diff --git a/drivers/interconnect/qcom/sdx75.h b/drivers/interconnect/qcom/sdx75.h > index 24e887159920..3fd2bfcdce84 100644 > --- a/drivers/interconnect/qcom/sdx75.h > +++ b/drivers/interconnect/qcom/sdx75.h > @@ -33,65 +33,63 @@ > #define SDX75_MASTER_QDSS_ETR 24 > #define SDX75_MASTER_QDSS_ETR_1 25 > #define SDX75_MASTER_QPIC 26 > -#define SDX75_MASTER_QPIC_CORE 27 What prompts renumbering of all the nodes? From my POV it's perfectly fine to keep the indices with the holes in them. > -#define SDX75_MASTER_QUP_0 28 > -#define SDX75_MASTER_QUP_CORE_0 29 > -#define SDX75_MASTER_SDCC_1 30 > -#define SDX75_MASTER_SDCC_4 31 > -#define SDX75_MASTER_SNOC_CFG 32 > -#define SDX75_MASTER_SNOC_SF_MEM_NOC 33 > -#define SDX75_MASTER_SYS_TCU 34 > -#define SDX75_MASTER_USB3_0 35 > -#define SDX75_SLAVE_A1NOC_CFG 36 > -#define SDX75_SLAVE_ANOC_PCIE_GEM_NOC 37 > -#define SDX75_SLAVE_AUDIO 38 > -#define SDX75_SLAVE_CLK_CTL 39 > -#define SDX75_SLAVE_CRYPTO_0_CFG 40 > -#define SDX75_SLAVE_CNOC_MSS 41 > -#define SDX75_SLAVE_DDRSS_CFG 42 > -#define SDX75_SLAVE_EBI1 43 > -#define SDX75_SLAVE_ETH0_CFG 44 > -#define SDX75_SLAVE_ETH1_CFG 45 > -#define SDX75_SLAVE_GEM_NOC_CFG 46 > -#define SDX75_SLAVE_GEM_NOC_CNOC 47 > -#define SDX75_SLAVE_ICBDI_MVMSS_CFG 48 > -#define SDX75_SLAVE_IMEM 49 > -#define SDX75_SLAVE_IMEM_CFG 50 > -#define SDX75_SLAVE_IPA_CFG 51 > -#define SDX75_SLAVE_IPC_ROUTER_CFG 52 > -#define SDX75_SLAVE_LAGG_CFG 53 > -#define SDX75_SLAVE_LLCC 54 > -#define SDX75_SLAVE_MCCC_MASTER 55 > -#define SDX75_SLAVE_MEM_NOC_PCIE_SNOC 56 > -#define SDX75_SLAVE_PCIE_0 57 > -#define SDX75_SLAVE_PCIE_1 58 > -#define SDX75_SLAVE_PCIE_2 59 > -#define SDX75_SLAVE_PCIE_0_CFG 60 > -#define SDX75_SLAVE_PCIE_1_CFG 61 > -#define SDX75_SLAVE_PCIE_2_CFG 62 > -#define SDX75_SLAVE_PCIE_ANOC_CFG 63 > -#define SDX75_SLAVE_PCIE_RSC_CFG 64 > -#define SDX75_SLAVE_PDM 65 > -#define SDX75_SLAVE_PRNG 66 > -#define SDX75_SLAVE_QDSS_CFG 67 > -#define SDX75_SLAVE_QDSS_STM 68 > -#define SDX75_SLAVE_QPIC 69 > -#define SDX75_SLAVE_QPIC_CORE 70 > -#define SDX75_SLAVE_QUP_0 71 > -#define SDX75_SLAVE_QUP_CORE_0 72 > -#define SDX75_SLAVE_SDCC_1 73 > -#define SDX75_SLAVE_SDCC_4 74 > -#define SDX75_SLAVE_SERVICE_GEM_NOC 75 > -#define SDX75_SLAVE_SERVICE_PCIE_ANOC 76 > -#define SDX75_SLAVE_SERVICE_SNOC 77 > -#define SDX75_SLAVE_SNOC_CFG 78 > -#define SDX75_SLAVE_SNOC_GEM_NOC_SF 79 > -#define SDX75_SLAVE_SNOOP_BWMON 80 > -#define SDX75_SLAVE_SPMI_VGI_COEX 81 > -#define SDX75_SLAVE_TCSR 82 > -#define SDX75_SLAVE_TCU 83 > -#define SDX75_SLAVE_TLMM 84 > -#define SDX75_SLAVE_USB3 85 > -#define SDX75_SLAVE_USB3_PHY_CFG 86 > +#define SDX75_MASTER_QUP_0 27 > +#define SDX75_MASTER_QUP_CORE_0 28 > +#define SDX75_MASTER_SDCC_1 29 > +#define SDX75_MASTER_SDCC_4 30 > +#define SDX75_MASTER_SNOC_CFG 31 > +#define SDX75_MASTER_SNOC_SF_MEM_NOC 32 > +#define SDX75_MASTER_SYS_TCU 33 > +#define SDX75_MASTER_USB3_0 34 > +#define SDX75_SLAVE_A1NOC_CFG 35 > +#define SDX75_SLAVE_ANOC_PCIE_GEM_NOC 36 > +#define SDX75_SLAVE_AUDIO 37 > +#define SDX75_SLAVE_CLK_CTL 38 > +#define SDX75_SLAVE_CRYPTO_0_CFG 39 > +#define SDX75_SLAVE_CNOC_MSS 40 > +#define SDX75_SLAVE_DDRSS_CFG 41 > +#define SDX75_SLAVE_EBI1 42 > +#define SDX75_SLAVE_ETH0_CFG 43 > +#define SDX75_SLAVE_ETH1_CFG 44 > +#define SDX75_SLAVE_GEM_NOC_CFG 45 > +#define SDX75_SLAVE_GEM_NOC_CNOC 46 > +#define SDX75_SLAVE_ICBDI_MVMSS_CFG 47 > +#define SDX75_SLAVE_IMEM 48 > +#define SDX75_SLAVE_IMEM_CFG 49 > +#define SDX75_SLAVE_IPA_CFG 50 > +#define SDX75_SLAVE_IPC_ROUTER_CFG 51 > +#define SDX75_SLAVE_LAGG_CFG 52 > +#define SDX75_SLAVE_LLCC 53 > +#define SDX75_SLAVE_MCCC_MASTER 54 > +#define SDX75_SLAVE_MEM_NOC_PCIE_SNOC 55 > +#define SDX75_SLAVE_PCIE_0 56 > +#define SDX75_SLAVE_PCIE_1 57 > +#define SDX75_SLAVE_PCIE_2 58 > +#define SDX75_SLAVE_PCIE_0_CFG 59 > +#define SDX75_SLAVE_PCIE_1_CFG 60 > +#define SDX75_SLAVE_PCIE_2_CFG 61 > +#define SDX75_SLAVE_PCIE_ANOC_CFG 62 > +#define SDX75_SLAVE_PCIE_RSC_CFG 63 > +#define SDX75_SLAVE_PDM 64 > +#define SDX75_SLAVE_PRNG 65 > +#define SDX75_SLAVE_QDSS_CFG 66 > +#define SDX75_SLAVE_QDSS_STM 67 > +#define SDX75_SLAVE_QPIC 68 > +#define SDX75_SLAVE_QUP_0 69 > +#define SDX75_SLAVE_QUP_CORE_0 70 > +#define SDX75_SLAVE_SDCC_1 71 > +#define SDX75_SLAVE_SDCC_4 72 > +#define SDX75_SLAVE_SERVICE_GEM_NOC 73 > +#define SDX75_SLAVE_SERVICE_PCIE_ANOC 74 > +#define SDX75_SLAVE_SERVICE_SNOC 75 > +#define SDX75_SLAVE_SNOC_CFG 76 > +#define SDX75_SLAVE_SNOC_GEM_NOC_SF 77 > +#define SDX75_SLAVE_SNOOP_BWMON 78 > +#define SDX75_SLAVE_SPMI_VGI_COEX 79 > +#define SDX75_SLAVE_TCSR 80 > +#define SDX75_SLAVE_TCU 81 > +#define SDX75_SLAVE_TLMM 82 > +#define SDX75_SLAVE_USB3 83 > +#define SDX75_SLAVE_USB3_PHY_CFG 84 > > #endif > -- > 2.39.2 > -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] interconnect: qcom: sdx75: Drop QP0 related interconnect and BCM nodes 2024-11-21 17:27 ` [PATCH 2/2] interconnect: qcom: sdx75: Drop QP0 related interconnect and BCM nodes Raviteja Laggyshetty 2024-11-21 22:02 ` Dmitry Baryshkov @ 2024-11-22 8:42 ` kernel test robot 2024-11-23 10:36 ` kernel test robot 2 siblings, 0 replies; 8+ messages in thread From: kernel test robot @ 2024-11-22 8:42 UTC (permalink / raw) To: Raviteja Laggyshetty, Georgi Djakov, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: llvm, oe-kbuild-all, Odelu Kukatla, Mike Tipton, linux-arm-msm, linux-pm, devicetree, linux-kernel Hi Raviteja, kernel test robot noticed the following build errors: [auto build test ERROR on robh/for-next] [also build test ERROR on linus/master v6.12 next-20241121] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Raviteja-Laggyshetty/dt-bindings-interconnect-qcom-drop-QPIC_CORE-IDs/20241122-013857 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next patch link: https://lore.kernel.org/r/20241121172737.255-3-quic_rlaggysh%40quicinc.com patch subject: [PATCH 2/2] interconnect: qcom: sdx75: Drop QP0 related interconnect and BCM nodes config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20241122/202411221619.zJpjlWkH-lkp@intel.com/config) compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 592c0fe55f6d9a811028b5f3507be91458ab2713) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241122/202411221619.zJpjlWkH-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202411221619.zJpjlWkH-lkp@intel.com/ All errors (new ones prefixed by >>): >> drivers/interconnect/qcom/sdx75.c:878:3: error: use of undeclared identifier 'bcm_qp0'; did you mean 'bcm_qup0'? 878 | &bcm_qp0, | ^~~~~~~ | bcm_qup0 drivers/interconnect/qcom/sdx75.c:817:28: note: 'bcm_qup0' declared here 817 | static struct qcom_icc_bcm bcm_qup0 = { | ^ 1 error generated. Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for MODVERSIONS Depends on [n]: MODULES [=y] && !COMPILE_TEST [=y] Selected by [y]: - RANDSTRUCT_FULL [=y] && (CC_HAS_RANDSTRUCT [=y] || GCC_PLUGINS [=n]) && MODULES [=y] vim +878 drivers/interconnect/qcom/sdx75.c 3642b4e5cbfe48 Rohit Agarwal 2023-09-13 876 3642b4e5cbfe48 Rohit Agarwal 2023-09-13 877 static struct qcom_icc_bcm * const clk_virt_bcms[] = { 3642b4e5cbfe48 Rohit Agarwal 2023-09-13 @878 &bcm_qp0, 3642b4e5cbfe48 Rohit Agarwal 2023-09-13 879 &bcm_qup0, 3642b4e5cbfe48 Rohit Agarwal 2023-09-13 880 }; 3642b4e5cbfe48 Rohit Agarwal 2023-09-13 881 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] interconnect: qcom: sdx75: Drop QP0 related interconnect and BCM nodes 2024-11-21 17:27 ` [PATCH 2/2] interconnect: qcom: sdx75: Drop QP0 related interconnect and BCM nodes Raviteja Laggyshetty 2024-11-21 22:02 ` Dmitry Baryshkov 2024-11-22 8:42 ` kernel test robot @ 2024-11-23 10:36 ` kernel test robot 2 siblings, 0 replies; 8+ messages in thread From: kernel test robot @ 2024-11-23 10:36 UTC (permalink / raw) To: Raviteja Laggyshetty, Georgi Djakov, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: oe-kbuild-all, Odelu Kukatla, Mike Tipton, linux-arm-msm, linux-pm, devicetree, linux-kernel Hi Raviteja, kernel test robot noticed the following build errors: [auto build test ERROR on robh/for-next] [also build test ERROR on linus/master v6.12 next-20241122] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Raviteja-Laggyshetty/dt-bindings-interconnect-qcom-drop-QPIC_CORE-IDs/20241122-013857 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next patch link: https://lore.kernel.org/r/20241121172737.255-3-quic_rlaggysh%40quicinc.com patch subject: [PATCH 2/2] interconnect: qcom: sdx75: Drop QP0 related interconnect and BCM nodes config: arm-allmodconfig (https://download.01.org/0day-ci/archive/20241123/202411232022.F33FHrZo-lkp@intel.com/config) compiler: arm-linux-gnueabi-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241123/202411232022.F33FHrZo-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202411232022.F33FHrZo-lkp@intel.com/ All errors (new ones prefixed by >>): >> drivers/interconnect/qcom/sdx75.c:878:10: error: 'bcm_qp0' undeclared here (not in a function); did you mean 'bcm_qup0'? 878 | &bcm_qp0, | ^~~~~~~ | bcm_qup0 Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for GET_FREE_REGION Depends on [n]: SPARSEMEM [=n] Selected by [m]: - RESOURCE_KUNIT_TEST [=m] && RUNTIME_TESTING_MENU [=y] && KUNIT [=m] vim +878 drivers/interconnect/qcom/sdx75.c 3642b4e5cbfe48 Rohit Agarwal 2023-09-13 876 3642b4e5cbfe48 Rohit Agarwal 2023-09-13 877 static struct qcom_icc_bcm * const clk_virt_bcms[] = { 3642b4e5cbfe48 Rohit Agarwal 2023-09-13 @878 &bcm_qp0, 3642b4e5cbfe48 Rohit Agarwal 2023-09-13 879 &bcm_qup0, 3642b4e5cbfe48 Rohit Agarwal 2023-09-13 880 }; 3642b4e5cbfe48 Rohit Agarwal 2023-09-13 881 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-11-23 10:37 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-11-21 17:27 [PATCH 0/2] Drop QPIC related interconnect and BCM nodes on Raviteja Laggyshetty 2024-11-21 17:27 ` [PATCH 1/2] dt-bindings: interconnect: qcom: drop QPIC_CORE IDs Raviteja Laggyshetty 2024-11-21 17:39 ` Krzysztof Kozlowski 2024-11-21 22:01 ` Dmitry Baryshkov 2024-11-21 17:27 ` [PATCH 2/2] interconnect: qcom: sdx75: Drop QP0 related interconnect and BCM nodes Raviteja Laggyshetty 2024-11-21 22:02 ` Dmitry Baryshkov 2024-11-22 8:42 ` kernel test robot 2024-11-23 10:36 ` kernel test robot
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox