From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: mr.nuke.me@gmail.com, Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/7] dt-bindings: phy: qcom,ipq8074-qmp-pcie: add ipq9574 gen3x2 PHY
Date: Wed, 10 Apr 2024 08:59:31 +0200 [thread overview]
Message-ID: <2379377e-ca1c-453f-bb74-186ab738ce39@linaro.org> (raw)
In-Reply-To: <33461c22-21a3-023b-4750-c69304471ea8@gmail.com>
On 09/04/2024 22:19, mr.nuke.me@gmail.com wrote:
>>
>>
>>>
>>> clock-names:
>>> items:
>>> - const: aux
>>> - const: cfg_ahb
>>> - const: pipe
>>> + - const: anoc
>>> + - const: snoc
>>
>> OK, you did not test it. Neither this, nor DTS. I stop review, please
>> test first.
>
> I ran both `checkpatch.pl` and `make dt_binding_check`. What in this
> patch makes you say I "did not test it", and what test or tests did I miss?
>
... and no, you did not. If you tested, you would easily see error:
clock-names: ['aux', 'cfg_ahb', 'pipe'] is too short
When you receive comment from reviewer, please investigate thoroughly
what could get wrong. Don't answer just to get rid of reviewer. It's
fine to make mistakes, but if reviewer points to issue and you
immediately respond "no issue", that's waste of my time.
Look at entire code of qcom,pcie how it is organized. Or:
https://elixir.bootlin.com/linux/v6.8/source/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml#L132
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-10 6:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240409190833.3485824-1-mr.nuke.me@gmail.com>
2024-04-09 19:08 ` [PATCH v2 1/7] dt-bindings: clock: Add PCIe pipe related clocks for IPQ9574 Alexandru Gagniuc
2024-04-09 19:08 ` [PATCH v2 2/7] clk: qcom: gcc-ipq9574: Add PCIe pipe clocks Alexandru Gagniuc
2024-04-09 19:08 ` [PATCH v2 3/7] dt-bindings: PCI: qcom: Add IPQ9574 PCIe controller Alexandru Gagniuc
2024-04-09 20:08 ` Krzysztof Kozlowski
2024-04-11 18:00 ` mr.nuke.me
2024-04-11 19:09 ` Krzysztof Kozlowski
2024-04-09 19:08 ` [PATCH v2 4/7] PCI: qcom: Add support for IPQ9574 Alexandru Gagniuc
2024-04-10 11:50 ` Konrad Dybcio
2024-04-17 7:05 ` Manivannan Sadhasivam
2024-04-09 19:08 ` [PATCH v2 5/7] dt-bindings: phy: qcom,ipq8074-qmp-pcie: add ipq9574 gen3x2 PHY Alexandru Gagniuc
2024-04-09 20:09 ` Krzysztof Kozlowski
2024-04-09 20:19 ` mr.nuke.me
2024-04-09 20:28 ` Krzysztof Kozlowski
2024-04-10 6:59 ` Krzysztof Kozlowski [this message]
2024-04-10 7:02 ` Krzysztof Kozlowski
2024-04-10 16:29 ` mr.nuke.me
2024-04-10 19:36 ` Krzysztof Kozlowski
2024-04-11 17:24 ` mr.nuke.me
2024-04-11 19:08 ` Krzysztof Kozlowski
2024-04-09 20:49 ` Rob Herring
2024-04-09 19:08 ` [PATCH v2 6/7] phy: qcom-qmp-pcie: add support for " Alexandru Gagniuc
2024-04-09 19:08 ` [PATCH v2 7/7] arm64: dts: qcom: ipq9574: add PCIe2 nodes Alexandru Gagniuc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2379377e-ca1c-453f-bb74-186ab738ce39@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mr.nuke.me@gmail.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox