Re: [PATCH 06/12] drm/msm: dpu: Remove power_handle from core_perf

[Jeykumar Sankaran <jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>]

On 2018-11-12 11:42, Sean Paul wrote:
> From: Sean Paul <seanpaul@chromium.org>
> 
> It's unused
> 
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> ---

Reviewed-by: Jeykumar Sankaran <jsanka@codeaurora.org>

>  drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 3 ---
>  drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 5 -----
>  drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c       | 1 -
>  3 files changed, 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
> index 22e84b3d7f98..ef6dd43f8bec 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
> @@ -605,7 +605,6 @@ void dpu_core_perf_destroy(struct dpu_core_perf 
> *perf)
>  	dpu_core_perf_debugfs_destroy(perf);
>  	perf->max_core_clk_rate = 0;
>  	perf->core_clk = NULL;
> -	perf->phandle = NULL;
>  	perf->catalog = NULL;
>  	perf->dev = NULL;
>  }
> @@ -613,12 +612,10 @@ void dpu_core_perf_destroy(struct dpu_core_perf
> *perf)
>  int dpu_core_perf_init(struct dpu_core_perf *perf,
>  		struct drm_device *dev,
>  		struct dpu_mdss_cfg *catalog,
> -		struct dpu_power_handle *phandle,
>  		struct dss_clk *core_clk)
>  {
>  	perf->dev = dev;
>  	perf->catalog = catalog;
> -	perf->phandle = phandle;
>  	perf->core_clk = core_clk;
> 
>  	perf->max_core_clk_rate = core_clk->max_rate;
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h
> index fbcbe0c7527a..68b84d85eb8f 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h
> @@ -19,7 +19,6 @@
>  #include <drm/drm_crtc.h>
> 
>  #include "dpu_hw_catalog.h"
> -#include "dpu_power_handle.h"
> 
>  #define	DPU_PERF_DEFAULT_MAX_CORE_CLK_RATE	412500000
> 
> @@ -52,7 +51,6 @@ struct dpu_core_perf_tune {
>   * @dev: Pointer to drm device
>   * @debugfs_root: top level debug folder
>   * @catalog: Pointer to catalog configuration
> - * @phandle: Pointer to power handler
>   * @core_clk: Pointer to core clock structure
>   * @core_clk_rate: current core clock rate
>   * @max_core_clk_rate: maximum allowable core clock rate
> @@ -66,7 +64,6 @@ struct dpu_core_perf {
>  	struct drm_device *dev;
>  	struct dentry *debugfs_root;
>  	struct dpu_mdss_cfg *catalog;
> -	struct dpu_power_handle *phandle;
>  	struct dss_clk *core_clk;
>  	u64 core_clk_rate;
>  	u64 max_core_clk_rate;
> @@ -113,13 +110,11 @@ void dpu_core_perf_destroy(struct dpu_core_perf
> *perf);
>   * @perf: Pointer to core performance context
>   * @dev: Pointer to drm device
>   * @catalog: Pointer to catalog
> - * @phandle: Pointer to power handle
>   * @core_clk: pointer to core clock
>   */
>  int dpu_core_perf_init(struct dpu_core_perf *perf,
>  		struct drm_device *dev,
>  		struct dpu_mdss_cfg *catalog,
> -		struct dpu_power_handle *phandle,
>  		struct dss_clk *core_clk);
> 
>  /**
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> index 62a02c606811..bae7e86b2913 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> @@ -957,7 +957,6 @@ static int dpu_kms_hw_init(struct msm_kms *kms)
>  	}
> 
>  	rc = dpu_core_perf_init(&dpu_kms->perf, dev, dpu_kms->catalog,
> -			&dpu_kms->phandle,
>  			_dpu_kms_get_clk(dpu_kms, "core"));
>  	if (rc) {
>  		DPU_ERROR("failed to init perf %d\n", rc);

-- 
Jeykumar S
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno