From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Maulik Shah <maulik.shah@oss.qualcomm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: interrupt-controller: qcom,pdc: Document x1p42100 PDC
Date: Wed, 31 Dec 2025 12:52:55 +0100 [thread overview]
Message-ID: <26838d5c-230e-425f-bd38-0160d30b00a0@oss.qualcomm.com> (raw)
In-Reply-To: <209c49fb-04a6-43dc-a3f1-8451e3946d06@kernel.org>
On 12/31/25 11:49 AM, Krzysztof Kozlowski wrote:
> On 31/12/2025 11:18, Maulik Shah wrote:
>> Purwa shares the Hamoa (X1E80100) PDC device, but the hardware register
>
> We don't use Hamoa name in upstream.
(the file is now called hamoa.dtsi)
Konrad
>> bug addressed in commit e9a48ea4d90b ("irqchip/qcom-pdc: Workaround
>> hardware register bug on X1E80100") is already fixed in Purwa silicon.
>>
>> Hamoa compatible forces the software workaround. Add PDC compatible
>> for purwa as "qcom,x1p42100-pdc" to remove the workaround from Purwa.
>>
>> Fixes: f08edb529916 ("arm64: dts: qcom: Add X1P42100 SoC and CRD")
>
> Your are describing wrong bug being fixed... or actually not a bug.
> Every SoC should have dedicated compatible (see writing bindings) and
> missing compatible is not a bug.
>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2025-12-31 11:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-31 10:18 [PATCH 0/2] purwa: Drop the Hamoa PDC workaround from purwa Maulik Shah
2025-12-31 10:18 ` [PATCH 1/2] dt-bindings: interrupt-controller: qcom,pdc: Document x1p42100 PDC Maulik Shah
2025-12-31 10:49 ` Krzysztof Kozlowski
2025-12-31 11:52 ` Konrad Dybcio [this message]
2026-01-02 4:23 ` Maulik Shah (mkshah)
2026-01-02 11:42 ` Krzysztof Kozlowski
2026-01-02 18:35 ` Bjorn Andersson
2025-12-31 10:18 ` [PATCH 2/2] arm64: dts: qcom: purwa: Drop the Hamoa workaround for PDC Maulik Shah
2025-12-31 10:47 ` Krzysztof Kozlowski
2026-01-02 3:58 ` Maulik Shah (mkshah)
2025-12-31 11:54 ` Konrad Dybcio
2026-01-02 3:58 ` Maulik Shah (mkshah)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26838d5c-230e-425f-bd38-0160d30b00a0@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maulik.shah@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox