From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Heiner Kallweit <hkallweit1@gmail.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH] i2c: i2c-boardinfo: Annotate code used in init phase only
Date: Fri, 10 Oct 2025 21:50:34 +0200 [thread overview]
Message-ID: <29ec0082-4dd4-4120-acd2-44b35b4b9487@oss.qualcomm.com> (raw)
In-Reply-To: <8d09aa09-b656-4b69-b01f-3ea40418b7ff@gmail.com>
On 9/14/25 10:24 PM, Heiner Kallweit wrote:
> Annotate two places in boardinfo code:
> - __i2c_first_dynamic_bus_num is set in init phase. Annotate it as
> __ro_after_init to prevent later changes.
> - i2c_register_board_info() is used in init phase only, so annotate it
> as __init, allowing to free the memory after init phase.
> This is safe, see comment: "done in board-specific init code near
> arch_initcall() time"
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
Hi, this seems to break booting on Qualcomm X1E80100 Surface Laptop 7
(arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi)
gcc-14.2 and clang-20.x
Funnily enough when I build this (albeit on another computer, but also
with clang-20.x) and boot another X1E80100-based device (x1-crd.dtsi
in the same DT dir), it boots up fine
Konrad
next parent reply other threads:[~2025-10-10 19:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8d09aa09-b656-4b69-b01f-3ea40418b7ff@gmail.com>
2025-10-10 19:50 ` Konrad Dybcio [this message]
2025-10-11 10:33 ` [PATCH] i2c: i2c-boardinfo: Annotate code used in init phase only Wolfram Sang
2025-10-11 16:14 ` Konrad Dybcio
2025-10-18 20:08 ` Heiner Kallweit
2025-10-12 21:05 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29ec0082-4dd4-4120-acd2-44b35b4b9487@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=bjorn.andersson@oss.qualcomm.com \
--cc=hkallweit1@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox