Re: [PATCH] i2c: i2c-boardinfo: Annotate code used in init phase only

Re: [PATCH] i2c: i2c-boardinfo: Annotate code used in init phase only

[Konrad Dybcio]

On 9/14/25 10:24 PM, Heiner Kallweit wrote:
> Annotate two places in boardinfo code:
> - __i2c_first_dynamic_bus_num is set in init phase. Annotate it as
>   __ro_after_init to prevent later changes.
> - i2c_register_board_info() is used in init phase only, so annotate it
>   as __init, allowing to free the memory after init phase.
>   This is safe, see comment: "done in board-specific init code near
>   arch_initcall() time"
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---

Hi, this seems to break booting on Qualcomm X1E80100 Surface Laptop 7
(arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi)

gcc-14.2 and clang-20.x

Funnily enough when I build this (albeit on another computer, but also
with clang-20.x) and boot another X1E80100-based device (x1-crd.dtsi
in the same DT dir), it boots up fine

Konrad

Re: [PATCH] i2c: i2c-boardinfo: Annotate code used in init phase only

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 558 bytes --]

Hi Konrad,

> Hi, this seems to break booting on Qualcomm X1E80100 Surface Laptop 7
> (arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi)
> 
> gcc-14.2 and clang-20.x
> 
> Funnily enough when I build this (albeit on another computer, but also
> with clang-20.x) and boot another X1E80100-based device (x1-crd.dtsi
> in the same DT dir), it boots up fine

I reverted the commit now, but please if you can find out more details
about the boot regression, this would be extremly helpful (maybe
earlycon helps?).

All the best,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] i2c: i2c-boardinfo: Annotate code used in init phase only

[Konrad Dybcio]

On 10/11/25 12:33 PM, Wolfram Sang wrote:
> Hi Konrad,
> 
>> Hi, this seems to break booting on Qualcomm X1E80100 Surface Laptop 7
>> (arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi)
>>
>> gcc-14.2 and clang-20.x
>>
>> Funnily enough when I build this (albeit on another computer, but also
>> with clang-20.x) and boot another X1E80100-based device (x1-crd.dtsi
>> in the same DT dir), it boots up fine
> 
> I reverted the commit now, but please if you can find out more details
> about the boot regression, this would be extremly helpful (maybe
> earlycon helps?).

I'll try to poke at it the upcoming week, thanks

Konrad

Re: [PATCH] i2c: i2c-boardinfo: Annotate code used in init phase only

[Heiner Kallweit]

On 10/11/2025 6:14 PM, Konrad Dybcio wrote:
> On 10/11/25 12:33 PM, Wolfram Sang wrote:
>> Hi Konrad,
>>
>>> Hi, this seems to break booting on Qualcomm X1E80100 Surface Laptop 7
>>> (arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi)
>>>
>>> gcc-14.2 and clang-20.x
>>>
>>> Funnily enough when I build this (albeit on another computer, but also
>>> with clang-20.x) and boot another X1E80100-based device (x1-crd.dtsi
>>> in the same DT dir), it boots up fine
>>
>> I reverted the commit now, but please if you can find out more details
>> about the boot regression, this would be extremly helpful (maybe
>> earlycon helps?).
> 
> I'll try to poke at it the upcoming week, thanks
> 
Any result? It's somewhat unfortunate to revert a change just because of a
vague report w/o evidence / logs / bisect results.

> Konrad

Re: [PATCH] i2c: i2c-boardinfo: Annotate code used in init phase only

[Heiner Kallweit]

On 10/10/2025 9:50 PM, Konrad Dybcio wrote:
> On 9/14/25 10:24 PM, Heiner Kallweit wrote:
>> Annotate two places in boardinfo code:
>> - __i2c_first_dynamic_bus_num is set in init phase. Annotate it as
>>   __ro_after_init to prevent later changes.
>> - i2c_register_board_info() is used in init phase only, so annotate it
>>   as __init, allowing to free the memory after init phase.
>>   This is safe, see comment: "done in board-specific init code near
>>   arch_initcall() time"
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>> ---
> 
> Hi, this seems to break booting on Qualcomm X1E80100 Surface Laptop 7
> (arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi)
> 
What means "seems to break"? Is it or not? Did you bisect?
Where exactly does the boot break/stop?
Can you provide a full dmesg log for success and error case on this device?


> gcc-14.2 and clang-20.x
> 
> Funnily enough when I build this (albeit on another computer, but also
> with clang-20.x) and boot another X1E80100-based device (x1-crd.dtsi
> in the same DT dir), it boots up fine
> 
> Konrad