[PATCH] arm64: dts: qcom: sm8250: Add label for reserved-memory node

[PATCH] arm64: dts: qcom: sm8250: Add label for reserved-memory node

[Alexander Koskovich]

For some devices it makes more sense to just redefine reserved-memory,
for example on the ASUS ROG Phone 3 it is completely different with the
exception of hyp_mem, xbl_aop_mem, cmd_db and smem_mem.

Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
---
 arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index c7dffa440074..3298c36c3e55 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -763,7 +763,7 @@ opp-120000000 {
 		};
 	};
 
-	reserved-memory {
+	reserved_memory: reserved-memory {
 		#address-cells = <2>;
 		#size-cells = <2>;
 		ranges;

---
base-commit: 11439c4635edd669ae435eec308f4ab8a0804808
change-id: 20260308-sm8250-reserved-mem-93fd18152c95

Best regards,
-- 
Alexander Koskovich <akoskovich@pm.me>

Re: [PATCH] arm64: dts: qcom: sm8250: Add label for reserved-memory node

[Krzysztof Kozlowski]

On 08/03/2026 06:05, Alexander Koskovich wrote:
> For some devices it makes more sense to just redefine reserved-memory,
> for example on the ASUS ROG Phone 3 it is completely different with the
> exception of hyp_mem, xbl_aop_mem, cmd_db and smem_mem.
> 
> Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
> ---
>  arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index c7dffa440074..3298c36c3e55 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -763,7 +763,7 @@ opp-120000000 {
>  		};
>  	};
>  
> -	reserved-memory {
> +	reserved_memory: reserved-memory {

There is no user for this, so change is pointless. labels do not exist
in DTBs, so drop the entire patch or provide here - in the same commit -
proper user.

Best regards,
Krzysztof

Re: [PATCH] arm64: dts: qcom: sm8250: Add label for reserved-memory node

[Alexander Koskovich]

On Sunday, March 8th, 2026 at 4:46 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:

> There is no user for this, so change is pointless. labels do not exist
> in DTBs, so drop the entire patch or provide here - in the same commit -
> proper user.

Want to submit the ROG 3 in a follow up change but was trying to get all dependencies for it merged beforehand.

Should I just upload the devicetree and link to relevant patches?

> 
> Best regards,
> Krzysztof
> 
>

Re: [PATCH] arm64: dts: qcom: sm8250: Add label for reserved-memory node

[Dmitry Baryshkov]

On Sun, Mar 08, 2026 at 11:52:07AM +0000, Alexander Koskovich wrote:
> On Sunday, March 8th, 2026 at 4:46 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> 
> > There is no user for this, so change is pointless. labels do not exist
> > in DTBs, so drop the entire patch or provide here - in the same commit -
> > proper user.
> 
> Want to submit the ROG 3 in a follow up change but was trying to get
> all dependencies for it merged beforehand.
> 
> Should I just upload the devicetree and link to relevant patches?

It might be eaiser to submit DT with all DT dependencies in a single
series. Then the reviewers can see the reasons for your changes
and provide a more complete review.

> 
> > 
> > Best regards,
> > Krzysztof
> > 
> >

-- 
With best wishes
Dmitry

Re: [PATCH] arm64: dts: qcom: sm8250: Add label for reserved-memory node

[Konrad Dybcio]

On 3/8/26 3:59 PM, Dmitry Baryshkov wrote:
> On Sun, Mar 08, 2026 at 11:52:07AM +0000, Alexander Koskovich wrote:
>> On Sunday, March 8th, 2026 at 4:46 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>>> There is no user for this, so change is pointless. labels do not exist
>>> in DTBs, so drop the entire patch or provide here - in the same commit -
>>> proper user.
>>
>> Want to submit the ROG 3 in a follow up change but was trying to get
>> all dependencies for it merged beforehand.
>>
>> Should I just upload the devicetree and link to relevant patches?
> 
> It might be eaiser to submit DT with all DT dependencies in a single
> series. Then the reviewers can see the reasons for your changes
> and provide a more complete review.

Such oneliners, I wouldn't even bother putting in a separate commit

Konrad