* [PATCH linux-next] media: venus: hfi: Remove the unneeded result variable
@ 2022-08-30 8:37 cgel.zte
2022-08-30 19:10 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: cgel.zte @ 2022-08-30 8:37 UTC (permalink / raw)
To: mchehab
Cc: stanimir.varbanov, agross, bjorn.andersson, konrad.dybcio,
linux-media, linux-arm-msm, linux-kernel, ye xingchen, Zeal Robot
From: ye xingchen <ye.xingchen@zte.com.cn>
Return the value venus_hfi_create() directly instead of storing it in
another redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
drivers/media/platform/qcom/venus/hfi.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/media/platform/qcom/venus/hfi.c b/drivers/media/platform/qcom/venus/hfi.c
index 1968f09ad177..e00aedb41d16 100644
--- a/drivers/media/platform/qcom/venus/hfi.c
+++ b/drivers/media/platform/qcom/venus/hfi.c
@@ -569,8 +569,6 @@ irqreturn_t hfi_isr(int irq, void *dev)
int hfi_create(struct venus_core *core, const struct hfi_core_ops *ops)
{
- int ret;
-
if (!ops)
return -EINVAL;
@@ -579,9 +577,8 @@ int hfi_create(struct venus_core *core, const struct hfi_core_ops *ops)
core->state = CORE_UNINIT;
init_completion(&core->done);
pkt_set_version(core->res->hfi_version);
- ret = venus_hfi_create(core);
- return ret;
+ return venus_hfi_create(core);
}
void hfi_destroy(struct venus_core *core)
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH linux-next] media: venus: hfi: Remove the unneeded result variable
2022-08-30 8:37 [PATCH linux-next] media: venus: hfi: Remove the unneeded result variable cgel.zte
@ 2022-08-30 19:10 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-30 19:10 UTC (permalink / raw)
To: cgel.zte, mchehab
Cc: stanimir.varbanov, agross, bjorn.andersson, konrad.dybcio,
linux-media, linux-arm-msm, linux-kernel, ye xingchen, Zeal Robot
On 30/08/2022 11:37, cgel.zte@gmail.com wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Return the value venus_hfi_create() directly instead of storing it in
> another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
Reported-by is used for crediting bug reporters. There is no bug here.
Stop abusing the kernel tags.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-30 19:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-30 8:37 [PATCH linux-next] media: venus: hfi: Remove the unneeded result variable cgel.zte
2022-08-30 19:10 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox