From: Neil Armstrong <neil.armstrong@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Luca Weiss <luca@z3ntu.xyz>,
linux-arm-msm@vger.kernel.org
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings
Date: Mon, 26 Sep 2022 12:04:07 +0200 [thread overview]
Message-ID: <3070538e-fa8d-4506-bbf8-c2770d092eb5@linaro.org> (raw)
In-Reply-To: <ec8cc121-9814-cd52-fb49-c33ab1376f89@linaro.org>
On 26/09/2022 11:22, Krzysztof Kozlowski wrote:
> On 25/09/2022 23:02, Luca Weiss wrote:
>> pm8941-misc should be called 'extcon' and pm8941-coincell 'charger'.
>>
>> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
>> ---
>> arch/arm/boot/dts/qcom-pm8941.dtsi | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi b/arch/arm/boot/dts/qcom-pm8941.dtsi
>> index 33517cccee01..01f14d5f314d 100644
>> --- a/arch/arm/boot/dts/qcom-pm8941.dtsi
>> +++ b/arch/arm/boot/dts/qcom-pm8941.dtsi
>> @@ -27,7 +27,7 @@ pwrkey@800 {
>> bias-pull-up;
>> };
>>
>> - usb_id: misc@900 {
>> + usb_id: extcon@900 {
>
> Why? extcon is Linux specific name and should not be added to DTS.
> Anything requires it?
It matches the current dt bindings:
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml:
<snip>
"extcon@[0-9a-f]+$":
type: object
$ref: /schemas/extcon/qcom,pm8941-misc.yaml#
<snip>
Neil
>
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2022-09-26 10:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-25 21:02 [PATCH 1/3] ARM: dts: qcom: pm8226: fix regulators node name Luca Weiss
2022-09-25 21:02 ` [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings Luca Weiss
2022-09-26 8:56 ` Neil Armstrong
2022-09-26 9:22 ` Krzysztof Kozlowski
2022-09-26 10:04 ` Neil Armstrong [this message]
2022-09-26 10:29 ` Krzysztof Kozlowski
2022-09-26 15:07 ` Luca Weiss
2022-09-28 7:24 ` Krzysztof Kozlowski
2022-09-26 15:17 ` Neil Armstrong
2022-09-27 13:07 ` Konrad Dybcio
2022-09-25 21:02 ` [PATCH 3/3] arm64: dts: qcom: pm8998: adjust coincell node name " Luca Weiss
2022-09-26 9:22 ` Krzysztof Kozlowski
2022-09-27 13:07 ` Konrad Dybcio
2022-09-26 8:53 ` [PATCH 1/3] ARM: dts: qcom: pm8226: fix regulators node name Neil Armstrong
2022-09-26 8:56 ` Neil Armstrong
2022-09-26 9:05 ` Krzysztof Kozlowski
2022-09-26 9:12 ` Krzysztof Kozlowski
2022-09-26 9:19 ` Krzysztof Kozlowski
2022-09-27 13:07 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3070538e-fa8d-4506-bbf8-c2770d092eb5@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox