From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Banajit Goswami <bgoswami@quicinc.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: <alsa-devel@alsa-project.org>, <linux-arm-msm@vger.kernel.org>,
<linux-sound@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <quic_rohkumar@quicinc.com>,
<quic_pkumpatl@quicinc.com>,
Konrad Dybcio <konrad.dybcio@linaro.org>
Subject: Re: [RESEND v5 6/7] ASoC: codecs: wcd937x: add capture dapm widgets
Date: Tue, 11 Jun 2024 10:09:52 +0530 [thread overview]
Message-ID: <33772eab-74c6-c5c3-fa25-3a643a2f9c57@quicinc.com> (raw)
In-Reply-To: <ba911ebd-aef5-46af-ace1-84d13bee6876@linaro.org>
On 6/10/2024 12:35 PM, Srinivas Kandagatla wrote:
>
>
> On 27/05/2024 12:19, Mohammad Rafi Shaik wrote:
>> +static int __wcd937x_codec_enable_micbias(struct snd_soc_dapm_widget *w,
>> + int event)
>> +{
>> + struct snd_soc_component *component =
>> snd_soc_dapm_to_component(w->dapm);
>> + int micb_num;
>> +
>> + if (strnstr(w->name, "MIC BIAS1", sizeof("MIC BIAS1")))
>> + micb_num = MIC_BIAS_1;
>> + else if (strnstr(w->name, "MIC BIAS2", sizeof("MIC BIAS2")))
>> + micb_num = MIC_BIAS_2;
>> + else if (strnstr(w->name, "MIC BIAS3", sizeof("MIC BIAS3")))
>> + micb_num = MIC_BIAS_3;
>> + else
>> + return -EINVAL;
>> +
> See last comment..
>
>> + switch (event) {
>> + case SND_SOC_DAPM_PRE_PMU:
>> + wcd937x_micbias_control(component, micb_num,
>> + MICB_ENABLE, true);
>> + break;
>> + case SND_SOC_DAPM_POST_PMU:
>> + usleep_range(1000, 1100);
>> + break;
>> + case SND_SOC_DAPM_POST_PMD:
>> + wcd937x_micbias_control(component, micb_num,
>> + MICB_DISABLE, true);
>> + break;
>> + }
>> +
>> + return 0;
>> +}
>> +
>> +static int wcd937x_codec_enable_micbias(struct snd_soc_dapm_widget *w,
>> + struct snd_kcontrol *kcontrol,
>> + int event)
>> +{
>> + return __wcd937x_codec_enable_micbias(w, event);
>> +}
>> +
>> +static int __wcd937x_codec_enable_micbias_pullup(struct
>> snd_soc_dapm_widget *w,
>> + int event)
>> +{
>> + struct snd_soc_component *component =
>> snd_soc_dapm_to_component(w->dapm);
>> + int micb_num;
>> +
>> + if (strnstr(w->name, "VA MIC BIAS1", sizeof("VA MIC BIAS1")))
>> + micb_num = MIC_BIAS_1;
>> + else if (strnstr(w->name, "VA MIC BIAS2", sizeof("VA MIC BIAS2")))
>> + micb_num = MIC_BIAS_2;
>> + else if (strnstr(w->name, "VA MIC BIAS3", sizeof("VA MIC BIAS3")))
>> + micb_num = MIC_BIAS_3;
>> + else
>> + return -EINVAL;
>> +
> same..
>> + switch (event) {
>> + case SND_SOC_DAPM_PRE_PMU:
>> + wcd937x_micbias_control(component, micb_num,
>> MICB_PULLUP_ENABLE, true);
>> + break;
>> + case SND_SOC_DAPM_POST_PMU:
>> + usleep_range(1000, 1100);
>> + break;
>> + case SND_SOC_DAPM_POST_PMD:
>> + wcd937x_micbias_control(component, micb_num,
>> MICB_PULLUP_DISABLE, true);
>> + break;
>> + }
>> +
>> + return 0;
>> +}
>> +
>
> ...
>
>> static const struct snd_soc_dapm_widget wcd937x_dapm_widgets[] = {
> ...> + /* MIC_BIAS widgets */
>> + SND_SOC_DAPM_SUPPLY("MIC BIAS1", SND_SOC_NOPM, 0, 0,
> Please use shift here like
> SND_SOC_DAPM_SUPPLY("MIC BIAS1", SND_SOC_NOPM, MIC_BIAS_1, 0,
> SND_SOC_DAPM_SUPPLY("MIC BIAS2", SND_SOC_NOPM, MIC_BIAS_2, 0,
>
> to avoid doing a string compares on wideget name.
>
> --srini
>
ACK
Will remove the string compares on widget name and will use the shift here.
Thanks & Regards,
Rafi.
>> + wcd937x_codec_enable_micbias,
>> + SND_SOC_DAPM_PRE_PMU | SND_SOC_DAPM_POST_PMU |
>> + SND_SOC_DAPM_POST_PMD),
>> + SND_SOC_DAPM_SUPPLY("MIC BIAS2", SND_SOC_NOPM, 0, 0,
>> + wcd937x_codec_enable_micbias,
>> + SND_SOC_DAPM_PRE_PMU | SND_SOC_DAPM_POST_PMU |
>> + SND_SOC_DAPM_POST_PMD),
>> + SND_SOC_DAPM_SUPPLY("MIC BIAS3", SND_SOC_NOPM, 0, 0,
>> + wcd937x_codec_enable_micbias,
>> + SND_SOC_DAPM_PRE_PMU | SND_SOC_DAPM_POST_PMU |
>> + SND_SOC_DAPM_POST_PMD),
>> +
>> SND_SOC_DAPM_SUPPLY("VDD_BUCK", SND_SOC_NOPM, 0, 0,
>> wcd937x_codec_enable_vdd_buck,
>> SND_SOC_DAPM_PRE_PMU | SND_SOC_DAPM_POST_PMD),
>> @@ -2007,11 +2312,101 @@ static const struct snd_soc_dapm_widget
>> wcd937x_dapm_widgets[] = {
>> SND_SOC_DAPM_MIXER("HPHR_RDAC", SND_SOC_NOPM, 0, 0,
>> hphr_rdac_switch, ARRAY_SIZE(hphr_rdac_switch)),
>> + /* TX output widgets */
>> + SND_SOC_DAPM_OUTPUT("ADC1_OUTPUT"),
>> + SND_SOC_DAPM_OUTPUT("ADC2_OUTPUT"),
>> + SND_SOC_DAPM_OUTPUT("ADC3_OUTPUT"),
>> + SND_SOC_DAPM_OUTPUT("WCD_TX_OUTPUT"),
>> +
>> /* RX output widgets */
>> SND_SOC_DAPM_OUTPUT("EAR"),
>> SND_SOC_DAPM_OUTPUT("AUX"),
>> SND_SOC_DAPM_OUTPUT("HPHL"),
>> SND_SOC_DAPM_OUTPUT("HPHR"),
>> +
>> + /* MIC_BIAS pull up widgets */
>> + SND_SOC_DAPM_SUPPLY("VA MIC BIAS1", SND_SOC_NOPM, 0, 0,
>> + wcd937x_codec_enable_micbias_pullup,
>> + SND_SOC_DAPM_PRE_PMU | SND_SOC_DAPM_POST_PMU |
>> + SND_SOC_DAPM_POST_PMD),
>> + SND_SOC_DAPM_SUPPLY("VA MIC BIAS2", SND_SOC_NOPM, 0, 0,
>> + wcd937x_codec_enable_micbias_pullup,
>> + SND_SOC_DAPM_PRE_PMU | SND_SOC_DAPM_POST_PMU |
>> + SND_SOC_DAPM_POST_PMD),
>> + SND_SOC_DAPM_SUPPLY("VA MIC BIAS3", SND_SOC_NOPM, 0, 0,
>> + wcd937x_codec_enable_micbias_pullup,
>> + SND_SOC_DAPM_PRE_PMU | SND_SOC_DAPM_POST_PMU |
>> + SND_SOC_DAPM_POST_PMD),
next prev parent reply other threads:[~2024-06-11 4:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 11:19 [RESEND v5 0/7] ASoC: codecs: wcd937x: add wcd937x audio codec support Mohammad Rafi Shaik
2024-05-27 11:19 ` [RESEND v5 1/7] ASoC: dt-bindings: document wcd937x Audio Codec Mohammad Rafi Shaik
2024-05-27 11:19 ` [RESEND v5 2/7] ASoC: codecs: wcd937x-sdw: add SoundWire driver Mohammad Rafi Shaik
2024-05-27 11:19 ` [RESEND v5 3/7] ASoC: codecs: wcd937x: add wcd937x codec driver Mohammad Rafi Shaik
2024-05-27 11:19 ` [RESEND v5 4/7] ASoC: codecs: wcd937x: add basic controls Mohammad Rafi Shaik
2024-05-27 11:19 ` [RESEND v5 5/7] ASoC: codecs: wcd937x: add playback dapm widgets Mohammad Rafi Shaik
2024-05-27 11:19 ` [RESEND v5 6/7] ASoC: codecs: wcd937x: add capture " Mohammad Rafi Shaik
2024-06-10 7:05 ` Srinivas Kandagatla
2024-06-11 4:39 ` Mohammad Rafi Shaik [this message]
2024-05-27 11:19 ` [RESEND v5 7/7] ASoC: codecs: wcd937x: add audio routing and Kconfig Mohammad Rafi Shaik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33772eab-74c6-c5c3-fa25-3a643a2f9c57@quicinc.com \
--to=quic_mohs@quicinc.com \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=quic_pkumpatl@quicinc.com \
--cc=quic_rohkumar@quicinc.com \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox