From: Yijie Yang <quic_yijiyang@quicinc.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] arm64: dts: qcom: qcs8300: add the first 2.5G ethernet
Date: Mon, 25 Nov 2024 11:22:02 +0800 [thread overview]
Message-ID: <34ff9c8a-f288-4f76-be22-a1c784c24d2f@quicinc.com> (raw)
In-Reply-To: <355ff08c-d0a8-49e7-8afc-2e4adddf2c9e@lunn.ch>
On 2024-11-24 03:36, Andrew Lunn wrote:
>> + ethernet0: ethernet@23040000 {
>> + compatible = "qcom,qcs8300-ethqos", "qcom,sa8775p-ethqos";
>> + reg = <0x0 0x23040000 0x0 0x10000>,
>> + <0x0 0x23056000 0x0 0x100>;
>> + reg-names = "stmmaceth", "rgmii";
>
> Dumb question which should not stop this getting merged.
>
> Since this is now a MAC using a SERDES, do you still need the rmgii
> registers? Can the silicon actually do RGMII?
Indeed, the RGMII configuration area is necessary for managing clock
settings, even when SERDES is utilized. For instance, the
RGMII_CONFIG2_RGMII_CLK_SEL_CFG bit within RGMII_IO_MACRO_CONFIG2 is set
in ethqos_configure_sgmii.
>
> Andrew
--
Best Regards,
Yijie
next prev parent reply other threads:[~2024-11-25 3:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-23 8:51 [PATCH v4 0/2] Enable ethernet for qcs8300 Yijie Yang
2024-11-23 8:51 ` [PATCH v4 1/2] arm64: dts: qcom: qcs8300: add the first 2.5G ethernet Yijie Yang
2024-11-23 19:36 ` Andrew Lunn
2024-11-25 3:22 ` Yijie Yang [this message]
2024-12-05 21:30 ` Konrad Dybcio
2024-11-23 8:51 ` [PATCH v4 2/2] arm64: dts: qcom: qcs8300-ride: enable ethernet0 Yijie Yang
2024-11-23 19:41 ` Andrew Lunn
2024-11-25 3:39 ` Yijie Yang
2024-12-05 21:29 ` Konrad Dybcio
2024-12-05 23:39 ` Andrew Lunn
2024-12-06 0:58 ` Yijie Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34ff9c8a-f288-4f76-be22-a1c784c24d2f@quicinc.com \
--to=quic_yijiyang@quicinc.com \
--cc=andersson@kernel.org \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox