From: Nikita Travkin <nikita@trvn.ru>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Val Packett <val@packett.cool>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
cros-qcom-dts-watchers@chromium.org,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/7] arm64: dts: qcom: Add support for ECS LIVA QC710
Date: Wed, 21 Jan 2026 17:16:01 +0500 [thread overview]
Message-ID: <376b932a192d0070b4435542fae62178@trvn.ru> (raw)
In-Reply-To: <c706c227-6f3c-42a5-95bd-9ac739d2fa16@oss.qualcomm.com>
Konrad Dybcio писал(а) 21.01.2026 16:20:
> On 1/21/26 12:30 AM, Val Packett wrote:
>> Add a device tree for the ECS LIVA QC710 (Snapdragon 7c) mini PC/devkit.
>>
>> Working:
>> - Wi-Fi (wcn3990 hw1.0)
>> - Bluetooth
>> - USB Type-A (USB3 and USB2)
>> - Ethernet (over USB2)
>> - HDMI Display
>> - eMMC
>> - SDHC (microSD slot)
>>
>> Not included:
>> - HDMI Audio
>> - EC (IT8987)
>>
>> Signed-off-by: Val Packett <val@packett.cool>
>> ---
>
> [...]
>> +&tlmm {
>> + /*
>> + * The TZ seem to protect those because some boards can have
>> + * fingerprint sensor connected to this range. Not connected
>> + * on this board
>> + */
>> + gpio-reserved-ranges = <58 5>;
>
> Would it still work with <59 4>? 58 seems to not be related to a QUP,
> rather as an audio MCLK output (would that be why +Nikita couldn't get
> some sort of audio working on his aspire1? That DT has it reserved too)
>
FWIW according to aspire1 schematic GPIO 57 is codec mclk (which is
implemented and works perfectly, only DMIC connected to the soc
instead of said codec is broken); GPIO 58~62 are NC with a note
"Finger Printer" [sic] near them. There is no bracket annotation to
associate the note to specific pin range, but it's smack in the
middle of 58~62 range and from the fact that 63 (speaker amp bclk)
and pretty much every other pin later is also used, I guessed all 5
are actually reserved. It's possible that one of them is not
actually reserved by the firmware but probably not the source of
aspire1 issues (the dmic is connected to lpass tlmm anyway) or
perhaps they reserved 58 to be an interrupt input for the fp, or
something like that...
Nikita
> [...]
>
>> + data-pins {
>> + pins = "sdc1_data";
>> + drive-strength = <2>;
>> + bias-pull-up;
>
> here you do:
>
> drive-strength
> bias-
>
> [...]
>
>> + sdc2_default: sdc2-default-state {
>> + clk-pins {
>> + pins = "sdc2_clk";
>> + bias-disable;
>> + drive-strength = <16>;
>> + };
>
> here you do the inverse
>
> (the former is preferred/more common)
>
> otherwise
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>
> Konrad
next prev parent reply other threads:[~2026-01-21 12:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 23:30 [PATCH v2 0/7] Add support for ECS LIVA QC710 mini PC/devkit Val Packett
2026-01-20 23:30 ` [PATCH v2 1/7] dt-bindings: vendor-prefixes: Add ECS (Elitegroup Computer Systems) Val Packett
2026-01-21 8:07 ` Krzysztof Kozlowski
2026-01-20 23:30 ` [PATCH v2 2/7] dt-bindings: vendor-prefixes: Add AlgolTek Val Packett
2026-01-21 9:51 ` Neil Armstrong
2026-01-21 9:53 ` Krzysztof Kozlowski
2026-01-20 23:30 ` [PATCH v2 3/7] dt-bindings: arm: qcom: Add ECS LIVA QC710 Val Packett
2026-01-21 8:07 ` Krzysztof Kozlowski
2026-01-20 23:30 ` [PATCH v2 4/7] dt-bindings: display: bridge: simple: document the Algoltek AG6311 DP-to-HDMI bridge Val Packett
2026-01-20 23:30 ` [PATCH v2 5/7] drm/bridge: simple: add " Val Packett
2026-01-20 23:30 ` [PATCH v2 6/7] arm64: dts: qcom: Add support for ECS LIVA QC710 Val Packett
2026-01-21 11:20 ` Konrad Dybcio
2026-01-21 12:16 ` Nikita Travkin [this message]
2026-01-20 23:30 ` [PATCH v2 7/7] firmware: qcom: scm: Allow QSEECOM on " Val Packett
2026-01-21 9:57 ` (subset) [PATCH v2 0/7] Add support for ECS LIVA QC710 mini PC/devkit Dmitry Baryshkov
2026-03-10 2:45 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=376b932a192d0070b4435542fae62178@trvn.ru \
--to=nikita@trvn.ru \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=val@packett.cool \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox