From: "Koenig, Christian" <Christian.Koenig@amd.com>
To: Archit Taneja <architt@codeaurora.org>
Cc: "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Deucher, Alexander" <Alexander.Deucher@amd.com>
Subject: Re: [RFC 14/21] drm/amdgpu: Remove FB_KMS_HELPER and FB related config options
Date: Mon, 13 Jul 2015 07:08:46 +0000 [thread overview]
Message-ID: <38bd05d3-79ad-4dd5-8eb6-328ac0ac1ae8@email.android.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 1512 bytes --]
Hi Jammy,
I suggested to make the feature optional because of the unit test's.
There we don't need this feature and actually want to test the kernel functionality.
Regards,
Christian.
Am 13.07.2015 08:45 schrieb Archit Taneja <architt@codeaurora.org>:
Remove FB_* config options since the driver doesn't call any fbdev
functions directly.
Remove FB_KMS_HELPER as this would now be selected by the top level
FBDEV_EMULATION config option. If the fbdev emulation isn't selected,
the drm_fb_helper functions will be stubbed out.
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Oded Gabbay <oded.gabbay@gmail.com>
Cc: "Christian König" <christian.koenig@amd.com>
Signed-off-by: Archit Taneja <architt@codeaurora.org>
---
drivers/gpu/drm/amd/amdgpu/Kconfig | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig b/drivers/gpu/drm/amd/amdgpu/Kconfig
index da7dcbf..2396482 100644
--- a/drivers/gpu/drm/amd/amdgpu/Kconfig
+++ b/drivers/gpu/drm/amd/amdgpu/Kconfig
@@ -1,12 +1,8 @@
config DRM_AMDGPU
tristate "AMD GPU"
depends on DRM && PCI
- select FB_CFB_FILLRECT
- select FB_CFB_COPYAREA
- select FB_CFB_IMAGEBLIT
select FW_LOADER
select DRM_KMS_HELPER
- select DRM_KMS_FB_HELPER
select DRM_TTM
select POWER_SUPPLY
select HWMON
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
[-- Attachment #1.2: Type: text/html, Size: 2589 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2015-07-13 7:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 7:08 Koenig, Christian [this message]
2015-07-13 14:05 ` [RFC 14/21] drm/amdgpu: Remove FB_KMS_HELPER and FB related config options Christian König
-- strict thread matches above, loose matches on Subject: below --
2015-07-13 6:43 [RFC 00/21] drm: fb emulation: Step 3: Remove FB_KMS_HELPER config from drivers Archit Taneja
2015-07-13 6:44 ` [RFC 14/21] drm/amdgpu: Remove FB_KMS_HELPER and FB related config options Archit Taneja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38bd05d3-79ad-4dd5-8eb6-328ac0ac1ae8@email.android.com \
--to=christian.koenig@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=architt@codeaurora.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox